acl_test: use _putenv_s() instead of _putenv() on Windows

_putenv_s() is recommended over _putenv() as a more secure variant,
though the exact benefits are not detailed. Unlike the unsafe putenv()
on Linux, _putenv() on Windows does appear to copy its argument. Use
_putenv_s() anyway since it provides the same interface as setenv().

Signed-off-by: Peter Colberg <[email protected]>

Author: pcolberg

test/acl_test.cpp

@@ -188,24 +188,16 @@ SimpleString StringFrom(size_t x) {
 #endif
 
 void acl_test_unsetenv(const char *var) {
-
 #ifdef _WIN32
-  {
-    char buf[1000];
-    sprintf(buf, "%s=", var);
-    _putenv(buf);
-  }
+  _putenv_s(var, "");
 #else
   unsetenv(var);
 #endif
 }
+
 void acl_test_setenv(const char *var, const char *value) {
 #ifdef _WIN32
-  {
-    char buf[1000];
-    sprintf(buf, "%s=%s", var, value);
-    _putenv(buf);
-  }
+  _putenv_s(var, value);
 #else
   setenv(var, value, 1);
 #endif