Fix TSAN data races

------------------------------------------------------

As found in #71, tsan reported several issues in the acl_test

Currently when release command queue are called (which frees the memory) subsequent still checks the values at the same address which cause tsan to report heap-use-after-free.

Author: sherry-yuan

CMakeLists.txt

@@ -68,6 +68,18 @@ if(ACL_CODE_COVERAGE)
   endif()
 endif()
 
+# Flag for tsan scans
+option(ACL_TSAN "Build with tsan" OFF)
+message(STATUS "Build with tsan: ${ACL_TSAN}")
+if(ACL_TSAN)
+  if(CMAKE_COMPILER_IS_GNUCXX)
+    set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -ltsan -fsanitize=thread -g -O1 -fno-omit-frame-pointer -fPIC")
+    set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -ltsan -fsanitize=thread -g -O1 -fno-omit-frame-pointer -fPIC")
+  else()
+    message(FATAL_ERROR "cannot build with tsan tools due to unsupported CXX compiler")
+  endif()
+endif()
+
 ################################################################################
 ### Modified Debug flags
 ################################################################################

test/acl_command_queue_test.cpp

@@ -387,8 +387,6 @@ MT_TEST(acl_command_queue, create_with_properties) {
     CHECK_EQUAL(CL_SUCCESS, clReleaseCommandQueue(cq));
     CHECK_EQUAL(1, acl_ref_count(cq));
     CHECK_EQUAL(CL_SUCCESS, clReleaseCommandQueue(cq));
-    CHECK_EQUAL(0, acl_ref_count(cq));
-    ACL_LOCKED(CHECK(!acl_command_queue_is_valid(cq)));
 
     // wait until all threads do their checks on the 0-ref-count command
     // queue before starting the next iteration of the loop and creating new
@@ -421,8 +419,6 @@ MT_TEST(acl_command_queue, create_with_properties) {
       CHECK_EQUAL(CL_SUCCESS, clReleaseCommandQueue(cq));
       CHECK_EQUAL(1, acl_ref_count(cq));
       CHECK_EQUAL(CL_SUCCESS, clReleaseCommandQueue(cq));
-      CHECK_EQUAL(0, acl_ref_count(cq));
-      ACL_LOCKED(CHECK(!acl_command_queue_is_valid(cq)));
 
       // wait until all threads do their checks on the 0-ref-count command
       // queue before starting the next iteration of the loop and creating new
@@ -674,15 +670,6 @@ MT_TEST(acl_command_queue, after_context_release) {
   // Should be able to release all the way.
   CHECK_EQUAL(CL_SUCCESS, clReleaseCommandQueue(cq0));
   CHECK_EQUAL(CL_SUCCESS, clReleaseCommandQueue(cq1));
-  CHECK_EQUAL(0, acl_ref_count(cq0));
-  CHECK_EQUAL(0, acl_ref_count(cq1));
-
-  ACL_LOCKED(CHECK(!acl_command_queue_is_valid(cq0)));
-  ACL_LOCKED(CHECK(!acl_command_queue_is_valid(cq1)));
-
-  // And once it's gone, it's gone.
-  CHECK_EQUAL(CL_INVALID_COMMAND_QUEUE, clReleaseCommandQueue(cq0));
-  CHECK_EQUAL(CL_INVALID_COMMAND_QUEUE, clReleaseCommandQueue(cq1));
 }
 
 // Main Event is in an OOO queue. It has a dependent event in an in-order queue.