Add helper for parsing MMD version string

Author: sophimao

src/acl_hal_mmd.cpp

@@ -417,6 +417,39 @@ static int debug_verbosity = 0;
 // ************************** Helper functions ******************************
 // **************************************************************************
 
+// Version string format should be MAJOR.MINOR(.PATCH)
+// To compare the MMD/HAL versions we will only compare the last two digits
+// of the MAJOR field together with the MINOR field, and ignore the PATCH field
+// if that exists. This function truncates the version string to exactly that
+// and convert it to double to be compared. Returns -1 if input is invalid.
+double l_parse_mmd_version_str(std::string version_str) {
+  size_t start_idx, length;
+
+  // Find the '.' between the MAJOR and MINOR field
+  std::string::size_type i = version_str.find('.');
+  if (i == std::string::npos || i < 2) {
+    return -1;
+  } else {
+    start_idx = i - 2;
+  }
+  // Check if there is a '.' for PATCH field
+  std::string::size_type j = version_str.find('.', i + 1);
+  length = (j == std::string::npos ? version_str.length() : j) - start_idx;
+
+  // Get the part of the MMD version string that will be used to compare
+  // for compatibility with the runtime HAL
+  std::string version_substr = version_str.substr(start_idx, length);
+  double mmd_version_num = 0;
+  try {
+    mmd_version_num = std::stod(version_substr);
+  } catch (const std::exception &) {
+    // Just return error and let the caller handle failure
+    return -1;
+  }
+
+  return mmd_version_num;
+}
+
 // MMD dynamic load helpers
 #ifdef _WIN32
 char *acl_strtok(char *str, const char *delim, char **saveptr) {
@@ -963,22 +996,40 @@ void l_get_physical_devices(acl_mmd_dispatch_t *mmd_dispatch,
   mmd_dispatch->aocl_mmd_get_offline_info(AOCL_MMD_VERSION, sizeof(buf), buf,
                                           NULL);
   buf[sizeof(buf) - 1] = 0;
-  mmd_dispatch->mmd_version = atof(buf);
+  mmd_dispatch->mmd_version = l_parse_mmd_version_str(std::string(buf));
+  if (mmd_dispatch->mmd_version < 0) {
+    printf("  Invalid MMD version:     %s\n", buf);
+    printf("Contact the board package support vendor for resolution.\n");
+    fflush(stdout);
+    assert(0);
+  }
   min_MMD_version =
       (!MMDVERSION_LESSTHAN(min_MMD_version, mmd_dispatch->mmd_version))
           ? mmd_dispatch->mmd_version
           : min_MMD_version;
   ACL_HAL_DEBUG_MSG_VERBOSE(1, "HAL : Getting info version: %s\n", buf);
 
-  if (MMDVERSION_LESSTHAN(atof(AOCL_MMD_VERSION_STRING),
+  static double hal_version = 0;
+  if (hal_version == 0) { // Just parse once at start-up
+    hal_version = l_parse_mmd_version_str(AOCL_MMD_VERSION_STRING);
+    if (hal_version < 0) { // This should theoretically never happen
+      printf("  Invalid runtime version: %s\n", AOCL_MMD_VERSION_STRING);
+      fflush(stdout);
+      assert(0);
+    }
+  }
+  if (MMDVERSION_LESSTHAN(hal_version,
                           mmd_dispatch->mmd_version) || // MMD newer than HAL
       MMDVERSION_LESSTHAN(mmd_dispatch->mmd_version,
                           14.0)) // Before this wasn't forward compatible
   {
     printf("  Runtime version: %s\n", AOCL_MMD_VERSION_STRING);
     printf("  MMD version:     %s\n", buf);
+    printf("MMD version is newer than the runtime version! Use the runtime "
+           "with version greater or equal to the MMD version, or contact the "
+           "board support package vendors if mismatch is unexpected.\n");
     fflush(stdout);
-    assert(0 && "MMD version mismatch");
+    assert(0);
   }
 
   // Disable yield as initialization
@@ -2682,8 +2733,7 @@ int acl_hal_mmd_support_buffer_location(
   for (const auto &device : devices) {
     unsigned int physical_device_id = device->def.physical_device_id;
     if (MMDVERSION_LESSTHAN(
-            device_info[physical_device_id].mmd_dispatch->mmd_version,
-            2024.2)) {
+            device_info[physical_device_id].mmd_dispatch->mmd_version, 24.2)) {
       bl_supported = 0;
     }
   }