Fixed coverity issue in acl_mem.cpp: Memory leak

(Line 4172) Missing free for a malloc object before returning, same with (line 4183)
Solution: Turning `needs_release_on_fail` into vector since it is only present in the scope of this function

Author: haoxian2

src/acl_mem.cpp

@@ -2773,7 +2773,7 @@ CL_API_ENTRY void *CL_API_CALL clEnqueueMapImageIntelFPGA(
         image->mem_object_type == CL_MEM_OBJECT_IMAGE1D_BUFFER) {
       if (image_slice_pitch == NULL) {
         BAIL_INFO(CL_INVALID_VALUE, command_queue->context,
-              "Invalid slice pitch provided");
+                  "Invalid slice pitch provided");
       }
       *image_slice_pitch = 0;
     } else if (image->mem_object_type == CL_MEM_OBJECT_IMAGE1D_ARRAY) {
@@ -2782,7 +2782,7 @@ CL_API_ENTRY void *CL_API_CALL clEnqueueMapImageIntelFPGA(
       *image_slice_pitch =
           image->fields.image_objs.image_desc->image_height * tmp_row_pitch;
     }
-    
+
     tmp_slice_pitch = *image_slice_pitch;
   }
 
@@ -4065,7 +4065,6 @@ ACL_EXPORT CL_API_ENTRY cl_int CL_API_CALL clEnqueueMigrateMemObjectsIntelFPGA(
   cl_event local_event = 0;
   unsigned int physical_id;
   unsigned int mem_id;
-  int *needs_release_on_fail;
 
   std::scoped_lock lock{acl_mutex_wrapper};
 
@@ -4110,10 +4109,7 @@ ACL_EXPORT CL_API_ENTRY cl_int CL_API_CALL clEnqueueMigrateMemObjectsIntelFPGA(
 
   // Try to reserve space for all the buffers to be moved. If we fail, we need
   // to know which buffers to deallocate:
-  needs_release_on_fail = (int *)malloc(sizeof(int) * num_mem_objects);
-  for (i = 0; i < num_mem_objects; ++i) {
-    needs_release_on_fail[i] = 0;
-  }
+  std::vector<bool> needs_release_on_fail(num_mem_objects, false);
 
   status = CL_SUCCESS;
   for (i = 0; i < num_mem_objects; ++i) {
@@ -4128,7 +4124,7 @@ ACL_EXPORT CL_API_ENTRY cl_int CL_API_CALL clEnqueueMigrateMemObjectsIntelFPGA(
         status = CL_MEM_OBJECT_ALLOCATION_FAILURE;
         break;
       }
-      needs_release_on_fail[i] = 1;
+      needs_release_on_fail[i] = true;
     }
     mem_objects[i]->reserved_allocations_count[physical_id][mem_id]++;
   }
@@ -4144,7 +4140,6 @@ ACL_EXPORT CL_API_ENTRY cl_int CL_API_CALL clEnqueueMigrateMemObjectsIntelFPGA(
       }
       mem_objects[i]->reserved_allocations_count[physical_id][mem_id]--;
     }
-    free(needs_release_on_fail);
     return status;
   }
 
@@ -4155,7 +4150,6 @@ ACL_EXPORT CL_API_ENTRY cl_int CL_API_CALL clEnqueueMigrateMemObjectsIntelFPGA(
                        CL_COMMAND_MIGRATE_MEM_OBJECTS, &local_event);
 
   if (status != CL_SUCCESS) {
-    free(needs_release_on_fail);
     return status; // already signalled callback
   }
 
@@ -4201,8 +4195,6 @@ ACL_EXPORT CL_API_ENTRY cl_int CL_API_CALL clEnqueueMigrateMemObjectsIntelFPGA(
     acl_idle_update(command_queue->context); // Clean up early
   }
 
-  free(needs_release_on_fail);
-
   return CL_SUCCESS;
 }
 
@@ -6824,9 +6816,9 @@ static void acl_dump_mem_internal(cl_mem mem) {
                   ? "is malloc"
                   : "not malloc"));
       printf("              .begin             %p\n",
-            mem->block_allocation->range.begin);
+             mem->block_allocation->range.begin);
       printf("              .end               %p\n",
-            mem->block_allocation->range.next);
+             mem->block_allocation->range.next);
     }
     printf("              .mappings          %d\n", mem->mapping_count);
     acl_print_debug_msg("              .size              %lu\n", mem->size);