Skip to content

Commit 94b5dbd

Browse files
IlanTruanovskypcolberg
authored andcommitted
Fix Coverity issues in acl_globals_test.cpp
Fixes: ``` test/acl_globals_test.cpp:697:1: Type: Unchecked return value (CHECKED_RETURN) test/acl_globals_test.cpp:697:1: Unchecked call to function 1. check_return: Calling "acl_set_hal" without checking return value (as is done elsewhere 27 out of 31 times). src/acl_globals.cpp:206:3: Examples where return value from this function is checked 2. example_checked: Example 1: "acl_set_hal(board_hal)" has its value checked in "acl_set_hal(board_hal)". test/acl_hal_test.cpp:302:3: Examples where return value from this function is checked 3. example_checked: Example 2: "acl_set_hal(&simple_hal)" has its value checked in "acl_set_hal(&simple_hal)". test/acl_hal_test.cpp:180:3: Examples where return value from this function is checked 4. example_checked: Example 3: "acl_set_hal(&simple_hal)" has its value checked in "1 == acl_set_hal(&simple_hal)". test/acl_hal_test.cpp:231:3: Examples where return value from this function is checked 5. example_checked: Example 4: "acl_set_hal(&bad_hal)" has its value checked in "0 == acl_set_hal(&bad_hal)". test/acl_hal_test.cpp:234:3: Examples where return value from this function is checked 6. example_checked: Example 5: "acl_set_hal(&bad_hal)" has its value checked in "0 != acl_set_hal(&bad_hal)". ```
1 parent 8dee731 commit 94b5dbd

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

test/acl_globals_test.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -694,7 +694,7 @@ const acl_system_def_t *acl_test_get_empty_system_def() {
694694
}
695695

696696
TEST_GROUP(acl_globals_undef){void setup(){acl_mutex_wrapper.lock();
697-
acl_set_hal(acl_test_get_simple_hal());
697+
CHECK(acl_set_hal(acl_test_get_simple_hal()));
698698
}
699699
void teardown() {
700700
acl_reset_hal();

0 commit comments

Comments
 (0)