Fixed coverity issue in acl_auto_configure.cpp: Type: Unused value (UNUSED_VALUE)

Author: haoxian2

src/acl_auto_configure.cpp

@@ -724,15 +724,12 @@ static bool read_accel_defs(const std::string &config_str,
     accel[i].mem.next = reinterpret_cast<void *>(0x00020000);
 
     int total_fields_kernel = 0;
-    if (result) {
-      result = read_int_counters(config_str, curr_pos, total_fields_kernel,
-                                 counters);
-    }
+    result = result && read_int_counters(config_str, curr_pos,
+                                         total_fields_kernel, counters);
     counters.emplace_back(total_fields_kernel);
 
-    result =
-        read_string_counters(config_str, curr_pos, hal_info[i].name, counters);
-
+    result = result && read_string_counters(config_str, curr_pos,
+                                            hal_info[i].name, counters);
     if (!result)
       break;
     accel[i].iface.name = hal_info[i].name;

src/acl_kernel_if.cpp

@@ -1258,9 +1258,8 @@ void acl_kernel_if_launch_kernel_on_custom_sof(
     offset = (unsigned int)(KERNEL_OFFSET_INVOCATION_IMAGE +
                             kern->cra_address_offset);
     image_p = (uintptr_t) & (image->work_dim);
-    image_size_static =
-        (size_t)((uintptr_t) & (image->arg_value) - (uintptr_t) &
-                 (image->work_dim));
+    image_size_static = (size_t)(
+        (uintptr_t) & (image->arg_value) - (uintptr_t) & (image->work_dim));
   }
 
   if ((kern->io.debug_verbosity) >= 2) {

src/acl_mem.cpp

@@ -438,9 +438,7 @@ CL_API_ENTRY cl_mem clCreateBufferWithPropertiesINTEL(
     case CL_MEM_ALLOC_BUFFER_LOCATION_INTEL: {
       tmp_mem_id = (cl_uint) * (properties + 1);
     } break;
-    default: {
-      BAIL_INFO(CL_INVALID_DEVICE, context, "Invalid properties");
-    }
+    default: { BAIL_INFO(CL_INVALID_DEVICE, context, "Invalid properties"); }
     }
     properties += 2;
   }
@@ -5566,8 +5564,8 @@ void acl_mem_migrate_buffer(void *user_data, acl_device_op_t *op) {
 
 #ifdef MEM_DEBUG_MSG
               printf("release block %zx (%u:%u) ",
-                     (size_t)(src_mem->reserved_allocations[src_device]
-                                                           [src_mem_id]),
+                     (size_t)(
+                         src_mem->reserved_allocations[src_device][src_mem_id]),
                      src_device, src_mem_id);
 #endif
               remove_mem_block_linked_list(
@@ -5953,9 +5951,8 @@ static void l_mem_transfer_buffer_explicitly(cl_context context,
           dst_unmap_cmd.info.mem_xfer.map_flags = CL_MAP_WRITE;
         }
         dst_unmap_cmd.info.mem_xfer.src_mem = context->unwrapped_host_mem;
-        dst_unmap_cmd.info.mem_xfer.src_offset[0] =
-            (size_t)((char *)dst_mem->host_mem.aligned_ptr -
-                     (char *)ACL_MEM_ALIGN);
+        dst_unmap_cmd.info.mem_xfer.src_offset[0] = (size_t)(
+            (char *)dst_mem->host_mem.aligned_ptr - (char *)ACL_MEM_ALIGN);
         dst_unmap_cmd.info.mem_xfer.src_offset[1] = 0;
         dst_unmap_cmd.info.mem_xfer.src_offset[2] = 0;
         dst_unmap_cmd.info.mem_xfer.dst_mem = dst_mem;
@@ -6319,9 +6316,8 @@ void acl_copy_device_buffers_to_host_before_programming(
       cmd.info.mem_xfer.src_offset[2] = 0;
       cmd.info.mem_xfer.dst_mem = context2->unwrapped_host_mem;
       if (mem->flags & CL_MEM_USE_HOST_PTR) {
-        cmd.info.mem_xfer.dst_offset[0] =
-            (size_t)((char *)mem->fields.buffer_objs.host_ptr -
-                     (char *)ACL_MEM_ALIGN);
+        cmd.info.mem_xfer.dst_offset[0] = (size_t)(
+            (char *)mem->fields.buffer_objs.host_ptr - (char *)ACL_MEM_ALIGN);
       } else {
         cmd.info.mem_xfer.dst_offset[0] =
             (size_t)((char *)mem->host_mem.aligned_ptr - (char *)ACL_MEM_ALIGN);
@@ -6465,9 +6461,8 @@ void acl_copy_device_buffers_from_host_after_programming(
       cmd.type = CL_COMMAND_WRITE_BUFFER;
       cmd.info.mem_xfer.src_mem = context2->unwrapped_host_mem;
       if (mem->flags & CL_MEM_USE_HOST_PTR) {
-        cmd.info.mem_xfer.src_offset[0] =
-            (size_t)((char *)mem->fields.buffer_objs.host_ptr -
-                     (char *)ACL_MEM_ALIGN);
+        cmd.info.mem_xfer.src_offset[0] = (size_t)(
+            (char *)mem->fields.buffer_objs.host_ptr - (char *)ACL_MEM_ALIGN);
       } else {
         cmd.info.mem_xfer.src_offset[0] =
             (size_t)((char *)mem->host_mem.aligned_ptr - (char *)ACL_MEM_ALIGN);

src/acl_printf.cpp

@@ -911,11 +911,13 @@ static size_t l_dump_printf_buffer(cl_event event, cl_kernel kernel,
       length = get_length_specifier(data_elem._conversion_string);
 
 #ifdef DEBUG
-      printf("length specifier=%s\n", length == LS_HL   ? "LS_HL"
-                                      : length == LS_HH ? "LS_HH"
-                                      : length == LS_H  ? "LS_H"
-                                      : length == LS_L  ? "LS_L"
-                                                        : "NONE");
+      printf("length specifier=%s\n",
+             length == LS_HL
+                 ? "LS_HL"
+                 : length == LS_HH
+                       ? "LS_HH"
+                       : length == LS_H ? "LS_H"
+                                        : length == LS_L ? "LS_L" : "NONE");
 #endif
 
       // the size of the data we are converting right now

src/acl_usm.cpp

@@ -112,9 +112,7 @@ CL_API_ENTRY void *CL_API_CALL clHostMemAllocINTEL(
     case CL_MEM_ALLOC_BUFFER_LOCATION_INTEL: {
       mem_id = (cl_uint) * (properties + 1);
     } break;
-    default: {
-      BAIL_INFO(CL_INVALID_PROPERTY, context, "Invalid properties");
-    }
+    default: { BAIL_INFO(CL_INVALID_PROPERTY, context, "Invalid properties"); }
     }
     properties += 2;
   }
@@ -267,9 +265,7 @@ clDeviceMemAllocINTEL(cl_context context, cl_device_id device,
     case CL_MEM_ALLOC_BUFFER_LOCATION_INTEL: {
       mem_id = (cl_uint) * (properties + 1);
     } break;
-    default: {
-      BAIL_INFO(CL_INVALID_DEVICE, context, "Invalid properties");
-    }
+    default: { BAIL_INFO(CL_INVALID_DEVICE, context, "Invalid properties"); }
     }
     properties += 2;
   }
@@ -421,9 +417,7 @@ clSharedMemAllocINTEL(cl_context context, cl_device_id device,
       }
       mem_id = (cl_uint) * (properties + 1);
     } break;
-    default: {
-      BAIL_INFO(CL_INVALID_PROPERTY, context, "Invalid properties");
-    }
+    default: { BAIL_INFO(CL_INVALID_PROPERTY, context, "Invalid properties"); }
     }
     properties += 2;
   }