Fixed coverity issues in acl_hal_mmd.cpp: Type: Resource leak (RESOURCE_LEAK)

haoxian2 · zibaiwan · commit d3e898f27622 · 2023-01-10T12:12:39.000-05:00
diff --git a/src/acl_hal_mmd.cpp b/src/acl_hal_mmd.cpp
@@ -855,6 +855,7 @@ cl_bool l_load_board_libraries(cl_bool load_libraries) {
       }
       fin.close();
     }
+    closedir(dir);
   }
 
   if (num_vendor_files_found == 0) {
@@ -876,8 +877,6 @@ cl_bool l_load_board_libraries(cl_bool load_libraries) {
     }
   }
 
-  if (dir)
-    closedir(dir);
   return num_boards_found == 0 ? CL_FALSE : CL_TRUE;
 }
 #endif

Original file line number	Diff line number	Diff line change
`@@ -855,6 +855,7 @@ cl_bool l_load_board_libraries(cl_bool load_libraries) {`
`855`	`855`	`}`
`856`	`856`	`fin.close();`
`857`	`857`	`}`
	`858`	`+ closedir(dir);`
`858`	`859`	`}`
`859`	`860`
`860`	`861`	`if (num_vendor_files_found == 0) {`
`@@ -876,8 +877,6 @@ cl_bool l_load_board_libraries(cl_bool load_libraries) {`
`876`	`877`	`}`
`877`	`878`	`}`
`878`	`879`
`879`		`- if (dir)`
`880`		`- closedir(dir);`
`881`	`880`	`return num_boards_found == 0 ? CL_FALSE : CL_TRUE;`
`882`	`881`	`}`
`883`	`882`	`#endif`