Fixed CHECK_RETURN Coverity issues

lib/pkg_editor/src/pkg_editor.c:1604:3:
  Type: Unchecked return value from library (CHECKED_RETURN)

lib/pkg_editor/src/pkg_editor.c:1584:3: Unchecked call to function
  1. path: Condition "buffer != NULL", taking true branch. lib/pkg_editor/src/pkg_editor.c:1585:5:
  2. path: Condition "input == NULL", taking true branch. lib/pkg_editor/src/pkg_editor.c:1585:5:
  3. path: Falling through to end of if statement. lib/pkg_editor/src/pkg_editor.c:1588:3:
  4. path: Falling through to end of if statement. lib/pkg_editor/src/pkg_editor.c:1594:3:
  5. path: Condition "ret != 0", taking false branch. lib/pkg_editor/src/pkg_editor.c:1604:3:
  6. check_return: Calling "mkdir(full_name, 493U)" without checking return value. This library function may fail and return an error code.

lib/pkg_editor/src/pkg_editor.c:1651:7:
  Type: Unchecked return value from library (CHECKED_RETURN)

lib/pkg_editor/src/pkg_editor.c:1584:3: Unchecked call to function
  1. path: Condition "buffer != NULL", taking true branch. lib/pkg_editor/src/pkg_editor.c:1585:5:
  2. path: Condition "input == NULL", taking true branch. lib/pkg_editor/src/pkg_editor.c:1585:5:
  3. path: Falling through to end of if statement. lib/pkg_editor/src/pkg_editor.c:1588:3:
  4. path: Falling through to end of if statement. lib/pkg_editor/src/pkg_editor.c:1594:3:
  5. path: Condition "ret != 0", taking false branch. lib/pkg_editor/src/pkg_editor.c:1610:3:
  6. path: Condition "z_info.strm.avail_in > 0", taking true branch. lib/pkg_editor/src/pkg_editor.c:1612:5:
  7. path: Condition "!read_data(&info, 20UL /* sizeof (info) */, &z_info, input)", taking false branch. lib/pkg_editor/src/pkg_editor.c:1617:5:
  8. path: Condition "info.magic != 3203399403U", taking false branch. lib/pkg_editor/src/pkg_editor.c:1625:5:
  9. path: Condition "info.kind == PACK_END", taking false branch. lib/pkg_editor/src/pkg_editor.c:1630:5:
  10. path: Condition "!read_data(name, info.name_length, &z_info, input)", taking false branch. lib/pkg_editor/src/pkg_editor.c:1638:5:
  11. path: Condition "12288UL /* 3 * 4096 */ < out_dir_length", taking true branch. lib/pkg_editor/src/pkg_editor.c:1643:5:
  12. path: Condition "full_name[12287 /* 3 * 4096 - 1 */] != 0", taking true branch. lib/pkg_editor/src/pkg_editor.c:1647:5:
  13. path: Condition "info.kind == PACK_DIR", taking true branch. lib/pkg_editor/src/pkg_editor.c:1651:7:
  14. check_return: Calling "mkdir(full_name, 493U)" without checking return value. This library function may fail and return an error code.

Author: IlanTruanovsky

lib/pkg_editor/src/pkg_editor.c

@@ -1514,6 +1514,17 @@ int acl_pkg_pack(const char *out_file, const char **input_files_dirs) {
   return 1 /* success */;
 }
 
+static void create_dir(const char *dir_name) {
+  // Create output directory. We can ignore the error output since it will
+  // only delay the failure to the first attempt of creating a file in the
+  // (not) newly created directory.
+#ifdef _WIN32
+  (void)CreateDirectory(dir_name, NULL);
+#else
+  (void)mkdir(dir_name, 0755);
+#endif
+}
+
 static int read_data(void *data, size_t size, ZInfo *z_info, FILE *in_fd) {
   // We want to fill 'data' with 'size' bytes.
   z_info->strm.next_out = data;
@@ -1593,12 +1604,7 @@ static int acl_pkg_unpack_buffer_or_file(const char *buffer, size_t buffer_size,
     return 0;
   }
 
-  // Create output directory (ignore any errors).
-#ifdef _WIN32
-  CreateDirectory(full_name, NULL);
-#else
-  mkdir(full_name, 0755);
-#endif
+  create_dir(full_name);
   full_name[out_dir_length] = '/';
 
   // Process the file until we hit the PACK_END record (or finish the
@@ -1644,11 +1650,7 @@ static int acl_pkg_unpack_buffer_or_file(const char *buffer, size_t buffer_size,
     full_name[FULL_NAME_LEN - 1] = '\0';
 
     if (info.kind == PACK_DIR) {
-#ifdef _WIN32
-      CreateDirectory(full_name, NULL);
-#else
-      mkdir(full_name, 0755);
-#endif
+      create_dir(full_name);
     } else {
       // Read file contents
       FILE *out_file = fopen(full_name, "wb");