fixup! Fixed coverity in acl_hal_mmd.cpp: Resource leak (RESOURCE_LEAK)

Author: pcolberg

include/acl_hal_mmd.h

@@ -52,11 +52,7 @@ struct aocl_mmd_streaming_kernel_arg_info_t {
 #define MMDVERSION_LESSTHAN(A, B) ((float)(A) < (float)(B))
 
 typedef struct {
-  struct library_deleter {
-    void operator()(void *library);
-  };
-
-  using library_pointer = std::unique_ptr<void, library_deleter>;
+  using library_pointer = std::shared_ptr<void>;
 
   std::string library_name;
   library_pointer mmd_library;

src/acl_hal_mmd.cpp

@@ -433,12 +433,14 @@ static void *my_dlsym(void *library, const char *function_name,
   return symbol;
 }
 
-void acl_mmd_dispatch_t::library_deleter::operator()(void *library) {
+static void my_dlclose(void *library) {
+  if (library) {
 #ifdef _WIN32
-  FreeLibrary((HMODULE)library);
+    FreeLibrary((HMODULE)library);
 #else
-  dlclose(library);
+    dlclose(library);
 #endif
+  }
 }
 
 cl_bool l_load_board_functions(acl_mmd_dispatch_t *mmd_dispatch,
@@ -574,7 +576,7 @@ cl_bool l_load_single_board_library(const char *library_name,
   }
 #endif
   acl_mmd_dispatch_t::library_pointer mmd_library{
-      my_dlopen(library_name, &error_msg)};
+      my_dlopen(library_name, &error_msg), my_dlclose};
   if (!mmd_library) {
     std::cout << "Error: Could not load board library " << library_name;
     if (error_msg && error_msg[0] != '\0') {
@@ -594,7 +596,7 @@ cl_bool l_load_single_board_library(const char *library_name,
     mmd_library.reset();
     ACL_HAL_DEBUG_MSG_VERBOSE(
         1, "This library is a custom library. Opening globally.\n");
-    mmd_library.reset(my_dlopen_global(library_name, &error_msg));
+    mmd_library.reset(my_dlopen_global(library_name, &error_msg), my_dlclose);
     if (!mmd_library) {
       std::cout << "Error: Could not load custom library " << library_name;
       if (error_msg && error_msg[0] != '\0') {
@@ -1162,7 +1164,7 @@ static acl_mmd_dispatch_t *get_msim_mmd_layer() {
 
   char *error_msg = nullptr;
   acl_mmd_dispatch_t::library_pointer mmd_lib{
-      my_dlopen(mmd_lib_name, &error_msg)};
+      my_dlopen(mmd_lib_name, &error_msg), my_dlclose};
   typedef acl_mmd_dispatch_t *(*fcn_type)();
   if (!mmd_lib) {
     std::cout << "Error: Could not load simulation MMD library "