Fixed coverity in acl_program.cpp: Dereference before null check (REVERSE_INULL)

haoxian2 · zibaiwan · commit f510b0a0f6a6 · 2023-01-19T09:57:48.000-05:00
diff --git a/src/acl_program.cpp b/src/acl_program.cpp
@@ -142,8 +142,7 @@ CL_API_ENTRY cl_int CL_API_CALL clReleaseProgramIntelFPGA(cl_program program) {
       if (program->device[i]->last_bin != nullptr)
         program->device[i]->last_bin->unload_content();
     }
-    if (program)
-      l_free_program(program);
+    l_free_program(program);
   }
   return CL_SUCCESS;
 }

Original file line number	Diff line number	Diff line change
`@@ -142,8 +142,7 @@ CL_API_ENTRY cl_int CL_API_CALL clReleaseProgramIntelFPGA(cl_program program) {`
`142`	`142`	`if (program->device[i]->last_bin != nullptr)`
`143`	`143`	`program->device[i]->last_bin->unload_content();`
`144`	`144`	`}`
`145`		`- if (program)`
`146`		`- l_free_program(program);`
	`145`	`+ l_free_program(program);`
`147`	`146`	`}`
`148`	`147`	`return CL_SUCCESS;`
`149`	`148`	`}`