Fixed coverity in acl_device.cpp: Argument cannot be negative (NEGATIVE_RETURNS)

`acl_get_default_device_global_memory` can return `-1` if no device memory is found. By static_casting it to `size_t`, it makes the -1 into something irrationally big. Therefore, after returning from the function, I added a check to see if `gmem_id` is negative. If it is negative, then I return 0. I assumed that no device private memory means that by default the sizes of global memory, of max constant buffer, and of max device memory allocation are all `0`.

Author: haoxian2

src/acl_device.cpp

@@ -209,10 +209,14 @@ CL_API_ENTRY cl_int CL_API_CALL clGetDeviceInfoIntelFPGA(
     RESULT_INT(0);
     break;
   case CL_DEVICE_GLOBAL_MEM_SIZE: {
-    auto gmem_id =
-        static_cast<size_t>(acl_get_default_device_global_memory(device->def));
+    auto gmem_id = acl_get_default_device_global_memory(device->def);
+    if (gmem_id < 0) {
+      RESULT_INT(0);
+      break;
+    }
     cl_ulong size =
-        ACL_RANGE_SIZE(device->def.autodiscovery_def.global_mem_defs[gmem_id]
+        ACL_RANGE_SIZE(device->def.autodiscovery_def
+                           .global_mem_defs[static_cast<size_t>(gmem_id)]
                            .get_usable_range());
 #ifdef __arm__
     // on SoC board, two DDR systems are not equivalent
@@ -255,10 +259,14 @@ CL_API_ENTRY cl_int CL_API_CALL clGetDeviceInfoIntelFPGA(
     // However conformance_test_api min_max_constant_buffer_size
     // expects to allocate two buffers of the size we say here.
     // So be a shade conservative and cut it down by 4.
-    auto gmem_id =
-        static_cast<size_t>(acl_get_default_device_global_memory(device->def));
+    auto gmem_id = acl_get_default_device_global_memory(device->def);
+    if (gmem_id < 0) {
+      RESULT_INT(0);
+      break;
+    }
     cl_ulong size =
-        ACL_RANGE_SIZE(device->def.autodiscovery_def.global_mem_defs[gmem_id]
+        ACL_RANGE_SIZE(device->def.autodiscovery_def
+                           .global_mem_defs[static_cast<size_t>(gmem_id)]
                            .get_usable_range()) /
         4;
 #ifdef __arm__
@@ -268,10 +276,14 @@ CL_API_ENTRY cl_int CL_API_CALL clGetDeviceInfoIntelFPGA(
     RESULT_ULONG(size);
   } break;
   case CL_DEVICE_MAX_MEM_ALLOC_SIZE: {
-    auto gmem_id =
-        static_cast<size_t>(acl_get_default_device_global_memory(device->def));
+    auto gmem_id = acl_get_default_device_global_memory(device->def);
+    if (gmem_id < 0) {
+      RESULT_INT(0);
+      break;
+    }
     cl_ulong size =
-        ACL_RANGE_SIZE(device->def.autodiscovery_def.global_mem_defs[gmem_id]
+        ACL_RANGE_SIZE(device->def.autodiscovery_def
+                           .global_mem_defs[static_cast<size_t>(gmem_id)]
                            .get_usable_range());
 #ifdef __arm__
     // on SoC board, two DDR systems are not equivalent