From fef227ecd591327ec15edd1c528e7b2a0585b70b Mon Sep 17 00:00:00 2001 From: Ilan Truanovsky Date: Mon, 9 Jan 2023 08:16:43 -0800 Subject: [PATCH] Explicitly convert function to function pointer during comparison This fixes the following Coverity issue: src/acl_support.cpp:403:34: Type: Function address comparison (BAD_COMPARE) src/acl_support.cpp:403:34: func_conv: This implicit conversion to a function pointer is suspicious: "dlopen != NULL". src/acl_support.cpp:403:34: remediation: Did you intend to call "dlopen"? --- src/acl_support.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/acl_support.cpp b/src/acl_support.cpp index 38b9f5ad..cdecedce 100644 --- a/src/acl_support.cpp +++ b/src/acl_support.cpp @@ -374,7 +374,7 @@ char *acl_dlerror(void) { } } -int acl_dlpresent(void) { return LoadLibrary != 0; } +int acl_dlpresent(void) { return &LoadLibrary != nullptr; } int acl_dlclose(void *handle) { return (int)FreeLibrary((HMODULE)handle); } @@ -400,7 +400,7 @@ void *acl_dlsym(void *dllhandle, const char *symbolname) { char *acl_dlerror(void) { return dlerror(); } -int acl_dlpresent(void) { return dlopen != 0; } +int acl_dlpresent(void) { return &dlopen != nullptr; } int acl_dlclose(void *dllhandle) { return !dlclose(dllhandle); }