Update with latest versions #161
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I recreated the sample application based on instructions from https://create-react-app.dev/docs/getting-started/ as had been done previously in this tutorial repository. That updates the application and should replace the pull requests: * jenkins-docs#100 * jenkins-docs#138 * jenkins-docs#140 * jenkins-docs#141 * jenkins-docs#142 * jenkins-docs#143 * jenkins-docs#144 * jenkins-docs#146 * jenkins-docs#147 * jenkins-docs#150 https://react.dev/blog/2025/02/14/sunsetting-create-react-app announces that as of Feb 2025, Create React App is deprecated for new apps. Existing apps are recommended to migrate to a framework or to a build tool like Vite. https://react.dev/learn/creating-a-react-app#react-router-v7 notes that React Router is the most popular routing library for React and can be paired with Vite to create a full-stack React framework. Since we're using Vite for the new documentation site, it is probably best to use React Router and Vite when we replace the sample application in this repository. Testing done: * Ran the application with `npm start` and confirmed that it rendered as expected on port 3000 * Ran the `jenkins/scripts/test.sh` script and confirmed that tests pass * Ran the `jenkins/scripts/deliver.sh` script and confirm that the site built and rendered as expected on port 3000
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update with latest versions
I recreated the sample application based on instructions from https://create-react-app.dev/docs/getting-started/ as had been done previously in this tutorial repository.
That updates the application and should replace the pull requests:
The React blog announces that as of Feb 2025, Create React App is deprecated for new apps. Existing apps are recommended to migrate to a framework or to a build tool like Vite.
The React dec site notes that React Router is the most popular routing library for React and can be paired with Vite to create a full-stack React framework. Since we're using Vite for the new documentation site, it is probably best to use React Router and Vite when we replace the sample application in this repository.
Testing done
npm startand confirmed that it rendered as expected on port 3000jenkins/scripts/test.shscript and confirmed that tests passjenkins/scripts/deliver.shscript and confirm that the site built and rendered as expected on port 3000