diff --git a/.config/dotnet-tools.json b/.config/dotnet-tools.json
index 8c08ac9c20..69e33b978d 100644
--- a/.config/dotnet-tools.json
+++ b/.config/dotnet-tools.json
@@ -3,13 +3,13 @@
"isRoot": true,
"tools": {
"jetbrains.resharper.globaltools": {
- "version": "2021.3.0",
+ "version": "2021.3.4",
"commands": [
"jb"
]
},
"regitlint": {
- "version": "6.0.6",
+ "version": "6.0.8",
"commands": [
"regitlint"
]
@@ -21,7 +21,7 @@
]
},
"dotnet-reportgenerator-globaltool": {
- "version": "5.0.0",
+ "version": "5.1.3",
"commands": [
"reportgenerator"
]
diff --git a/CodingGuidelines.ruleset b/CodingGuidelines.ruleset
index 05545fb55c..e647ad9e58 100644
--- a/CodingGuidelines.ruleset
+++ b/CodingGuidelines.ruleset
@@ -14,6 +14,7 @@
+
@@ -21,7 +22,7 @@
-
+
diff --git a/Directory.Build.props b/Directory.Build.props
index 66d90258f9..a9f50c5966 100644
--- a/Directory.Build.props
+++ b/Directory.Build.props
@@ -4,7 +4,7 @@
6.0.*
6.0.*
6.0.*
- 4.0.*
+ 4.1.*
2.*
5.0.0
$(MSBuildThisFileDirectory)CodingGuidelines.ruleset
@@ -17,7 +17,7 @@
-
+
@@ -27,10 +27,14 @@
true
+
+ $(NoWarn);AV2210
+
+
3.1.2
- 4.16.1
+ 4.17.2
17.1.0
diff --git a/benchmarks/Serialization/SerializationBenchmarkBase.cs b/benchmarks/Serialization/SerializationBenchmarkBase.cs
index 100ff60e25..e1bcb10843 100644
--- a/benchmarks/Serialization/SerializationBenchmarkBase.cs
+++ b/benchmarks/Serialization/SerializationBenchmarkBase.cs
@@ -245,7 +245,7 @@ public RelationshipLinks GetRelationshipLinks(RelationshipAttribute relationship
private sealed class FakeMetaBuilder : IMetaBuilder
{
- public void Add(IReadOnlyDictionary values)
+ public void Add(IDictionary values)
{
}
diff --git a/src/JsonApiDotNetCore.Annotations/ArgumentGuard.cs b/src/JsonApiDotNetCore.Annotations/ArgumentGuard.cs
index 23b64d1044..be336e56a0 100644
--- a/src/JsonApiDotNetCore.Annotations/ArgumentGuard.cs
+++ b/src/JsonApiDotNetCore.Annotations/ArgumentGuard.cs
@@ -18,13 +18,24 @@ public static void NotNull([NoEnumeration] [SysNotNull] T? value, [InvokerPar
}
[AssertionMethod]
- public static void NotNullNorEmpty([SysNotNull] IEnumerable? value, [InvokerParameterName] string name, string? collectionName = null)
+ public static void NotNullNorEmpty([SysNotNull] IEnumerable? value, [InvokerParameterName] string name)
{
NotNull(value, name);
if (!value.Any())
{
- throw new ArgumentException($"Must have one or more {collectionName ?? name}.", name);
+ throw new ArgumentException($"Must have one or more {name}.", name);
+ }
+ }
+
+ [AssertionMethod]
+ public static void NotNullNorEmpty([SysNotNull] IEnumerable? value, [InvokerParameterName] string name, string collectionName)
+ {
+ NotNull(value, name);
+
+ if (!value.Any())
+ {
+ throw new ArgumentException($"Must have one or more {collectionName}.", name);
}
}
diff --git a/src/JsonApiDotNetCore.Annotations/CollectionConverter.cs b/src/JsonApiDotNetCore.Annotations/CollectionConverter.cs
index 88037e66e3..a308607c3b 100644
--- a/src/JsonApiDotNetCore.Annotations/CollectionConverter.cs
+++ b/src/JsonApiDotNetCore.Annotations/CollectionConverter.cs
@@ -66,9 +66,19 @@ private Type ToConcreteCollectionType(Type collectionType)
///
/// Returns a collection that contains zero, one or multiple resources, depending on the specified value.
///
- public ICollection ExtractResources(object? value)
+ public IReadOnlyCollection ExtractResources(object? value)
{
- if (value is ICollection resourceCollection)
+ if (value is List resourceList)
+ {
+ return resourceList;
+ }
+
+ if (value is HashSet resourceSet)
+ {
+ return resourceSet;
+ }
+
+ if (value is IReadOnlyCollection resourceCollection)
{
return resourceCollection;
}
diff --git a/src/JsonApiDotNetCore.Annotations/Configuration/ResourceType.cs b/src/JsonApiDotNetCore.Annotations/Configuration/ResourceType.cs
index c9b2f8064d..515dfe8a63 100644
--- a/src/JsonApiDotNetCore.Annotations/Configuration/ResourceType.cs
+++ b/src/JsonApiDotNetCore.Annotations/Configuration/ResourceType.cs
@@ -89,8 +89,14 @@ public sealed class ResourceType
///
public LinkTypes RelationshipLinks { get; }
- public ResourceType(string publicName, Type clrType, Type identityClrType, IReadOnlyCollection? attributes = null,
- IReadOnlyCollection? relationships = null, IReadOnlyCollection? eagerLoads = null,
+ public ResourceType(string publicName, Type clrType, Type identityClrType, LinkTypes topLevelLinks = LinkTypes.NotConfigured,
+ LinkTypes resourceLinks = LinkTypes.NotConfigured, LinkTypes relationshipLinks = LinkTypes.NotConfigured)
+ : this(publicName, clrType, identityClrType, null, null, null, topLevelLinks, resourceLinks, relationshipLinks)
+ {
+ }
+
+ public ResourceType(string publicName, Type clrType, Type identityClrType, IReadOnlyCollection? attributes,
+ IReadOnlyCollection? relationships, IReadOnlyCollection? eagerLoads,
LinkTypes topLevelLinks = LinkTypes.NotConfigured, LinkTypes resourceLinks = LinkTypes.NotConfigured,
LinkTypes relationshipLinks = LinkTypes.NotConfigured)
{
diff --git a/src/JsonApiDotNetCore.Annotations/ObjectExtensions.cs b/src/JsonApiDotNetCore.Annotations/ObjectExtensions.cs
index bd42993803..b7fd934fbe 100644
--- a/src/JsonApiDotNetCore.Annotations/ObjectExtensions.cs
+++ b/src/JsonApiDotNetCore.Annotations/ObjectExtensions.cs
@@ -1,4 +1,4 @@
-#pragma warning disable AV1130 // Return type in method signature should be a collection interface instead of a concrete type
+#pragma warning disable AV1130 // Return type in method signature should be an interface to an unchangeable collection
namespace JsonApiDotNetCore;
diff --git a/src/JsonApiDotNetCore/ArrayFactory.cs b/src/JsonApiDotNetCore/ArrayFactory.cs
index 2969f34d17..6ad678c64d 100644
--- a/src/JsonApiDotNetCore/ArrayFactory.cs
+++ b/src/JsonApiDotNetCore/ArrayFactory.cs
@@ -1,5 +1,5 @@
#pragma warning disable AV1008 // Class should not be static
-#pragma warning disable AV1130 // Return type in method signature should be a collection interface instead of a concrete type
+#pragma warning disable AV1130 // Return type in method signature should be an interface to an unchangeable collection
namespace JsonApiDotNetCore;
diff --git a/src/JsonApiDotNetCore/AtomicOperations/Processors/SetRelationshipProcessor.cs b/src/JsonApiDotNetCore/AtomicOperations/Processors/SetRelationshipProcessor.cs
index 1f15ea293f..5eb09ccbc3 100644
--- a/src/JsonApiDotNetCore/AtomicOperations/Processors/SetRelationshipProcessor.cs
+++ b/src/JsonApiDotNetCore/AtomicOperations/Processors/SetRelationshipProcessor.cs
@@ -40,7 +40,7 @@ public SetRelationshipProcessor(ISetRelationshipService service)
if (relationship is HasManyAttribute)
{
- ICollection rightResources = _collectionConverter.ExtractResources(rightValue);
+ IReadOnlyCollection rightResources = _collectionConverter.ExtractResources(rightValue);
return rightResources.ToHashSet(IdentifiableComparer.Instance);
}
diff --git a/src/JsonApiDotNetCore/Configuration/ResourceGraphBuilder.cs b/src/JsonApiDotNetCore/Configuration/ResourceGraphBuilder.cs
index 428b14d32e..e07318c7f7 100644
--- a/src/JsonApiDotNetCore/Configuration/ResourceGraphBuilder.cs
+++ b/src/JsonApiDotNetCore/Configuration/ResourceGraphBuilder.cs
@@ -175,8 +175,10 @@ private static bool IsImplicitManyToManyJoinEntity(IEntityType entityType)
/// The name under which the resource is publicly exposed by the API. If nothing is specified, the naming convention is applied on the pluralized CLR
/// type name.
///
+#pragma warning disable AV1553 // Do not use optional parameters with default value null for strings, collections or tasks
public ResourceGraphBuilder Add(string? publicName = null)
where TResource : class, IIdentifiable
+#pragma warning restore AV1553 // Do not use optional parameters with default value null for strings, collections or tasks
{
return Add(typeof(TResource), typeof(TId), publicName);
}
@@ -194,7 +196,9 @@ public ResourceGraphBuilder Add(string? publicName = null)
/// The name under which the resource is publicly exposed by the API. If nothing is specified, the naming convention is applied on the pluralized CLR
/// type name.
///
+#pragma warning disable AV1553 // Do not use optional parameters with default value null for strings, collections or tasks
public ResourceGraphBuilder Add(Type resourceClrType, Type? idClrType = null, string? publicName = null)
+#pragma warning restore AV1553 // Do not use optional parameters with default value null for strings, collections or tasks
{
ArgumentGuard.NotNull(resourceClrType, nameof(resourceClrType));
diff --git a/src/JsonApiDotNetCore/Configuration/ServiceCollectionExtensions.cs b/src/JsonApiDotNetCore/Configuration/ServiceCollectionExtensions.cs
index 64a99021d4..8e5d15a7c4 100644
--- a/src/JsonApiDotNetCore/Configuration/ServiceCollectionExtensions.cs
+++ b/src/JsonApiDotNetCore/Configuration/ServiceCollectionExtensions.cs
@@ -6,6 +6,8 @@
using Microsoft.EntityFrameworkCore;
using Microsoft.Extensions.DependencyInjection;
+#pragma warning disable AV1130 // Return type in method signature should be an interface to an unchangeable collection
+
namespace JsonApiDotNetCore.Configuration;
[PublicAPI]
@@ -16,9 +18,11 @@ public static class ServiceCollectionExtensions
///
/// Configures JsonApiDotNetCore by registering resources manually.
///
+#pragma warning disable AV1553 // Do not use optional parameters with default value null for strings, collections or tasks
public static IServiceCollection AddJsonApi(this IServiceCollection services, Action? options = null,
Action? discovery = null, Action? resources = null, IMvcCoreBuilder? mvcBuilder = null,
ICollection? dbContextTypes = null)
+#pragma warning restore AV1553 // Do not use optional parameters with default value null for strings, collections or tasks
{
ArgumentGuard.NotNull(services, nameof(services));
diff --git a/src/JsonApiDotNetCore/Diagnostics/CascadingCodeTimer.cs b/src/JsonApiDotNetCore/Diagnostics/CascadingCodeTimer.cs
index fde552ec8f..44cc2955d9 100644
--- a/src/JsonApiDotNetCore/Diagnostics/CascadingCodeTimer.cs
+++ b/src/JsonApiDotNetCore/Diagnostics/CascadingCodeTimer.cs
@@ -32,7 +32,13 @@ static CascadingCodeTimer()
}
///
- public IDisposable Measure(string name, bool excludeInRelativeCost = false)
+ public IDisposable Measure(string name)
+ {
+ return Measure(name, false);
+ }
+
+ ///
+ public IDisposable Measure(string name, bool excludeInRelativeCost)
{
MeasureScope childScope = CreateChildScope(name, excludeInRelativeCost);
_activeScopeStack.Push(childScope);
diff --git a/src/JsonApiDotNetCore/Diagnostics/DisabledCodeTimer.cs b/src/JsonApiDotNetCore/Diagnostics/DisabledCodeTimer.cs
index 928017b7e0..a50c25eaba 100644
--- a/src/JsonApiDotNetCore/Diagnostics/DisabledCodeTimer.cs
+++ b/src/JsonApiDotNetCore/Diagnostics/DisabledCodeTimer.cs
@@ -11,7 +11,12 @@ private DisabledCodeTimer()
{
}
- public IDisposable Measure(string name, bool excludeInRelativeCost = false)
+ public IDisposable Measure(string name)
+ {
+ return this;
+ }
+
+ public IDisposable Measure(string name, bool excludeInRelativeCost)
{
return this;
}
diff --git a/src/JsonApiDotNetCore/Diagnostics/ICodeTimer.cs b/src/JsonApiDotNetCore/Diagnostics/ICodeTimer.cs
index 23ff4ac605..ff219b5a37 100644
--- a/src/JsonApiDotNetCore/Diagnostics/ICodeTimer.cs
+++ b/src/JsonApiDotNetCore/Diagnostics/ICodeTimer.cs
@@ -5,6 +5,15 @@ namespace JsonApiDotNetCore.Diagnostics;
///
public interface ICodeTimer : IDisposable
{
+ ///
+ /// Starts recording the duration of a code block, while including this measurement in calculated percentages. Wrap this call in a using
+ /// statement, so the recording stops when the return value goes out of scope.
+ ///
+ ///
+ /// Description of what is being recorded.
+ ///
+ IDisposable Measure(string name);
+
///
/// Starts recording the duration of a code block. Wrap this call in a using statement, so the recording stops when the return value goes out of
/// scope.
@@ -13,9 +22,9 @@ public interface ICodeTimer : IDisposable
/// Description of what is being recorded.
///
///
- /// When set, indicates to exclude this measurement in calculated percentages. false by default.
+ /// When set, indicates to exclude this measurement in calculated percentages.
///
- IDisposable Measure(string name, bool excludeInRelativeCost = false);
+ IDisposable Measure(string name, bool excludeInRelativeCost);
///
/// Returns intermediate or final results.
diff --git a/src/JsonApiDotNetCore/Queries/Expressions/QueryableHandlerExpression.cs b/src/JsonApiDotNetCore/Queries/Expressions/QueryableHandlerExpression.cs
index 1d9c910955..4cd035ba2d 100644
--- a/src/JsonApiDotNetCore/Queries/Expressions/QueryableHandlerExpression.cs
+++ b/src/JsonApiDotNetCore/Queries/Expressions/QueryableHandlerExpression.cs
@@ -21,8 +21,10 @@ public QueryableHandlerExpression(object queryableHandler, StringValues paramete
_parameterValue = parameterValue;
}
+#pragma warning disable AV1130 // Return type in method signature should be an interface to an unchangeable collection
public IQueryable Apply(IQueryable query)
where TResource : class, IIdentifiable
+#pragma warning restore AV1130 // Return type in method signature should be an interface to an unchangeable collection
{
var handler = (Func, StringValues, IQueryable>)_queryableHandler;
return handler(query, _parameterValue);
diff --git a/src/JsonApiDotNetCore/Queries/FieldSelection.cs b/src/JsonApiDotNetCore/Queries/FieldSelection.cs
index 8570addf51..54c59005bf 100644
--- a/src/JsonApiDotNetCore/Queries/FieldSelection.cs
+++ b/src/JsonApiDotNetCore/Queries/FieldSelection.cs
@@ -14,14 +14,14 @@ public sealed class FieldSelection : Dictionary
{
public bool IsEmpty => Values.All(selectors => selectors.IsEmpty);
- public ISet GetResourceTypes()
+ public IReadOnlySet GetResourceTypes()
{
return Keys.ToHashSet();
}
-#pragma warning disable AV1130 // Return type in method signature should be a collection interface instead of a concrete type
+#pragma warning disable AV1130 // Return type in method signature should be an interface to an unchangeable collection
public FieldSelectors GetOrCreateSelectors(ResourceType resourceType)
-#pragma warning restore AV1130 // Return type in method signature should be a collection interface instead of a concrete type
+#pragma warning restore AV1130 // Return type in method signature should be an interface to an unchangeable collection
{
ArgumentGuard.NotNull(resourceType, nameof(resourceType));
diff --git a/src/JsonApiDotNetCore/Queries/Internal/Parsing/Token.cs b/src/JsonApiDotNetCore/Queries/Internal/Parsing/Token.cs
index 14b6289b83..bff295acae 100644
--- a/src/JsonApiDotNetCore/Queries/Internal/Parsing/Token.cs
+++ b/src/JsonApiDotNetCore/Queries/Internal/Parsing/Token.cs
@@ -8,9 +8,14 @@ public sealed class Token
public TokenKind Kind { get; }
public string? Value { get; }
- public Token(TokenKind kind, string? value = null)
+ public Token(TokenKind kind)
{
Kind = kind;
+ }
+
+ public Token(TokenKind kind, string value)
+ : this(kind)
+ {
Value = value;
}
diff --git a/src/JsonApiDotNetCore/Queries/Internal/QueryLayerComposer.cs b/src/JsonApiDotNetCore/Queries/Internal/QueryLayerComposer.cs
index 00181a23a7..40af882044 100644
--- a/src/JsonApiDotNetCore/Queries/Internal/QueryLayerComposer.cs
+++ b/src/JsonApiDotNetCore/Queries/Internal/QueryLayerComposer.cs
@@ -305,9 +305,7 @@ public QueryLayer ComposeSecondaryLayerForRelationship(ResourceType secondaryRes
return secondaryLayer;
}
-#pragma warning disable AV1130 // Return type in method signature should be a collection interface instead of a concrete type
private FieldSelection GetSelectionForRelationship(ResourceType secondaryResourceType)
-#pragma warning restore AV1130 // Return type in method signature should be a collection interface instead of a concrete type
{
var selection = new FieldSelection();
FieldSelectors selectors = selection.GetOrCreateSelectors(secondaryResourceType);
@@ -404,7 +402,7 @@ public QueryLayer ComposeForUpdate(TId id, ResourceType primaryResourceType
foreach (RelationshipAttribute relationship in _targetedFields.Relationships)
{
object? rightValue = relationship.GetValue(primaryResource);
- ICollection rightResourceIds = _collectionConverter.ExtractResources(rightValue);
+ HashSet rightResourceIds = _collectionConverter.ExtractResources(rightValue).ToHashSet(IdentifiableComparer.Instance);
if (rightResourceIds.Any())
{
@@ -527,9 +525,9 @@ protected virtual PaginationExpression GetPagination(IReadOnlyCollection concreteEntityTypes, LambdaScope lambdaScope)
{
- ISet resourceTypes = selection.GetResourceTypes();
+ IReadOnlySet resourceTypes = selection.GetResourceTypes();
Expression rootCondition = lambdaScope.Accessor;
foreach (IEntityType entityType in concreteEntityTypes)
diff --git a/src/JsonApiDotNetCore/Repositories/EntityFrameworkCoreRepository.cs b/src/JsonApiDotNetCore/Repositories/EntityFrameworkCoreRepository.cs
index 50c9e07ea3..7384cec693 100644
--- a/src/JsonApiDotNetCore/Repositories/EntityFrameworkCoreRepository.cs
+++ b/src/JsonApiDotNetCore/Repositories/EntityFrameworkCoreRepository.cs
@@ -105,7 +105,9 @@ public virtual async Task CountAsync(FilterExpression? filter, Cancellation
}
}
+#pragma warning disable AV1130 // Return type in method signature should be an interface to an unchangeable collection
protected virtual IQueryable ApplyQueryLayer(QueryLayer queryLayer)
+#pragma warning restore AV1130 // Return type in method signature should be an interface to an unchangeable collection
{
_traceWriter.LogMethodStart(new
{
@@ -149,7 +151,9 @@ protected virtual IQueryable ApplyQueryLayer(QueryLayer queryLayer)
}
}
+#pragma warning disable AV1130 // Return type in method signature should be an interface to an unchangeable collection
protected virtual IQueryable GetAll()
+#pragma warning restore AV1130 // Return type in method signature should be an interface to an unchangeable collection
{
return _dbContext.Set();
}
@@ -221,12 +225,12 @@ public virtual async Task CreateAsync(TResource resourceFromRequest, TResource r
if (relationship is HasManyAttribute hasManyRelationship)
{
- HashSet rightResourceIdSet = _collectionConverter.ExtractResources(rightValue).ToHashSet(IdentifiableComparer.Instance);
+ HashSet rightResourceIds = _collectionConverter.ExtractResources(rightValue).ToHashSet(IdentifiableComparer.Instance);
- await _resourceDefinitionAccessor.OnSetToManyRelationshipAsync(leftResource, hasManyRelationship, rightResourceIdSet, writeOperation,
+ await _resourceDefinitionAccessor.OnSetToManyRelationshipAsync(leftResource, hasManyRelationship, rightResourceIds, writeOperation,
cancellationToken);
- return rightResourceIdSet;
+ return rightResourceIds;
}
return rightValue;
@@ -572,7 +576,7 @@ protected async Task UpdateRelationshipAsync(RelationshipAttribute relationship,
return null;
}
- ICollection rightResources = _collectionConverter.ExtractResources(rightValue);
+ IReadOnlyCollection rightResources = _collectionConverter.ExtractResources(rightValue);
IIdentifiable[] rightResourcesTracked = rightResources.Select(rightResource => _dbContext.GetTrackedOrAttach(rightResource)).ToArray();
return rightValue is IEnumerable
diff --git a/src/JsonApiDotNetCore/Resources/IResourceDefinition.cs b/src/JsonApiDotNetCore/Resources/IResourceDefinition.cs
index 2315ee7b1a..9af79831b2 100644
--- a/src/JsonApiDotNetCore/Resources/IResourceDefinition.cs
+++ b/src/JsonApiDotNetCore/Resources/IResourceDefinition.cs
@@ -108,14 +108,16 @@ public interface IResourceDefinition
/// }
/// ]]>
///
-#pragma warning disable AV1130 // Return type in method signature should be a collection interface instead of a concrete type
+#pragma warning disable AV1130 // Return type in method signature should be an interface to an unchangeable collection
QueryStringParameterHandlers? OnRegisterQueryableHandlersForQueryStringParameters();
-#pragma warning restore AV1130 // Return type in method signature should be a collection interface instead of a concrete type
+#pragma warning restore AV1130 // Return type in method signature should be an interface to an unchangeable collection
///
/// Enables to add JSON:API meta information, specific to this resource.
///
+#pragma warning disable AV1130 // Return type in method signature should be an interface to an unchangeable collection
IDictionary? GetMeta(TResource resource);
+#pragma warning restore AV1130 // Return type in method signature should be an interface to an unchangeable collection
///
/// Executes after the original version of the resource has been retrieved from the underlying data store, as part of a write request.
diff --git a/src/JsonApiDotNetCore/Resources/IResourceDefinitionAccessor.cs b/src/JsonApiDotNetCore/Resources/IResourceDefinitionAccessor.cs
index edba16d045..55f32ead40 100644
--- a/src/JsonApiDotNetCore/Resources/IResourceDefinitionAccessor.cs
+++ b/src/JsonApiDotNetCore/Resources/IResourceDefinitionAccessor.cs
@@ -45,7 +45,9 @@ public interface IResourceDefinitionAccessor
///
/// Invokes for the specified resource.
///
+#pragma warning disable AV1130 // Return type in method signature should be an interface to an unchangeable collection
IDictionary? GetMeta(ResourceType resourceType, IIdentifiable resourceInstance);
+#pragma warning restore AV1130 // Return type in method signature should be an interface to an unchangeable collection
///
/// Invokes for the specified resource.
diff --git a/src/JsonApiDotNetCore/Resources/OperationContainer.cs b/src/JsonApiDotNetCore/Resources/OperationContainer.cs
index 91f2553fd2..d2fa2c0d3e 100644
--- a/src/JsonApiDotNetCore/Resources/OperationContainer.cs
+++ b/src/JsonApiDotNetCore/Resources/OperationContainer.cs
@@ -39,7 +39,9 @@ public OperationContainer WithResource(IIdentifiable resource)
return new OperationContainer(resource, TargetedFields, Request);
}
+#pragma warning disable AV1130 // Return type in method signature should be an interface to an unchangeable collection
public ISet GetSecondaryResources()
+#pragma warning restore AV1130 // Return type in method signature should be an interface to an unchangeable collection
{
var secondaryResources = new HashSet(IdentifiableComparer.Instance);
@@ -54,7 +56,7 @@ public ISet GetSecondaryResources()
private void AddSecondaryResources(RelationshipAttribute relationship, HashSet secondaryResources)
{
object? rightValue = relationship.GetValue(Resource);
- ICollection rightResources = CollectionConverter.ExtractResources(rightValue);
+ IReadOnlyCollection rightResources = CollectionConverter.ExtractResources(rightValue);
secondaryResources.AddRange(rightResources);
}
diff --git a/src/JsonApiDotNetCore/Serialization/Request/Adapters/DocumentInOperationsRequestAdapter.cs b/src/JsonApiDotNetCore/Serialization/Request/Adapters/DocumentInOperationsRequestAdapter.cs
index 6d26125666..8a50db9fec 100644
--- a/src/JsonApiDotNetCore/Serialization/Request/Adapters/DocumentInOperationsRequestAdapter.cs
+++ b/src/JsonApiDotNetCore/Serialization/Request/Adapters/DocumentInOperationsRequestAdapter.cs
@@ -21,7 +21,7 @@ public DocumentInOperationsRequestAdapter(IJsonApiOptions options, IAtomicOperat
}
///
- public IList Convert(Document document, RequestAdapterState state)
+ public IReadOnlyList Convert(Document document, RequestAdapterState state)
{
ArgumentGuard.NotNull(state, nameof(state));
AssertHasOperations(document.Operations, state);
@@ -50,7 +50,7 @@ private void AssertMaxOperationsNotExceeded(ICollection
}
}
- private IList ConvertOperations(IEnumerable atomicOperationObjects, RequestAdapterState state)
+ private IReadOnlyList ConvertOperations(IEnumerable atomicOperationObjects, RequestAdapterState state)
{
var operations = new List();
int operationIndex = 0;
diff --git a/src/JsonApiDotNetCore/Serialization/Request/Adapters/IDocumentInOperationsRequestAdapter.cs b/src/JsonApiDotNetCore/Serialization/Request/Adapters/IDocumentInOperationsRequestAdapter.cs
index 228abbf3ce..b4e929cba3 100644
--- a/src/JsonApiDotNetCore/Serialization/Request/Adapters/IDocumentInOperationsRequestAdapter.cs
+++ b/src/JsonApiDotNetCore/Serialization/Request/Adapters/IDocumentInOperationsRequestAdapter.cs
@@ -11,5 +11,5 @@ public interface IDocumentInOperationsRequestAdapter
///
/// Validates and converts the specified .
///
- IList Convert(Document document, RequestAdapterState state);
+ IReadOnlyList Convert(Document document, RequestAdapterState state);
}
diff --git a/src/JsonApiDotNetCore/Serialization/Response/EmptyResponseMeta.cs b/src/JsonApiDotNetCore/Serialization/Response/EmptyResponseMeta.cs
index 77b2058796..dfdb20bde1 100644
--- a/src/JsonApiDotNetCore/Serialization/Response/EmptyResponseMeta.cs
+++ b/src/JsonApiDotNetCore/Serialization/Response/EmptyResponseMeta.cs
@@ -4,7 +4,7 @@ namespace JsonApiDotNetCore.Serialization.Response;
public sealed class EmptyResponseMeta : IResponseMeta
{
///
- public IReadOnlyDictionary? GetMeta()
+ public IDictionary? GetMeta()
{
return null;
}
diff --git a/src/JsonApiDotNetCore/Serialization/Response/IMetaBuilder.cs b/src/JsonApiDotNetCore/Serialization/Response/IMetaBuilder.cs
index e804179505..1c3916c404 100644
--- a/src/JsonApiDotNetCore/Serialization/Response/IMetaBuilder.cs
+++ b/src/JsonApiDotNetCore/Serialization/Response/IMetaBuilder.cs
@@ -12,10 +12,12 @@ public interface IMetaBuilder
/// Merges the specified dictionary with existing key/value pairs. In the event of a key collision, the value from the specified dictionary will
/// overwrite the existing one.
///
- void Add(IReadOnlyDictionary values);
+ void Add(IDictionary values);
///
/// Builds the top-level meta data object.
///
+#pragma warning disable AV1130 // Return type in method signature should be an interface to an unchangeable collection
IDictionary? Build();
+#pragma warning restore AV1130 // Return type in method signature should be an interface to an unchangeable collection
}
diff --git a/src/JsonApiDotNetCore/Serialization/Response/IResponseMeta.cs b/src/JsonApiDotNetCore/Serialization/Response/IResponseMeta.cs
index f3035cfa4c..2e17ec9bdb 100644
--- a/src/JsonApiDotNetCore/Serialization/Response/IResponseMeta.cs
+++ b/src/JsonApiDotNetCore/Serialization/Response/IResponseMeta.cs
@@ -12,5 +12,7 @@ public interface IResponseMeta
///
/// Gets the global top-level JSON:API meta information to add to the response.
///
- IReadOnlyDictionary? GetMeta();
+#pragma warning disable AV1130 // Return type in method signature should be an interface to an unchangeable collection
+ IDictionary? GetMeta();
+#pragma warning restore AV1130 // Return type in method signature should be an interface to an unchangeable collection
}
diff --git a/src/JsonApiDotNetCore/Serialization/Response/MetaBuilder.cs b/src/JsonApiDotNetCore/Serialization/Response/MetaBuilder.cs
index d250501d60..91ec62387c 100644
--- a/src/JsonApiDotNetCore/Serialization/Response/MetaBuilder.cs
+++ b/src/JsonApiDotNetCore/Serialization/Response/MetaBuilder.cs
@@ -26,7 +26,7 @@ public MetaBuilder(IPaginationContext paginationContext, IJsonApiOptions options
}
///
- public void Add(IReadOnlyDictionary values)
+ public void Add(IDictionary values)
{
ArgumentGuard.NotNull(values, nameof(values));
@@ -43,7 +43,7 @@ public void Add(IReadOnlyDictionary values)
_meta.Add(key, _paginationContext.TotalResourceCount);
}
- IReadOnlyDictionary? extraMeta = _responseMeta.GetMeta();
+ IDictionary? extraMeta = _responseMeta.GetMeta();
if (extraMeta != null)
{
diff --git a/src/JsonApiDotNetCore/Serialization/Response/ResourceObjectTreeNode.cs b/src/JsonApiDotNetCore/Serialization/Response/ResourceObjectTreeNode.cs
index f18eeb8913..aed19d9097 100644
--- a/src/JsonApiDotNetCore/Serialization/Response/ResourceObjectTreeNode.cs
+++ b/src/JsonApiDotNetCore/Serialization/Response/ResourceObjectTreeNode.cs
@@ -88,7 +88,7 @@ public void AttachRelationshipChild(RelationshipAttribute relationship, Resource
///
/// Recursively walks the tree and returns the set of unique nodes. Uses relationship declaration order.
///
- public ISet GetUniqueNodes()
+ public IReadOnlySet GetUniqueNodes()
{
AssertIsTreeRoot();
@@ -148,7 +148,7 @@ private static void VisitRelationshipChildInSubtree(HashSet? GetRightNodesInRelationship(RelationshipAttribute relationship)
+ public IReadOnlySet? GetRightNodesInRelationship(RelationshipAttribute relationship)
{
return _childrenByRelationship != null && _childrenByRelationship.TryGetValue(relationship, out HashSet? rightNodes)
? rightNodes
@@ -158,7 +158,7 @@ private static void VisitRelationshipChildInSubtree(HashSet
/// Provides the value for 'data' in the response body. Uses relationship declaration order.
///
- public IList GetResponseData()
+ public IReadOnlyList GetResponseData()
{
AssertIsTreeRoot();
@@ -168,7 +168,9 @@ public IList GetResponseData()
///
/// Provides the value for 'included' in the response body. Uses relationship declaration order.
///
+#pragma warning disable AV1130 // Return type in method signature should be an interface to an unchangeable collection
public IList GetResponseIncluded()
+#pragma warning restore AV1130 // Return type in method signature should be an interface to an unchangeable collection
{
AssertIsTreeRoot();
diff --git a/src/JsonApiDotNetCore/Serialization/Response/ResponseModelAdapter.cs b/src/JsonApiDotNetCore/Serialization/Response/ResponseModelAdapter.cs
index af1a78bee1..223166e59e 100644
--- a/src/JsonApiDotNetCore/Serialization/Response/ResponseModelAdapter.cs
+++ b/src/JsonApiDotNetCore/Serialization/Response/ResponseModelAdapter.cs
@@ -80,7 +80,7 @@ public Document Convert(object? model)
PopulateRelationshipsInTree(rootNode, _request.Kind);
- IEnumerable resourceObjects = rootNode.GetResponseData();
+ IReadOnlyList resourceObjects = rootNode.GetResponseData();
document.Data = new SingleOrManyData(resourceObjects);
}
else if (model is IIdentifiable resource)
@@ -231,7 +231,9 @@ protected virtual ResourceObject ConvertResource(IIdentifiable resource, Resourc
return resourceObject;
}
+#pragma warning disable AV1130 // Return type in method signature should be an interface to an unchangeable collection
protected virtual IDictionary? ConvertAttributes(IIdentifiable resource, ResourceType resourceType,
+#pragma warning restore AV1130 // Return type in method signature should be an interface to an unchangeable collection
IImmutableSet fieldSet)
{
var attrMap = new Dictionary(resourceType.Attributes.Count);
@@ -286,7 +288,7 @@ private void TraverseRelationship(RelationshipAttribute relationship, IIdentifia
: relationship;
object? rightValue = effectiveRelationship.GetValue(leftResource);
- ICollection rightResources = CollectionConverter.ExtractResources(rightValue);
+ IReadOnlyCollection rightResources = CollectionConverter.ExtractResources(rightValue);
leftTreeNode.EnsureHasRelationship(effectiveRelationship);
@@ -340,7 +342,7 @@ private void PopulateRelationshipInResourceObject(ResourceObjectTreeNode treeNod
private static SingleOrManyData GetRelationshipData(ResourceObjectTreeNode treeNode, RelationshipAttribute relationship)
{
- ISet? rightNodes = treeNode.GetRightNodesInRelationship(relationship);
+ IReadOnlySet? rightNodes = treeNode.GetRightNodesInRelationship(relationship);
if (rightNodes != null)
{
diff --git a/src/JsonApiDotNetCore/Services/JsonApiResourceService.cs b/src/JsonApiDotNetCore/Services/JsonApiResourceService.cs
index 540ee5b73b..0cca8b92b9 100644
--- a/src/JsonApiDotNetCore/Services/JsonApiResourceService.cs
+++ b/src/JsonApiDotNetCore/Services/JsonApiResourceService.cs
@@ -391,7 +391,7 @@ private async Task RemoveExistingIdsFromRelationshipRightSideAsync(Ha
TResource leftResource = await GetForHasManyUpdateAsync(hasManyRelationship, leftId, rightResourceIds, cancellationToken);
object? rightValue = hasManyRelationship.GetValue(leftResource);
- ICollection existingRightResourceIds = _collectionConverter.ExtractResources(rightValue);
+ IReadOnlyCollection existingRightResourceIds = _collectionConverter.ExtractResources(rightValue);
rightResourceIds.ExceptWith(existingRightResourceIds);
diff --git a/test/JsonApiDotNetCoreTests/IntegrationTests/Archiving/ArchiveTests.cs b/test/JsonApiDotNetCoreTests/IntegrationTests/Archiving/ArchiveTests.cs
index 5053d17e09..2af39b3d26 100644
--- a/test/JsonApiDotNetCoreTests/IntegrationTests/Archiving/ArchiveTests.cs
+++ b/test/JsonApiDotNetCoreTests/IntegrationTests/Archiving/ArchiveTests.cs
@@ -45,7 +45,7 @@ await _testContext.RunOnDatabaseAsync(async dbContext =>
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecuteGetAsync(route);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.OK);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.OK);
responseDocument.Data.SingleValue.ShouldNotBeNull();
responseDocument.Data.SingleValue.Id.Should().Be(broadcast.StringId);
@@ -71,7 +71,7 @@ await _testContext.RunOnDatabaseAsync(async dbContext =>
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecuteGetAsync(route);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.OK);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.OK);
responseDocument.Data.SingleValue.ShouldNotBeNull();
responseDocument.Data.SingleValue.Id.Should().Be(broadcast.StringId);
@@ -98,7 +98,7 @@ await _testContext.RunOnDatabaseAsync(async dbContext =>
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecuteGetAsync(route);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.OK);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.OK);
responseDocument.Data.ManyValue.ShouldHaveCount(1);
responseDocument.Data.ManyValue[0].Id.Should().Be(broadcasts[1].StringId);
@@ -125,7 +125,7 @@ await _testContext.RunOnDatabaseAsync(async dbContext =>
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecuteGetAsync(route);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.OK);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.OK);
responseDocument.Data.ManyValue.ShouldHaveCount(2);
responseDocument.Data.ManyValue[0].Id.Should().Be(broadcasts[0].StringId);
@@ -155,7 +155,7 @@ await _testContext.RunOnDatabaseAsync(async dbContext =>
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecuteGetAsync(route);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.OK);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.OK);
responseDocument.Data.SingleValue.ShouldNotBeNull();
responseDocument.Data.SingleValue.Id.Should().Be(station.StringId);
@@ -185,7 +185,7 @@ await _testContext.RunOnDatabaseAsync(async dbContext =>
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecuteGetAsync(route);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.OK);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.OK);
responseDocument.Data.SingleValue.ShouldNotBeNull();
responseDocument.Data.SingleValue.Id.Should().Be(station.StringId);
@@ -216,7 +216,7 @@ await _testContext.RunOnDatabaseAsync(async dbContext =>
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecuteGetAsync(route);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.OK);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.OK);
responseDocument.Data.SingleValue.ShouldNotBeNull();
responseDocument.Data.SingleValue.Id.Should().Be(comment.AppliesTo.StringId);
@@ -243,7 +243,7 @@ await _testContext.RunOnDatabaseAsync(async dbContext =>
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecuteGetAsync(route);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.OK);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.OK);
responseDocument.Data.ManyValue.ShouldHaveCount(1);
responseDocument.Data.ManyValue[0].Id.Should().Be(station.Broadcasts.ElementAt(1).StringId);
@@ -270,7 +270,7 @@ await _testContext.RunOnDatabaseAsync(async dbContext =>
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecuteGetAsync(route);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.OK);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.OK);
DateTimeOffset archivedAt0 = station.Broadcasts.ElementAt(0).ArchivedAt!.Value;
@@ -303,7 +303,7 @@ await _testContext.RunOnDatabaseAsync(async dbContext =>
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecuteGetAsync(route);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.OK);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.OK);
responseDocument.Data.ManyValue.ShouldHaveCount(1);
responseDocument.Data.ManyValue[0].Id.Should().Be(network.Stations.ElementAt(0).StringId);
@@ -334,7 +334,7 @@ await _testContext.RunOnDatabaseAsync(async dbContext =>
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecuteGetAsync(route);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.OK);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.OK);
DateTimeOffset archivedAt0 = network.Stations.ElementAt(0).Broadcasts.ElementAt(0).ArchivedAt!.Value;
@@ -368,7 +368,7 @@ await _testContext.RunOnDatabaseAsync(async dbContext =>
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecuteGetAsync(route);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.OK);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.OK);
responseDocument.Data.ManyValue.ShouldHaveCount(1);
responseDocument.Data.ManyValue[0].Id.Should().Be(station.Broadcasts.ElementAt(1).StringId);
@@ -394,7 +394,7 @@ await _testContext.RunOnDatabaseAsync(async dbContext =>
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecuteGetAsync(route);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.OK);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.OK);
responseDocument.Data.ManyValue.ShouldHaveCount(2);
responseDocument.Data.ManyValue[0].Id.Should().Be(station.Broadcasts.ElementAt(0).StringId);
@@ -426,7 +426,7 @@ public async Task Can_create_unarchived_resource()
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.Created);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.Created);
responseDocument.Data.SingleValue.ShouldNotBeNull();
responseDocument.Data.SingleValue.Attributes.ShouldContainKey("title").With(value => value.Should().Be(newBroadcast.Title));
@@ -460,7 +460,7 @@ public async Task Cannot_create_archived_resource()
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.Forbidden);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.Forbidden);
responseDocument.Errors.ShouldHaveCount(1);
@@ -504,7 +504,7 @@ await _testContext.RunOnDatabaseAsync(async dbContext =>
(HttpResponseMessage httpResponse, string responseDocument) = await _testContext.ExecutePatchAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.NoContent);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.NoContent);
responseDocument.Should().BeEmpty();
@@ -547,7 +547,7 @@ await _testContext.RunOnDatabaseAsync(async dbContext =>
(HttpResponseMessage httpResponse, string responseDocument) = await _testContext.ExecutePatchAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.NoContent);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.NoContent);
responseDocument.Should().BeEmpty();
@@ -592,7 +592,7 @@ await _testContext.RunOnDatabaseAsync(async dbContext =>
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePatchAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.Forbidden);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.Forbidden);
responseDocument.Errors.ShouldHaveCount(1);
@@ -620,7 +620,7 @@ await _testContext.RunOnDatabaseAsync(async dbContext =>
(HttpResponseMessage httpResponse, string responseDocument) = await _testContext.ExecuteDeleteAsync(route);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.NoContent);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.NoContent);
responseDocument.Should().BeEmpty();
@@ -651,7 +651,7 @@ await _testContext.RunOnDatabaseAsync(async dbContext =>
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecuteDeleteAsync(route);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.Forbidden);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.Forbidden);
responseDocument.Errors.ShouldHaveCount(1);
diff --git a/test/JsonApiDotNetCoreTests/IntegrationTests/AtomicOperations/Controllers/AtomicConstrainedOperationsControllerTests.cs b/test/JsonApiDotNetCoreTests/IntegrationTests/AtomicOperations/Controllers/AtomicConstrainedOperationsControllerTests.cs
index 6908a2b296..e56e9119bf 100644
--- a/test/JsonApiDotNetCoreTests/IntegrationTests/AtomicOperations/Controllers/AtomicConstrainedOperationsControllerTests.cs
+++ b/test/JsonApiDotNetCoreTests/IntegrationTests/AtomicOperations/Controllers/AtomicConstrainedOperationsControllerTests.cs
@@ -63,7 +63,7 @@ public async Task Can_create_resources_for_matching_resource_type()
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.OK);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.OK);
responseDocument.Results.ShouldHaveCount(2);
}
@@ -96,7 +96,7 @@ public async Task Cannot_create_resource_for_mismatching_resource_type()
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.UnprocessableEntity);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.UnprocessableEntity);
responseDocument.Errors.ShouldHaveCount(1);
@@ -145,7 +145,7 @@ await _testContext.RunOnDatabaseAsync(async dbContext =>
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.UnprocessableEntity);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.UnprocessableEntity);
responseDocument.Errors.ShouldHaveCount(1);
@@ -201,7 +201,7 @@ await _testContext.RunOnDatabaseAsync(async dbContext =>
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.UnprocessableEntity);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.UnprocessableEntity);
responseDocument.Errors.ShouldHaveCount(1);
diff --git a/test/JsonApiDotNetCoreTests/IntegrationTests/AtomicOperations/Creating/AtomicCreateResourceTests.cs b/test/JsonApiDotNetCoreTests/IntegrationTests/AtomicOperations/Creating/AtomicCreateResourceTests.cs
index f37d53b275..ffae461fb0 100644
--- a/test/JsonApiDotNetCoreTests/IntegrationTests/AtomicOperations/Creating/AtomicCreateResourceTests.cs
+++ b/test/JsonApiDotNetCoreTests/IntegrationTests/AtomicOperations/Creating/AtomicCreateResourceTests.cs
@@ -63,7 +63,7 @@ public async Task Can_create_resource()
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.OK);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.OK);
responseDocument.Results.ShouldHaveCount(1);
@@ -126,7 +126,7 @@ public async Task Can_create_resources()
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.OK);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.OK);
responseDocument.Results.ShouldHaveCount(elementCount);
@@ -199,7 +199,7 @@ public async Task Can_create_resource_without_attributes_or_relationships()
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.OK);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.OK);
responseDocument.Results.ShouldHaveCount(1);
@@ -254,7 +254,7 @@ public async Task Cannot_create_resource_with_unknown_attribute()
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.UnprocessableEntity);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.UnprocessableEntity);
responseDocument.Errors.ShouldHaveCount(1);
@@ -302,7 +302,7 @@ public async Task Can_create_resource_with_unknown_attribute()
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.OK);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.OK);
responseDocument.Results.ShouldHaveCount(1);
@@ -359,7 +359,7 @@ public async Task Cannot_create_resource_with_unknown_relationship()
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.UnprocessableEntity);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.UnprocessableEntity);
responseDocument.Errors.ShouldHaveCount(1);
@@ -417,7 +417,7 @@ public async Task Can_create_resource_with_unknown_relationship()
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.OK);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.OK);
responseDocument.Results.ShouldHaveCount(1);
@@ -471,7 +471,7 @@ public async Task Cannot_create_resource_with_client_generated_ID()
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.Forbidden);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.Forbidden);
responseDocument.Errors.ShouldHaveCount(1);
@@ -506,7 +506,7 @@ public async Task Cannot_create_resource_for_href_element()
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.UnprocessableEntity);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.UnprocessableEntity);
responseDocument.Errors.ShouldHaveCount(1);
@@ -544,7 +544,7 @@ public async Task Cannot_create_resource_for_ref_element()
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.UnprocessableEntity);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.UnprocessableEntity);
responseDocument.Errors.ShouldHaveCount(1);
@@ -578,7 +578,7 @@ public async Task Cannot_create_resource_for_missing_data()
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.UnprocessableEntity);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.UnprocessableEntity);
responseDocument.Errors.ShouldHaveCount(1);
@@ -613,7 +613,7 @@ public async Task Cannot_create_resource_for_null_data()
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.UnprocessableEntity);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.UnprocessableEntity);
responseDocument.Errors.ShouldHaveCount(1);
@@ -660,7 +660,7 @@ public async Task Cannot_create_resource_for_array_data()
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.UnprocessableEntity);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.UnprocessableEntity);
responseDocument.Errors.ShouldHaveCount(1);
@@ -700,7 +700,7 @@ public async Task Cannot_create_resource_for_missing_type()
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.UnprocessableEntity);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.UnprocessableEntity);
responseDocument.Errors.ShouldHaveCount(1);
@@ -738,7 +738,7 @@ public async Task Cannot_create_resource_for_unknown_type()
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.UnprocessableEntity);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.UnprocessableEntity);
responseDocument.Errors.ShouldHaveCount(1);
@@ -780,7 +780,7 @@ public async Task Cannot_create_resource_attribute_with_blocked_capability()
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.UnprocessableEntity);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.UnprocessableEntity);
responseDocument.Errors.ShouldHaveCount(1);
@@ -825,7 +825,7 @@ public async Task Cannot_create_resource_with_readonly_attribute()
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.UnprocessableEntity);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.UnprocessableEntity);
responseDocument.Errors.ShouldHaveCount(1);
@@ -867,7 +867,7 @@ public async Task Cannot_create_resource_with_incompatible_attribute_value()
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.UnprocessableEntity);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.UnprocessableEntity);
responseDocument.Errors.ShouldHaveCount(1);
@@ -951,7 +951,7 @@ await _testContext.RunOnDatabaseAsync(async dbContext =>
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.OK);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.OK);
responseDocument.Results.ShouldHaveCount(1);
diff --git a/test/JsonApiDotNetCoreTests/IntegrationTests/AtomicOperations/Creating/AtomicCreateResourceWithClientGeneratedIdTests.cs b/test/JsonApiDotNetCoreTests/IntegrationTests/AtomicOperations/Creating/AtomicCreateResourceWithClientGeneratedIdTests.cs
index ef64ebc64a..62907c047a 100644
--- a/test/JsonApiDotNetCoreTests/IntegrationTests/AtomicOperations/Creating/AtomicCreateResourceWithClientGeneratedIdTests.cs
+++ b/test/JsonApiDotNetCoreTests/IntegrationTests/AtomicOperations/Creating/AtomicCreateResourceWithClientGeneratedIdTests.cs
@@ -67,7 +67,7 @@ public async Task Can_create_resource_with_client_generated_guid_ID_having_side_
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.OK);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.OK);
string isoCode = $"{newLanguage.IsoCode}{ImplicitlyChangingTextLanguageDefinition.Suffix}";
@@ -124,7 +124,7 @@ public async Task Can_create_resource_with_client_generated_string_ID_having_no_
(HttpResponseMessage httpResponse, string responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.NoContent);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.NoContent);
responseDocument.Should().BeEmpty();
@@ -179,7 +179,7 @@ await _testContext.RunOnDatabaseAsync(async dbContext =>
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.Conflict);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.Conflict);
responseDocument.Errors.ShouldHaveCount(1);
@@ -223,7 +223,7 @@ public async Task Cannot_create_resource_for_incompatible_ID()
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.UnprocessableEntity);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.UnprocessableEntity);
responseDocument.Errors.ShouldHaveCount(1);
@@ -263,7 +263,7 @@ public async Task Cannot_create_resource_for_ID_and_local_ID()
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.UnprocessableEntity);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.UnprocessableEntity);
responseDocument.Errors.ShouldHaveCount(1);
diff --git a/test/JsonApiDotNetCoreTests/IntegrationTests/AtomicOperations/Creating/AtomicCreateResourceWithToManyRelationshipTests.cs b/test/JsonApiDotNetCoreTests/IntegrationTests/AtomicOperations/Creating/AtomicCreateResourceWithToManyRelationshipTests.cs
index 32024c03dd..be9700c3d6 100644
--- a/test/JsonApiDotNetCoreTests/IntegrationTests/AtomicOperations/Creating/AtomicCreateResourceWithToManyRelationshipTests.cs
+++ b/test/JsonApiDotNetCoreTests/IntegrationTests/AtomicOperations/Creating/AtomicCreateResourceWithToManyRelationshipTests.cs
@@ -81,7 +81,7 @@ await _testContext.RunOnDatabaseAsync(async dbContext =>
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.OK);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.OK);
responseDocument.Results.ShouldHaveCount(1);
@@ -166,7 +166,7 @@ await _testContext.RunOnDatabaseAsync(async dbContext =>
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.OK);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.OK);
responseDocument.Results.ShouldHaveCount(1);
@@ -228,7 +228,7 @@ public async Task Cannot_create_for_missing_relationship_type()
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.UnprocessableEntity);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.UnprocessableEntity);
responseDocument.Errors.ShouldHaveCount(1);
@@ -280,7 +280,7 @@ public async Task Cannot_create_for_unknown_relationship_type()
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.UnprocessableEntity);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.UnprocessableEntity);
responseDocument.Errors.ShouldHaveCount(1);
@@ -331,7 +331,7 @@ public async Task Cannot_create_for_missing_relationship_ID()
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.UnprocessableEntity);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.UnprocessableEntity);
responseDocument.Errors.ShouldHaveCount(1);
@@ -397,7 +397,7 @@ public async Task Cannot_create_for_unknown_relationship_IDs()
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.NotFound);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.NotFound);
responseDocument.Errors.ShouldHaveCount(2);
@@ -457,7 +457,7 @@ public async Task Cannot_create_on_relationship_type_mismatch()
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.Conflict);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.Conflict);
responseDocument.Errors.ShouldHaveCount(1);
@@ -527,7 +527,7 @@ await _testContext.RunOnDatabaseAsync(async dbContext =>
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.OK);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.OK);
responseDocument.Results.ShouldHaveCount(1);
@@ -580,7 +580,7 @@ public async Task Cannot_create_with_missing_data_in_OneToMany_relationship()
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.UnprocessableEntity);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.UnprocessableEntity);
responseDocument.Errors.ShouldHaveCount(1);
@@ -625,7 +625,7 @@ public async Task Cannot_create_with_null_data_in_ManyToMany_relationship()
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.UnprocessableEntity);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.UnprocessableEntity);
responseDocument.Errors.ShouldHaveCount(1);
@@ -672,7 +672,7 @@ public async Task Cannot_create_with_object_data_in_ManyToMany_relationship()
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.UnprocessableEntity);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.UnprocessableEntity);
responseDocument.Errors.ShouldHaveCount(1);
diff --git a/test/JsonApiDotNetCoreTests/IntegrationTests/AtomicOperations/Creating/AtomicCreateResourceWithToOneRelationshipTests.cs b/test/JsonApiDotNetCoreTests/IntegrationTests/AtomicOperations/Creating/AtomicCreateResourceWithToOneRelationshipTests.cs
index a0ed043ae8..e7ba0d5288 100644
--- a/test/JsonApiDotNetCoreTests/IntegrationTests/AtomicOperations/Creating/AtomicCreateResourceWithToOneRelationshipTests.cs
+++ b/test/JsonApiDotNetCoreTests/IntegrationTests/AtomicOperations/Creating/AtomicCreateResourceWithToOneRelationshipTests.cs
@@ -75,7 +75,7 @@ await _testContext.RunOnDatabaseAsync(async dbContext =>
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.OK);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.OK);
responseDocument.Results.ShouldHaveCount(1);
@@ -146,7 +146,7 @@ await _testContext.RunOnDatabaseAsync(async dbContext =>
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.OK);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.OK);
responseDocument.Results.ShouldHaveCount(1);
@@ -223,7 +223,7 @@ await _testContext.RunOnDatabaseAsync(async dbContext =>
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.OK);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.OK);
responseDocument.Results.ShouldHaveCount(elementCount);
@@ -294,7 +294,7 @@ public async Task Cannot_create_for_null_relationship()
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.UnprocessableEntity);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.UnprocessableEntity);
responseDocument.Errors.ShouldHaveCount(1);
@@ -338,7 +338,7 @@ public async Task Cannot_create_for_missing_data_in_relationship()
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.UnprocessableEntity);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.UnprocessableEntity);
responseDocument.Errors.ShouldHaveCount(1);
@@ -390,7 +390,7 @@ public async Task Cannot_create_for_array_data_in_relationship()
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.UnprocessableEntity);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.UnprocessableEntity);
responseDocument.Errors.ShouldHaveCount(1);
@@ -438,7 +438,7 @@ public async Task Cannot_create_for_missing_relationship_type()
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.UnprocessableEntity);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.UnprocessableEntity);
responseDocument.Errors.ShouldHaveCount(1);
@@ -487,7 +487,7 @@ public async Task Cannot_create_for_unknown_relationship_type()
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.UnprocessableEntity);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.UnprocessableEntity);
responseDocument.Errors.ShouldHaveCount(1);
@@ -535,7 +535,7 @@ public async Task Cannot_create_for_missing_relationship_ID()
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.UnprocessableEntity);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.UnprocessableEntity);
responseDocument.Errors.ShouldHaveCount(1);
@@ -592,7 +592,7 @@ public async Task Cannot_create_with_unknown_relationship_ID()
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.NotFound);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.NotFound);
responseDocument.Errors.ShouldHaveCount(1);
@@ -641,7 +641,7 @@ public async Task Cannot_create_on_relationship_type_mismatch()
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.Conflict);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.Conflict);
responseDocument.Errors.ShouldHaveCount(1);
@@ -713,7 +713,7 @@ await _testContext.RunOnDatabaseAsync(async dbContext =>
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBodyText);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.OK);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.OK);
responseDocument.Results.ShouldHaveCount(1);
diff --git a/test/JsonApiDotNetCoreTests/IntegrationTests/AtomicOperations/Deleting/AtomicDeleteResourceTests.cs b/test/JsonApiDotNetCoreTests/IntegrationTests/AtomicOperations/Deleting/AtomicDeleteResourceTests.cs
index 45dbb11f5e..4baf6c7816 100644
--- a/test/JsonApiDotNetCoreTests/IntegrationTests/AtomicOperations/Deleting/AtomicDeleteResourceTests.cs
+++ b/test/JsonApiDotNetCoreTests/IntegrationTests/AtomicOperations/Deleting/AtomicDeleteResourceTests.cs
@@ -53,7 +53,7 @@ await _testContext.RunOnDatabaseAsync(async dbContext =>
(HttpResponseMessage httpResponse, string responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.NoContent);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.NoContent);
responseDocument.Should().BeEmpty();
@@ -106,7 +106,7 @@ await _testContext.RunOnDatabaseAsync(async dbContext =>
(HttpResponseMessage httpResponse, string responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.NoContent);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.NoContent);
responseDocument.Should().BeEmpty();
@@ -153,7 +153,7 @@ await _testContext.RunOnDatabaseAsync(async dbContext =>
(HttpResponseMessage httpResponse, string responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.NoContent);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.NoContent);
responseDocument.Should().BeEmpty();
@@ -204,7 +204,7 @@ await _testContext.RunOnDatabaseAsync(async dbContext =>
(HttpResponseMessage httpResponse, string responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.NoContent);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.NoContent);
responseDocument.Should().BeEmpty();
@@ -255,7 +255,7 @@ await _testContext.RunOnDatabaseAsync(async dbContext =>
(HttpResponseMessage httpResponse, string responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.NoContent);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.NoContent);
responseDocument.Should().BeEmpty();
@@ -307,7 +307,7 @@ await _testContext.RunOnDatabaseAsync(async dbContext =>
(HttpResponseMessage httpResponse, string responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.NoContent);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.NoContent);
responseDocument.Should().BeEmpty();
@@ -345,7 +345,7 @@ public async Task Cannot_delete_resource_for_href_element()
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.UnprocessableEntity);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.UnprocessableEntity);
responseDocument.Errors.ShouldHaveCount(1);
@@ -379,7 +379,7 @@ public async Task Cannot_delete_resource_for_missing_ref_element()
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.UnprocessableEntity);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.UnprocessableEntity);
responseDocument.Errors.ShouldHaveCount(1);
@@ -417,7 +417,7 @@ public async Task Cannot_delete_resource_for_missing_type()
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.UnprocessableEntity);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.UnprocessableEntity);
responseDocument.Errors.ShouldHaveCount(1);
@@ -456,7 +456,7 @@ public async Task Cannot_delete_resource_for_unknown_type()
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.UnprocessableEntity);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.UnprocessableEntity);
responseDocument.Errors.ShouldHaveCount(1);
@@ -494,7 +494,7 @@ public async Task Cannot_delete_resource_for_missing_ID()
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.UnprocessableEntity);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.UnprocessableEntity);
responseDocument.Errors.ShouldHaveCount(1);
@@ -535,7 +535,7 @@ public async Task Cannot_delete_resource_for_unknown_ID()
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.NotFound);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.NotFound);
responseDocument.Errors.ShouldHaveCount(1);
@@ -576,7 +576,7 @@ public async Task Cannot_delete_resource_for_incompatible_ID()
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.UnprocessableEntity);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.UnprocessableEntity);
responseDocument.Errors.ShouldHaveCount(1);
@@ -616,7 +616,7 @@ public async Task Cannot_delete_resource_for_ID_and_local_ID()
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.UnprocessableEntity);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.UnprocessableEntity);
responseDocument.Errors.ShouldHaveCount(1);
diff --git a/test/JsonApiDotNetCoreTests/IntegrationTests/AtomicOperations/Links/AtomicAbsoluteLinksTests.cs b/test/JsonApiDotNetCoreTests/IntegrationTests/AtomicOperations/Links/AtomicAbsoluteLinksTests.cs
index 792e565f3a..a6e162f72a 100644
--- a/test/JsonApiDotNetCoreTests/IntegrationTests/AtomicOperations/Links/AtomicAbsoluteLinksTests.cs
+++ b/test/JsonApiDotNetCoreTests/IntegrationTests/AtomicOperations/Links/AtomicAbsoluteLinksTests.cs
@@ -81,7 +81,7 @@ await _testContext.RunOnDatabaseAsync(async dbContext =>
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.OK);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.OK);
responseDocument.Results.ShouldHaveCount(2);
@@ -157,7 +157,7 @@ await _testContext.RunOnDatabaseAsync(async dbContext =>
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.OK);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.OK);
responseDocument.Results.ShouldHaveCount(1);
diff --git a/test/JsonApiDotNetCoreTests/IntegrationTests/AtomicOperations/Links/AtomicRelativeLinksWithNamespaceTests.cs b/test/JsonApiDotNetCoreTests/IntegrationTests/AtomicOperations/Links/AtomicRelativeLinksWithNamespaceTests.cs
index 4fa5027418..db6ee06bbf 100644
--- a/test/JsonApiDotNetCoreTests/IntegrationTests/AtomicOperations/Links/AtomicRelativeLinksWithNamespaceTests.cs
+++ b/test/JsonApiDotNetCoreTests/IntegrationTests/AtomicOperations/Links/AtomicRelativeLinksWithNamespaceTests.cs
@@ -74,7 +74,7 @@ public async Task Create_resource_with_side_effects_returns_relative_links()
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.OK);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.OK);
responseDocument.Results.ShouldHaveCount(2);
diff --git a/test/JsonApiDotNetCoreTests/IntegrationTests/AtomicOperations/LocalIds/AtomicLocalIdTests.cs b/test/JsonApiDotNetCoreTests/IntegrationTests/AtomicOperations/LocalIds/AtomicLocalIdTests.cs
index 05b7c22ae1..39768280bd 100644
--- a/test/JsonApiDotNetCoreTests/IntegrationTests/AtomicOperations/LocalIds/AtomicLocalIdTests.cs
+++ b/test/JsonApiDotNetCoreTests/IntegrationTests/AtomicOperations/LocalIds/AtomicLocalIdTests.cs
@@ -78,7 +78,7 @@ public async Task Can_create_resource_with_ManyToOne_relationship_using_local_ID
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.OK);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.OK);
responseDocument.Results.ShouldHaveCount(2);
@@ -175,7 +175,7 @@ public async Task Can_create_resource_with_OneToMany_relationship_using_local_ID
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.OK);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.OK);
responseDocument.Results.ShouldHaveCount(2);
@@ -271,7 +271,7 @@ public async Task Can_create_resource_with_ManyToMany_relationship_using_local_I
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.OK);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.OK);
responseDocument.Results.ShouldHaveCount(2);
@@ -358,7 +358,7 @@ public async Task Cannot_consume_local_ID_that_is_assigned_in_same_operation()
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.BadRequest);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.BadRequest);
responseDocument.Errors.ShouldHaveCount(1);
@@ -425,7 +425,7 @@ public async Task Cannot_reassign_local_ID()
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.BadRequest);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.BadRequest);
responseDocument.Errors.ShouldHaveCount(1);
@@ -485,7 +485,7 @@ public async Task Can_update_resource_using_local_ID()
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.OK);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.OK);
responseDocument.Results.ShouldHaveCount(2);
@@ -605,7 +605,7 @@ public async Task Can_update_resource_with_relationships_using_local_ID()
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.OK);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.OK);
responseDocument.Results.ShouldHaveCount(4);
@@ -724,7 +724,7 @@ public async Task Can_create_ManyToOne_relationship_using_local_ID()
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.OK);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.OK);
responseDocument.Results.ShouldHaveCount(3);
@@ -826,7 +826,7 @@ public async Task Can_create_OneToMany_relationship_using_local_ID()
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.OK);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.OK);
responseDocument.Results.ShouldHaveCount(3);
@@ -928,7 +928,7 @@ public async Task Can_create_ManyToMany_relationship_using_local_ID()
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.OK);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.OK);
responseDocument.Results.ShouldHaveCount(3);
@@ -1052,7 +1052,7 @@ await _testContext.RunOnDatabaseAsync(async dbContext =>
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.OK);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.OK);
responseDocument.Results.ShouldHaveCount(3);
@@ -1176,7 +1176,7 @@ await _testContext.RunOnDatabaseAsync(async dbContext =>
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.OK);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.OK);
responseDocument.Results.ShouldHaveCount(3);
@@ -1300,7 +1300,7 @@ await _testContext.RunOnDatabaseAsync(async dbContext =>
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.OK);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.OK);
responseDocument.Results.ShouldHaveCount(3);
@@ -1446,7 +1446,7 @@ await _testContext.RunOnDatabaseAsync(async dbContext =>
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.OK);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.OK);
responseDocument.Results.ShouldHaveCount(4);
@@ -1603,7 +1603,7 @@ await _testContext.RunOnDatabaseAsync(async dbContext =>
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.OK);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.OK);
responseDocument.Results.ShouldHaveCount(4);
@@ -1741,7 +1741,7 @@ await _testContext.RunOnDatabaseAsync(async dbContext =>
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.OK);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.OK);
responseDocument.Results.ShouldHaveCount(4);
@@ -1810,7 +1810,7 @@ public async Task Can_delete_resource_using_local_ID()
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.OK);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.OK);
responseDocument.Results.ShouldHaveCount(2);
@@ -1868,7 +1868,7 @@ public async Task Cannot_consume_unassigned_local_ID_in_ref()
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.BadRequest);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.BadRequest);
responseDocument.Errors.ShouldHaveCount(1);
@@ -1918,7 +1918,7 @@ public async Task Cannot_consume_unassigned_local_ID_in_data_element()
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.BadRequest);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.BadRequest);
responseDocument.Errors.ShouldHaveCount(1);
@@ -1982,7 +1982,7 @@ await _testContext.RunOnDatabaseAsync(async dbContext =>
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.BadRequest);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.BadRequest);
responseDocument.Errors.ShouldHaveCount(1);
@@ -2045,7 +2045,7 @@ public async Task Cannot_consume_unassigned_local_ID_in_relationship_data_elemen
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.BadRequest);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.BadRequest);
responseDocument.Errors.ShouldHaveCount(1);
@@ -2111,7 +2111,7 @@ public async Task Cannot_consume_unassigned_local_ID_in_relationship_data_array(
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.BadRequest);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.BadRequest);
responseDocument.Errors.ShouldHaveCount(1);
@@ -2176,7 +2176,7 @@ public async Task Cannot_consume_local_ID_of_different_type_in_same_operation()
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.BadRequest);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.BadRequest);
responseDocument.Errors.ShouldHaveCount(1);
@@ -2240,7 +2240,7 @@ public async Task Cannot_consume_local_ID_of_different_type_in_ref()
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.BadRequest);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.BadRequest);
responseDocument.Errors.ShouldHaveCount(1);
@@ -2301,7 +2301,7 @@ public async Task Cannot_consume_local_ID_of_different_type_in_data_element()
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.BadRequest);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.BadRequest);
responseDocument.Errors.ShouldHaveCount(1);
@@ -2382,7 +2382,7 @@ await _testContext.RunOnDatabaseAsync(async dbContext =>
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.BadRequest);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.BadRequest);
responseDocument.Errors.ShouldHaveCount(1);
@@ -2461,7 +2461,7 @@ public async Task Cannot_consume_local_ID_of_different_type_in_relationship_data
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.BadRequest);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.BadRequest);
responseDocument.Errors.ShouldHaveCount(1);
@@ -2537,7 +2537,7 @@ public async Task Cannot_consume_local_ID_of_different_type_in_relationship_data
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.BadRequest);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.BadRequest);
responseDocument.Errors.ShouldHaveCount(1);
diff --git a/test/JsonApiDotNetCoreTests/IntegrationTests/AtomicOperations/Meta/AtomicResourceMetaTests.cs b/test/JsonApiDotNetCoreTests/IntegrationTests/AtomicOperations/Meta/AtomicResourceMetaTests.cs
index 8fcda54494..12875231b6 100644
--- a/test/JsonApiDotNetCoreTests/IntegrationTests/AtomicOperations/Meta/AtomicResourceMetaTests.cs
+++ b/test/JsonApiDotNetCoreTests/IntegrationTests/AtomicOperations/Meta/AtomicResourceMetaTests.cs
@@ -81,7 +81,7 @@ public async Task Returns_resource_meta_in_create_resource_with_side_effects()
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.OK);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.OK);
responseDocument.Results.ShouldHaveCount(2);
@@ -153,7 +153,7 @@ await _testContext.RunOnDatabaseAsync(async dbContext =>
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.OK);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.OK);
responseDocument.Results.ShouldHaveCount(1);
diff --git a/test/JsonApiDotNetCoreTests/IntegrationTests/AtomicOperations/Meta/AtomicResponseMeta.cs b/test/JsonApiDotNetCoreTests/IntegrationTests/AtomicOperations/Meta/AtomicResponseMeta.cs
index a41a2bb22c..1dec130347 100644
--- a/test/JsonApiDotNetCoreTests/IntegrationTests/AtomicOperations/Meta/AtomicResponseMeta.cs
+++ b/test/JsonApiDotNetCoreTests/IntegrationTests/AtomicOperations/Meta/AtomicResponseMeta.cs
@@ -4,7 +4,7 @@ namespace JsonApiDotNetCoreTests.IntegrationTests.AtomicOperations.Meta;
public sealed class AtomicResponseMeta : IResponseMeta
{
- public IReadOnlyDictionary GetMeta()
+ public IDictionary GetMeta()
{
return new Dictionary
{
diff --git a/test/JsonApiDotNetCoreTests/IntegrationTests/AtomicOperations/Meta/AtomicResponseMetaTests.cs b/test/JsonApiDotNetCoreTests/IntegrationTests/AtomicOperations/Meta/AtomicResponseMetaTests.cs
index 327ff8e18c..ab084a0e90 100644
--- a/test/JsonApiDotNetCoreTests/IntegrationTests/AtomicOperations/Meta/AtomicResponseMetaTests.cs
+++ b/test/JsonApiDotNetCoreTests/IntegrationTests/AtomicOperations/Meta/AtomicResponseMetaTests.cs
@@ -58,7 +58,7 @@ public async Task Returns_top_level_meta_in_create_resource_with_side_effects()
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.OK);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.OK);
responseDocument.Meta.ShouldHaveCount(3);
@@ -124,7 +124,7 @@ await _testContext.RunOnDatabaseAsync(async dbContext =>
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.OK);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.OK);
responseDocument.Meta.ShouldHaveCount(3);
diff --git a/test/JsonApiDotNetCoreTests/IntegrationTests/AtomicOperations/Mixed/AtomicLoggingTests.cs b/test/JsonApiDotNetCoreTests/IntegrationTests/AtomicOperations/Mixed/AtomicLoggingTests.cs
index 19c9b2d872..f871e90238 100644
--- a/test/JsonApiDotNetCoreTests/IntegrationTests/AtomicOperations/Mixed/AtomicLoggingTests.cs
+++ b/test/JsonApiDotNetCoreTests/IntegrationTests/AtomicOperations/Mixed/AtomicLoggingTests.cs
@@ -73,7 +73,7 @@ public async Task Logs_at_error_level_on_unhandled_exception()
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.InternalServerError);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.InternalServerError);
responseDocument.Errors.ShouldHaveCount(1);
@@ -117,7 +117,7 @@ public async Task Logs_at_info_level_on_invalid_request_body()
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.UnprocessableEntity);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.UnprocessableEntity);
responseDocument.Errors.ShouldHaveCount(1);
diff --git a/test/JsonApiDotNetCoreTests/IntegrationTests/AtomicOperations/Mixed/AtomicRequestBodyTests.cs b/test/JsonApiDotNetCoreTests/IntegrationTests/AtomicOperations/Mixed/AtomicRequestBodyTests.cs
index aaf3722093..ee9d144123 100644
--- a/test/JsonApiDotNetCoreTests/IntegrationTests/AtomicOperations/Mixed/AtomicRequestBodyTests.cs
+++ b/test/JsonApiDotNetCoreTests/IntegrationTests/AtomicOperations/Mixed/AtomicRequestBodyTests.cs
@@ -27,7 +27,7 @@ public async Task Cannot_process_for_missing_request_body()
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, null!);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.BadRequest);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.BadRequest);
responseDocument.Errors.ShouldHaveCount(1);
@@ -51,7 +51,7 @@ public async Task Cannot_process_for_null_request_body()
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.UnprocessableEntity);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.UnprocessableEntity);
responseDocument.Errors.ShouldHaveCount(1);
@@ -75,7 +75,7 @@ public async Task Cannot_process_for_broken_JSON_request_body()
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.UnprocessableEntity);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.UnprocessableEntity);
responseDocument.Errors.ShouldHaveCount(1);
@@ -104,7 +104,7 @@ public async Task Cannot_process_for_missing_operations_array()
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.UnprocessableEntity);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.UnprocessableEntity);
responseDocument.Errors.ShouldHaveCount(1);
@@ -131,7 +131,7 @@ public async Task Cannot_process_empty_operations_array()
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.UnprocessableEntity);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.UnprocessableEntity);
responseDocument.Errors.ShouldHaveCount(1);
@@ -161,7 +161,7 @@ public async Task Cannot_process_null_operation()
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.UnprocessableEntity);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.UnprocessableEntity);
responseDocument.Errors.ShouldHaveCount(1);
@@ -202,7 +202,7 @@ public async Task Cannot_process_for_unknown_operation_code()
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.UnprocessableEntity);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.UnprocessableEntity);
responseDocument.Errors.ShouldHaveCount(1);
diff --git a/test/JsonApiDotNetCoreTests/IntegrationTests/AtomicOperations/Mixed/AtomicSerializationTests.cs b/test/JsonApiDotNetCoreTests/IntegrationTests/AtomicOperations/Mixed/AtomicSerializationTests.cs
index 314e14746e..925cd2e551 100644
--- a/test/JsonApiDotNetCoreTests/IntegrationTests/AtomicOperations/Mixed/AtomicSerializationTests.cs
+++ b/test/JsonApiDotNetCoreTests/IntegrationTests/AtomicOperations/Mixed/AtomicSerializationTests.cs
@@ -87,7 +87,7 @@ await _testContext.RunOnDatabaseAsync(async dbContext =>
(HttpResponseMessage httpResponse, string responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.OK);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.OK);
responseDocument.Should().BeJson(@"{
""jsonapi"": {
@@ -155,7 +155,7 @@ public async Task Includes_version_with_ext_on_error_in_operations_endpoint()
(HttpResponseMessage httpResponse, string responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.NotFound);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.NotFound);
string errorId = JsonApiStringConverter.ExtractErrorId(responseDocument);
diff --git a/test/JsonApiDotNetCoreTests/IntegrationTests/AtomicOperations/Mixed/MaximumOperationsPerRequestTests.cs b/test/JsonApiDotNetCoreTests/IntegrationTests/AtomicOperations/Mixed/MaximumOperationsPerRequestTests.cs
index 818fda8a70..f24e25a216 100644
--- a/test/JsonApiDotNetCoreTests/IntegrationTests/AtomicOperations/Mixed/MaximumOperationsPerRequestTests.cs
+++ b/test/JsonApiDotNetCoreTests/IntegrationTests/AtomicOperations/Mixed/MaximumOperationsPerRequestTests.cs
@@ -63,7 +63,7 @@ public async Task Cannot_process_more_operations_than_maximum()
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.UnprocessableEntity);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.UnprocessableEntity);
responseDocument.Errors.ShouldHaveCount(1);
@@ -118,7 +118,7 @@ public async Task Can_process_operations_same_as_maximum()
(HttpResponseMessage httpResponse, _) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.OK);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.OK);
}
[Fact]
@@ -158,6 +158,6 @@ public async Task Can_process_high_number_of_operations_when_unconstrained()
(HttpResponseMessage httpResponse, _) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.OK);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.OK);
}
}
diff --git a/test/JsonApiDotNetCoreTests/IntegrationTests/AtomicOperations/ModelStateValidation/AtomicModelStateValidationTests.cs b/test/JsonApiDotNetCoreTests/IntegrationTests/AtomicOperations/ModelStateValidation/AtomicModelStateValidationTests.cs
index 9c69af2f71..0eadc45f2c 100644
--- a/test/JsonApiDotNetCoreTests/IntegrationTests/AtomicOperations/ModelStateValidation/AtomicModelStateValidationTests.cs
+++ b/test/JsonApiDotNetCoreTests/IntegrationTests/AtomicOperations/ModelStateValidation/AtomicModelStateValidationTests.cs
@@ -48,7 +48,7 @@ public async Task Cannot_create_resource_with_multiple_violations()
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.UnprocessableEntity);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.UnprocessableEntity);
responseDocument.Errors.ShouldHaveCount(2);
@@ -119,7 +119,7 @@ await _testContext.RunOnDatabaseAsync(async dbContext =>
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.OK);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.OK);
responseDocument.Results.ShouldHaveCount(1);
@@ -173,7 +173,7 @@ await _testContext.RunOnDatabaseAsync(async dbContext =>
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.UnprocessableEntity);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.UnprocessableEntity);
responseDocument.Errors.ShouldHaveCount(2);
@@ -231,7 +231,7 @@ await _testContext.RunOnDatabaseAsync(async dbContext =>
(HttpResponseMessage httpResponse, string responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.NoContent);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.NoContent);
responseDocument.Should().BeEmpty();
@@ -293,7 +293,7 @@ await _testContext.RunOnDatabaseAsync(async dbContext =>
(HttpResponseMessage httpResponse, string responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.NoContent);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.NoContent);
responseDocument.Should().BeEmpty();
@@ -347,7 +347,7 @@ await _testContext.RunOnDatabaseAsync(async dbContext =>
(HttpResponseMessage httpResponse, string responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.NoContent);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.NoContent);
responseDocument.Should().BeEmpty();
@@ -404,7 +404,7 @@ await _testContext.RunOnDatabaseAsync(async dbContext =>
(HttpResponseMessage httpResponse, string responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.NoContent);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.NoContent);
responseDocument.Should().BeEmpty();
@@ -460,7 +460,7 @@ public async Task Validates_all_operations_before_execution_starts()
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.UnprocessableEntity);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.UnprocessableEntity);
responseDocument.Errors.ShouldHaveCount(2);
@@ -544,7 +544,7 @@ public async Task Does_not_exceed_MaxModelValidationErrors()
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.UnprocessableEntity);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.UnprocessableEntity);
responseDocument.Errors.ShouldHaveCount(3);
diff --git a/test/JsonApiDotNetCoreTests/IntegrationTests/AtomicOperations/QueryStrings/AtomicQueryStringTests.cs b/test/JsonApiDotNetCoreTests/IntegrationTests/AtomicOperations/QueryStrings/AtomicQueryStringTests.cs
index cf0db00e3e..640e6ac3fe 100644
--- a/test/JsonApiDotNetCoreTests/IntegrationTests/AtomicOperations/QueryStrings/AtomicQueryStringTests.cs
+++ b/test/JsonApiDotNetCoreTests/IntegrationTests/AtomicOperations/QueryStrings/AtomicQueryStringTests.cs
@@ -63,7 +63,7 @@ public async Task Cannot_include_on_operations_endpoint()
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.BadRequest);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.BadRequest);
responseDocument.Errors.ShouldHaveCount(1);
@@ -103,7 +103,7 @@ public async Task Cannot_filter_on_operations_endpoint()
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.BadRequest);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.BadRequest);
responseDocument.Errors.ShouldHaveCount(1);
@@ -143,7 +143,7 @@ public async Task Cannot_sort_on_operations_endpoint()
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.BadRequest);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.BadRequest);
responseDocument.Errors.ShouldHaveCount(1);
@@ -183,7 +183,7 @@ public async Task Cannot_use_pagination_number_on_operations_endpoint()
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.BadRequest);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.BadRequest);
responseDocument.Errors.ShouldHaveCount(1);
@@ -223,7 +223,7 @@ public async Task Cannot_use_pagination_size_on_operations_endpoint()
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.BadRequest);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.BadRequest);
responseDocument.Errors.ShouldHaveCount(1);
@@ -263,7 +263,7 @@ public async Task Cannot_use_sparse_fieldset_on_operations_endpoint()
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.BadRequest);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.BadRequest);
responseDocument.Errors.ShouldHaveCount(1);
@@ -297,7 +297,7 @@ await _testContext.RunOnDatabaseAsync(async dbContext =>
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecuteGetAsync(route);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.OK);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.OK);
responseDocument.Data.ManyValue.ShouldHaveCount(1);
responseDocument.Data.ManyValue[0].Id.Should().Be(musicTracks[2].StringId);
@@ -334,7 +334,7 @@ public async Task Cannot_use_Queryable_handler_on_operations_endpoint()
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.BadRequest);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.BadRequest);
responseDocument.Errors.ShouldHaveCount(1);
diff --git a/test/JsonApiDotNetCoreTests/IntegrationTests/AtomicOperations/ResourceDefinitions/Serialization/AtomicSerializationResourceDefinitionTests.cs b/test/JsonApiDotNetCoreTests/IntegrationTests/AtomicOperations/ResourceDefinitions/Serialization/AtomicSerializationResourceDefinitionTests.cs
index acbd3e0895..27e44ec234 100644
--- a/test/JsonApiDotNetCoreTests/IntegrationTests/AtomicOperations/ResourceDefinitions/Serialization/AtomicSerializationResourceDefinitionTests.cs
+++ b/test/JsonApiDotNetCoreTests/IntegrationTests/AtomicOperations/ResourceDefinitions/Serialization/AtomicSerializationResourceDefinitionTests.cs
@@ -86,7 +86,7 @@ await _testContext.RunOnDatabaseAsync(async dbContext =>
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.OK);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.OK);
responseDocument.Results.ShouldHaveCount(2);
@@ -179,7 +179,7 @@ await _testContext.RunOnDatabaseAsync(async dbContext =>
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.OK);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.OK);
responseDocument.Results.ShouldHaveCount(1);
@@ -238,7 +238,7 @@ await _testContext.RunOnDatabaseAsync(async dbContext =>
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.OK);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.OK);
responseDocument.Results.ShouldHaveCount(2);
@@ -330,7 +330,7 @@ await _testContext.RunOnDatabaseAsync(async dbContext =>
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.OK);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.OK);
responseDocument.Results.ShouldHaveCount(1);
@@ -380,7 +380,7 @@ await _testContext.RunOnDatabaseAsync(async dbContext =>
(HttpResponseMessage httpResponse, string responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.NoContent);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.NoContent);
responseDocument.Should().BeEmpty();
diff --git a/test/JsonApiDotNetCoreTests/IntegrationTests/AtomicOperations/ResourceDefinitions/SparseFieldSets/AtomicSparseFieldSetResourceDefinitionTests.cs b/test/JsonApiDotNetCoreTests/IntegrationTests/AtomicOperations/ResourceDefinitions/SparseFieldSets/AtomicSparseFieldSetResourceDefinitionTests.cs
index a25100b414..f70a289ba1 100644
--- a/test/JsonApiDotNetCoreTests/IntegrationTests/AtomicOperations/ResourceDefinitions/SparseFieldSets/AtomicSparseFieldSetResourceDefinitionTests.cs
+++ b/test/JsonApiDotNetCoreTests/IntegrationTests/AtomicOperations/ResourceDefinitions/SparseFieldSets/AtomicSparseFieldSetResourceDefinitionTests.cs
@@ -84,7 +84,7 @@ public async Task Hides_text_in_create_resource_with_side_effects()
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.OK);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.OK);
responseDocument.Results.ShouldHaveCount(2);
@@ -163,7 +163,7 @@ await _testContext.RunOnDatabaseAsync(async dbContext =>
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.OK);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.OK);
responseDocument.Results.ShouldHaveCount(2);
diff --git a/test/JsonApiDotNetCoreTests/IntegrationTests/AtomicOperations/Transactions/AtomicRollbackTests.cs b/test/JsonApiDotNetCoreTests/IntegrationTests/AtomicOperations/Transactions/AtomicRollbackTests.cs
index 8e4baf0cef..82646686d4 100644
--- a/test/JsonApiDotNetCoreTests/IntegrationTests/AtomicOperations/Transactions/AtomicRollbackTests.cs
+++ b/test/JsonApiDotNetCoreTests/IntegrationTests/AtomicOperations/Transactions/AtomicRollbackTests.cs
@@ -86,7 +86,7 @@ await _testContext.RunOnDatabaseAsync(async dbContext =>
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.NotFound);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.NotFound);
responseDocument.Errors.ShouldHaveCount(1);
@@ -166,7 +166,7 @@ await _testContext.RunOnDatabaseAsync(async dbContext =>
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.NotFound);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.NotFound);
responseDocument.Errors.ShouldHaveCount(1);
diff --git a/test/JsonApiDotNetCoreTests/IntegrationTests/AtomicOperations/Transactions/AtomicTransactionConsistencyTests.cs b/test/JsonApiDotNetCoreTests/IntegrationTests/AtomicOperations/Transactions/AtomicTransactionConsistencyTests.cs
index 711c45de00..97f0e08ff5 100644
--- a/test/JsonApiDotNetCoreTests/IntegrationTests/AtomicOperations/Transactions/AtomicTransactionConsistencyTests.cs
+++ b/test/JsonApiDotNetCoreTests/IntegrationTests/AtomicOperations/Transactions/AtomicTransactionConsistencyTests.cs
@@ -61,7 +61,7 @@ public async Task Cannot_use_non_transactional_repository()
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.UnprocessableEntity);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.UnprocessableEntity);
responseDocument.Errors.ShouldHaveCount(1);
@@ -104,7 +104,7 @@ public async Task Cannot_use_transactional_repository_without_active_transaction
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.UnprocessableEntity);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.UnprocessableEntity);
responseDocument.Errors.ShouldHaveCount(1);
@@ -147,7 +147,7 @@ public async Task Cannot_use_distributed_transaction()
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.UnprocessableEntity);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.UnprocessableEntity);
responseDocument.Errors.ShouldHaveCount(1);
diff --git a/test/JsonApiDotNetCoreTests/IntegrationTests/AtomicOperations/Updating/Relationships/AtomicAddToToManyRelationshipTests.cs b/test/JsonApiDotNetCoreTests/IntegrationTests/AtomicOperations/Updating/Relationships/AtomicAddToToManyRelationshipTests.cs
index d249ec2563..fc13524e8a 100644
--- a/test/JsonApiDotNetCoreTests/IntegrationTests/AtomicOperations/Updating/Relationships/AtomicAddToToManyRelationshipTests.cs
+++ b/test/JsonApiDotNetCoreTests/IntegrationTests/AtomicOperations/Updating/Relationships/AtomicAddToToManyRelationshipTests.cs
@@ -60,7 +60,7 @@ await _testContext.RunOnDatabaseAsync(async dbContext =>
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.Forbidden);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.Forbidden);
responseDocument.Errors.ShouldHaveCount(1);
@@ -138,7 +138,7 @@ await _testContext.RunOnDatabaseAsync(async dbContext =>
(HttpResponseMessage httpResponse, string responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.NoContent);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.NoContent);
responseDocument.Should().BeEmpty();
@@ -218,7 +218,7 @@ await _testContext.RunOnDatabaseAsync(async dbContext =>
(HttpResponseMessage httpResponse, string responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.NoContent);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.NoContent);
responseDocument.Should().BeEmpty();
@@ -255,7 +255,7 @@ public async Task Cannot_add_for_href_element()
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.UnprocessableEntity);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.UnprocessableEntity);
responseDocument.Errors.ShouldHaveCount(1);
@@ -294,7 +294,7 @@ public async Task Cannot_add_for_missing_type_in_ref()
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.UnprocessableEntity);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.UnprocessableEntity);
responseDocument.Errors.ShouldHaveCount(1);
@@ -334,7 +334,7 @@ public async Task Cannot_add_for_unknown_type_in_ref()
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.UnprocessableEntity);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.UnprocessableEntity);
responseDocument.Errors.ShouldHaveCount(1);
@@ -373,7 +373,7 @@ public async Task Cannot_add_for_missing_ID_in_ref()
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.UnprocessableEntity);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.UnprocessableEntity);
responseDocument.Errors.ShouldHaveCount(1);
@@ -431,7 +431,7 @@ await _testContext.RunOnDatabaseAsync(async dbContext =>
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.NotFound);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.NotFound);
responseDocument.Errors.ShouldHaveCount(1);
@@ -472,7 +472,7 @@ public async Task Cannot_add_for_ID_and_local_ID_in_ref()
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.UnprocessableEntity);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.UnprocessableEntity);
responseDocument.Errors.ShouldHaveCount(1);
@@ -511,7 +511,7 @@ public async Task Cannot_add_for_missing_relationship_in_ref()
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.UnprocessableEntity);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.UnprocessableEntity);
responseDocument.Errors.ShouldHaveCount(1);
@@ -551,7 +551,7 @@ public async Task Cannot_add_for_unknown_relationship_in_ref()
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync(route, requestBody);
// Assert
- httpResponse.Should().HaveStatusCode(HttpStatusCode.UnprocessableEntity);
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.UnprocessableEntity);
responseDocument.Errors.ShouldHaveCount(1);
@@ -599,7 +599,7 @@ await _testContext.RunOnDatabaseAsync(async dbContext =>
(HttpResponseMessage httpResponse, Document responseDocument) = await _testContext.ExecutePostAtomicAsync