Rename filter attribute

Author: ammeep

LibGit2Sharp.Tests/FilterFixture.cs

@@ -13,7 +13,7 @@ public class FilterFixture : BaseFixture
         readonly Func<Stream, Stream, int> successCallback = (reader, writer) => 0;
 
         private const string FilterName = "the-filter";
-        readonly List<FilterAttribute> attributes = new List<FilterAttribute> { new FilterAttribute("test") };
+        readonly List<FilterAttributeEntry> attributes = new List<FilterAttributeEntry> { new FilterAttributeEntry("test") };
 
         [Fact]
         public void CanRegisterFilterWithSingleAttribute()
@@ -271,7 +271,7 @@ private Repository CreateTestRepository(string path)
 
         class EmptyFilter : Filter
         {
-            public EmptyFilter(string name, IEnumerable<FilterAttribute> attributes)
+            public EmptyFilter(string name, IEnumerable<FilterAttributeEntry> attributes)
                 : base(name, attributes)
             { }
         }
@@ -282,7 +282,7 @@ class FakeFilter : Filter
             private readonly Func<Stream, Stream, int> smudgeCallback;
             private readonly Func<int> initCallback;
 
-            public FakeFilter(string name, IEnumerable<FilterAttribute> attributes,
+            public FakeFilter(string name, IEnumerable<FilterAttributeEntry> attributes,
                 Func<Stream, Stream, int> cleanCallback = null,
                 Func<Stream, Stream, int> smudgeCallback = null,
                 Func<int> initCallback = null)

LibGit2Sharp.Tests/FilterSubstitutionCipherFixture.cs

@@ -15,7 +15,7 @@ public void SmugdeIsNotCalledForFileWhichDoesNotMatchAnAttributeEntry()
             const string decodedInput = "This is a substitution cipher";
             const string encodedInput = "Guvf vf n fhofgvghgvba pvcure";
 
-            var attributes = new List<FilterAttribute> { new FilterAttribute("filter=rot13") };
+            var attributes = new List<FilterAttributeEntry> { new FilterAttributeEntry("filter=rot13") };
             var filter = new SubstitutionCipherFilter("cipher-filter", attributes);
             var filterRegistration = GlobalSettings.RegisterFilter(filter);
 
@@ -55,7 +55,7 @@ public void CorrectlyEncodesAndDecodesInput()
             const string decodedInput = "This is a substitution cipher";
             const string encodedInput = "Guvf vf n fhofgvghgvba pvcure";
 
-            var attributes = new List<FilterAttribute> { new FilterAttribute("filter=rot13") };
+            var attributes = new List<FilterAttributeEntry> { new FilterAttributeEntry("filter=rot13") };
             var filter = new SubstitutionCipherFilter("cipher-filter", attributes);
             var filterRegistration = GlobalSettings.RegisterFilter(filter);
 
@@ -98,7 +98,7 @@ public void WhenStagedFileDoesNotMatchPathSpecFileIsNotFiltered(string pathSpec,
             const string decodedInput = "This is a substitution cipher";
             string attributeFileEntry = string.Format("{0} {1}", pathSpec, filterName);
 
-            var filterForAttributes = new List<FilterAttribute> { new FilterAttribute(filterName) };
+            var filterForAttributes = new List<FilterAttributeEntry> { new FilterAttributeEntry(filterName) };
             var filter = new SubstitutionCipherFilter("cipher-filter", filterForAttributes);
 
             var filterRegistration = GlobalSettings.RegisterFilter(filter);
@@ -135,7 +135,7 @@ public void CleanIsCalledIfAttributeEntryMatches(string filterAttribute, string
         {
             const string decodedInput = "This is a substitution cipher";
 
-            var filterForAttributes = new List<FilterAttribute> { new FilterAttribute(filterAttribute) };
+            var filterForAttributes = new List<FilterAttributeEntry> { new FilterAttributeEntry(filterAttribute) };
             var filter = new SubstitutionCipherFilter("cipher-filter", filterForAttributes);
 
             var filterRegistration = GlobalSettings.RegisterFilter(filter);
@@ -168,7 +168,7 @@ public void SmudgeIsCalledIfAttributeEntryMatches(string filterAttribute, string
         {
             const string decodedInput = "This is a substitution cipher";
 
-            var filterForAttributes = new List<FilterAttribute> { new FilterAttribute(filterAttribute) };
+            var filterForAttributes = new List<FilterAttributeEntry> { new FilterAttributeEntry(filterAttribute) };
             var filter = new SubstitutionCipherFilter("cipher-filter", filterForAttributes);
 
             var filterRegistration = GlobalSettings.RegisterFilter(filter);

LibGit2Sharp.Tests/TestHelpers/SubstitutionCipherFilter.cs

@@ -8,7 +8,7 @@ public class SubstitutionCipherFilter : Filter
         public int CleanCalledCount = 0;
         public int SmudgeCalledCount = 0;
 
-        public SubstitutionCipherFilter(string name, IEnumerable<FilterAttribute> attributes)
+        public SubstitutionCipherFilter(string name, IEnumerable<FilterAttributeEntry> attributes)
             : base(name, attributes)
         {
         }

LibGit2Sharp/Filter.cs

@@ -17,7 +17,7 @@ public abstract class Filter : IEquatable<Filter>
         new LambdaEqualityHelper<Filter>(x => x.Name, x => x.Attributes);
 
         private readonly string name;
-        private readonly IEnumerable<FilterAttribute> attributes;
+        private readonly IEnumerable<FilterAttributeEntry> attributes;
 
         private readonly GitFilter gitFilter;
 
@@ -27,7 +27,7 @@ public abstract class Filter : IEquatable<Filter>
         /// <param name="name">The unique name with which this filtered is registered with</param>
         /// <param name="filterAttributes">A list of attributes which this filter applies to</param>
         /// </summary>
-        protected Filter(string name, IEnumerable<FilterAttribute> attributes)
+        protected Filter(string name, IEnumerable<FilterAttributeEntry> attributes)
         {
             Ensure.ArgumentNotNullOrEmptyString(name, "name");
             Ensure.ArgumentNotNull(attributes, "attributes");
@@ -55,7 +55,7 @@ public string Name
         /// <summary>
         /// The filter filterForAttributes.
         /// </summary>
-        public IEnumerable<FilterAttribute> Attributes
+        public IEnumerable<FilterAttributeEntry> Attributes
         {
             get { return attributes; }
         }

LibGit2Sharp/FilterAttribute.cs renamed to LibGit2Sharp/FilterAttributeEntry.cs

@@ -5,11 +5,11 @@ namespace LibGit2Sharp
     /// <summary>
     /// The definition for a given filter found in the .gitattributes file.
     /// The filter definition will result as 'filter=filterName'
-    /// 
+    ///
     /// In the .gitattributes file a filter will be matched to a pathspec like so
     /// '*.txt filter=filterName'
     /// </summary>
-    public class FilterAttribute
+    public class FilterAttributeEntry
     {
         private const string AttributeFilterDefinition = "filter=";
 
@@ -19,7 +19,7 @@ public class FilterAttribute
         /// The name of the filter found in a .gitattributes file
         /// </summary>
         /// <param name="filterName">The name of the filter</param>
-        public FilterAttribute(string filterName)
+        public FilterAttributeEntry(string filterName)
         {
             Ensure.ArgumentNotNullOrEmptyString(filterName, "filterName");
 
@@ -39,4 +39,4 @@ public string FilterDefinition
             get { return filterDefinition; }
         }
     }
-}
+}

LibGit2Sharp/LibGit2Sharp.csproj

@@ -81,7 +81,7 @@
     <Compile Include="Core\Handles\IndexReucEntrySafeHandle.cs" />
     <Compile Include="EntryExistsException.cs" />
     <Compile Include="FetchOptionsBase.cs" />
-    <Compile Include="FilterAttribute.cs" />
+    <Compile Include="FilterAttributeEntry.cs" />
     <Compile Include="FilterMode.cs" />
     <Compile Include="FilterRegistration.cs" />
     <Compile Include="FilterSource.cs" />