diff --git a/Magento2/Sniffs/Annotation/MethodArgumentsSniff.php b/Magento2/Sniffs/Annotation/MethodArgumentsSniff.php index 655bd37c..09c8208b 100644 --- a/Magento2/Sniffs/Annotation/MethodArgumentsSniff.php +++ b/Magento2/Sniffs/Annotation/MethodArgumentsSniff.php @@ -609,8 +609,6 @@ public function process(File $phpcsFile, $stackPtr) * @param File $phpcsFile * @param array $paramPointers * - * @SuppressWarnings(PHPMD.UnusedLocalVariable) - * * @see https://devdocs.magento.com/guides/v2.4/coding-standards/docblock-standard-general.html#format-consistency */ private function validateFormattingConsistency( @@ -626,7 +624,9 @@ private function validateFormattingConsistency( if (isset($paramPointers[$ptr])) { $paramContent = $tokens[$paramPointers[$ptr] + 2]['content']; $paramDefinition = $paramDefinitions[$ptr]; - $argumentPositions[] = strpos($paramContent, $paramDefinition['paramName']); + if (isset($paramDefinition['paramName'])) { + $argumentPositions[] = strpos($paramContent, $paramDefinition['paramName']); + } $commentPositions[] = $paramDefinition['comment'] ? strrpos($paramContent, $paramDefinition['comment']) : null; } diff --git a/Magento2/Tests/Annotation/MethodArgumentsUnitTest.inc b/Magento2/Tests/Annotation/MethodArgumentsUnitTest.inc index f3cbbb54..7add3ae9 100644 --- a/Magento2/Tests/Annotation/MethodArgumentsUnitTest.inc +++ b/Magento2/Tests/Annotation/MethodArgumentsUnitTest.inc @@ -22,3 +22,14 @@ public function setExtensionAs(\Magento\Catalog\Api\Data\CategoryExtensionInterf { return $this->_setExtensionAttributes($extensionAttributes); } + +/** + * Short description of method + * + * @param int + * @return int + */ +public function invalidDocBlockShouldNotCauseFatalErrorInSniff(int $number): int +{ + return $number; +} diff --git a/Magento2/Tests/Annotation/MethodArgumentsUnitTest.php b/Magento2/Tests/Annotation/MethodArgumentsUnitTest.php index 623c7539..86854e83 100644 --- a/Magento2/Tests/Annotation/MethodArgumentsUnitTest.php +++ b/Magento2/Tests/Annotation/MethodArgumentsUnitTest.php @@ -16,10 +16,11 @@ public function getErrorList() { return [ 12 => 1, - 21 => 1 + 21 => 1, + 32 => 1, ]; } - + /** * @inheritdoc */