Fix issue with js file having to be already present in project service

Author: sheetalkamat

src/server/session.ts

@@ -1565,8 +1565,16 @@ export class Session<TMessage = string> implements EventSender {
                 const ambientCandidates = definitions.filter(d => toNormalizedPath(d.fileName) !== file && d.isAmbient);
                 for (const candidate of some(ambientCandidates) ? ambientCandidates : getAmbientCandidatesByClimbingAccessChain()) {
                     const fileNameToSearch = findImplementationFileFromDtsFileName(candidate.fileName, file, noDtsProject);
-                    if (!fileNameToSearch || !ensureRoot(noDtsProject, fileNameToSearch)) {
-                        continue;
+                    if (!fileNameToSearch) continue;
+                    const info = this.projectService.getOrCreateScriptInfoNotOpenedByClient(
+                        fileNameToSearch,
+                        noDtsProject.currentDirectory,
+                        noDtsProject.directoryStructureHost,
+                    );
+                    if (!info) continue;
+                    if (!noDtsProject.containsScriptInfo(info)) {
+                        noDtsProject.addRoot(info);
+                        noDtsProject.updateGraph();
                     }
                     const noDtsProgram = ls.getProgram()!;
                     const fileToSearch = Debug.checkDefined(noDtsProgram.getSourceFile(fileNameToSearch));
@@ -1672,16 +1680,6 @@ export class Session<TMessage = string> implements EventSender {
                 }
             });
         }
-
-        function ensureRoot(project: AuxiliaryProject, fileName: string) {
-            const info = project.getScriptInfo(fileName);
-            if (!info) return false;
-            if (!project.containsScriptInfo(info)) {
-                project.addRoot(info);
-                project.updateGraph();
-            }
-            return true;
-        }
     }
 
     private getEmitOutput(args: protocol.EmitOutputRequestArgs): EmitOutput | protocol.EmitOutput {

tests/baselines/reference/goToSource17_AddsFileToProject.baseline.jsonc

@@ -1,6 +1,20 @@
 // === goToSourceDefinition ===
+// === /node_modules/yargs/callback.js ===
+// export class Yargs { [|positional|]() { } }
+
 // === /index.ts ===
 // import { command } from "yargs";
 // command("foo", yargs => {
 //     yargs./*GOTO SOURCE DEF*/positional();
-// });
+// });
+
+  // === Details ===
+  [
+   {
+    "containerKind": "",
+    "containerName": "",
+    "kind": "",
+    "name": "",
+    "unverified": true
+   }
+  ]

tests/baselines/reference/tsserver/auxiliaryProject/file-is-added-later-through-finding-definition.js

@@ -166,10 +166,48 @@ Info seq  [hh:mm:ss:mss] 	Files (2)
 	index.ts
 	  Root file specified for compilation
 
+Info seq  [hh:mm:ss:mss] -----------------------------------------------
+Info seq  [hh:mm:ss:mss] Starting updateGraphWorker: Project: /dev/null/auxiliaryProject1*
+Info seq  [hh:mm:ss:mss] Finishing updateGraphWorker: Project: /dev/null/auxiliaryProject1* Version: 2 structureChanged: true structureIsReused:: Not Elapsed:: *ms
+Info seq  [hh:mm:ss:mss] Project '/dev/null/auxiliaryProject1*' (Auxiliary)
+Info seq  [hh:mm:ss:mss] 	Files (3)
+	/user/users/projects/myproject/node_modules/yargs/index.js Text-1 "// Specifically didnt have ./callback import to ensure that resolving module sepcifier adds the file to project at later stage\nexport function command(cmd, cb) { cb(Yargs) }\n"
+	/user/users/projects/myproject/index.ts SVC-1-0 "import { command } from \"yargs\";\ncommand(\"foo\", yargs => {\n    yargs.positional();\n});\n"
+	/user/users/projects/myproject/node_modules/yargs/callback.js Text-1 "export class Yargs { positional() { } }\n"
+
+
+	node_modules/yargs/index.js
+	  Imported via "yargs" from file 'index.ts' with packageId 'yargs/index.js@1.0.0'
+	index.ts
+	  Root file specified for compilation
+	node_modules/yargs/callback.js
+	  Root file specified for compilation
+
 Info seq  [hh:mm:ss:mss] -----------------------------------------------
 Info seq  [hh:mm:ss:mss] response:
     {
-      "response": [],
+      "response": [
+        {
+          "file": "/user/users/projects/myproject/node_modules/yargs/callback.js",
+          "start": {
+            "line": 1,
+            "offset": 22
+          },
+          "end": {
+            "line": 1,
+            "offset": 32
+          },
+          "contextStart": {
+            "line": 1,
+            "offset": 22
+          },
+          "contextEnd": {
+            "line": 1,
+            "offset": 38
+          },
+          "unverified": true
+        }
+      ],
       "responseRequired": true
     }
 After request