PHPLIB-1118: Drop support for PHP 7.2 and 7.3 (#1128)

* PHPLIB-1118: Drop support for PHP 7.2 and 7.3

* Modernise code for PHP 7.4

This uses rector and phpcbf to automatically fix issues

* Skip rector rule creating adding wrong property type

* Add more missing property types

* Use strval instead of closure

* Use FQN for constant in documentation examples

* Add undectected missing trailing commas

* Split line for readability

* Fix wrong property type

* Remove requirement for JSON_THROW_ON_ERROR in docs examples

* Address code review issues

Author: alcaeus

.evergreen/config.yml

@@ -690,14 +690,6 @@ axes:
         display_name: "PHP 7.4"
         variables:
           PHP_VERSION: "7.4"
-      - id: "7.3"
-        display_name: "PHP 7.3"
-        variables:
-          PHP_VERSION: "7.3"
-      - id: "7.2"
-        display_name: "PHP 7.2"
-        variables:
-          PHP_VERSION: "7.2"
 
   - id: php-edge-versions
     display_name: PHP Version
@@ -707,9 +699,9 @@ axes:
         variables:
           PHP_VERSION: "8.2"
       - id: "oldest-supported"
-        display_name: "PHP 7.2"
+        display_name: "PHP 7.4"
         variables:
-          PHP_VERSION: "7.2"
+          PHP_VERSION: "7.4"
 
   - id: mongodb-versions
     display_name: MongoDB Version
@@ -898,7 +890,7 @@ buildvariants:
     # Exclude "latest-stable" PHP version for Debian 11 (see: test-mongodb-versions matrix)
     - { "os": "debian11", "mongodb-edge-versions": "latest-stable", "php-versions": "8.2", "driver-versions": "latest-stable" }
     # Exclude PHP versions older than 8.1 on RHEL 9 and Ubuntu 22.04 (OpenSSL 3 is only supported on PHP 8.1+)
-    - { "os": ["rhel90", "ubuntu2204-arm64", "ubuntu2204"], "php-versions": ["7.2", "7.3", "7.4", "8.0"], "mongodb-edge-versions": "*", "driver-versions": "*" }
+    - { "os": ["rhel90", "ubuntu2204-arm64", "ubuntu2204"], "php-versions": ["7.4", "8.0"], "mongodb-edge-versions": "*", "driver-versions": "*" }
   tasks:
     - name: "test-standalone"
     - name: "test-replica_set"

composer.json

@@ -10,7 +10,7 @@
         { "name": "Jérôme Tamarelle", "email": "[email protected]" }
     ],
     "require": {
-        "php": "^7.2 || ^8.0",
+        "php": "^7.4 || ^8.0",
         "ext-hash": "*",
         "ext-json": "*",
         "ext-mongodb": "^1.16.0",

examples/bulk.php

@@ -68,7 +68,7 @@ function toJSON(object $document): string
                 ['x' => 10], // Document
             ],
         ],
-    ]
+    ],
 );
 
 $cursor = $collection->find([]);

examples/command_logger.php

@@ -69,7 +69,7 @@ public function commandFailed(CommandFailedEvent $event): void
 
 $collection->updateMany(
     ['x' => ['$gt' => 1]],
-    ['$set' => ['y' => 1]]
+    ['$set' => ['y' => 1]],
 );
 
 $cursor = $collection->find([], ['batchSize' => 2]);

examples/persistable.php

@@ -16,14 +16,12 @@
 
 class PersistableEntry implements Persistable
 {
-    /** @var ObjectId */
-    private $id;
+    private ObjectId $id;
 
-    /** @var string */
-    public $name;
+    public string $name;
 
     /** @var array<PersistableEmail> */
-    public $emails = [];
+    public array $emails = [];
 
     public function __construct(string $name)
     {
@@ -65,11 +63,9 @@ public function bsonUnserialize(array $data): void
 
 class PersistableEmail implements Persistable
 {
-    /** @var string */
-    public $type;
+    public string $type;
 
-    /** @var string */
-    public $address;
+    public string $address;
 
     public function __construct(string $type, string $address)
     {

examples/typemap.php

@@ -16,14 +16,12 @@
 
 class TypeMapEntry implements Unserializable
 {
-    /** @var ObjectId */
-    private $id;
+    private ObjectId $id;
 
-    /** @var string */
-    private $name;
+    private string $name;
 
     /** @var array<TypeMapEmail> */
-    private $emails;
+    private array $emails;
 
     private function __construct()
     {
@@ -64,11 +62,9 @@ public function bsonUnserialize(array $data): void
 
 class TypeMapEmail implements Unserializable
 {
-    /** @var string */
-    private $type;
+    private string $type;
 
-    /** @var string */
-    private $address;
+    private string $address;
 
     private function __construct()
     {

examples/with_transaction.php

@@ -37,13 +37,13 @@ function toJSON(object $document): string
             ['x' => 2],
             ['x' => 3],
         ],
-        ['session' => $session]
+        ['session' => $session],
     );
 
     $collection->updateMany(
         ['x' => ['$gt' => 1]],
         ['$set' => ['y' => 1]],
-        ['session' => $session]
+        ['session' => $session],
     );
 };
 

phpcs.xml.dist

@@ -17,7 +17,7 @@
     <file>rector.php</file>
 
     <!-- Target minimum supported PHP version -->
-    <config name="php_version" value="70200"/>
+    <config name="php_version" value="70400"/>
 
     <!-- ****************************************** -->
     <!-- Import rules from doctrine/coding-standard -->
@@ -112,8 +112,6 @@
 
     <rule ref="SlevomatCodingStandard.TypeHints.PropertyTypeHint">
         <properties>
-            <!-- Requires PHP 7.4 -->
-            <property name="enableNativeTypeHint" value="false" />
             <!-- Requires PHP 8.0 -->
             <property name="enableMixedTypeHint" value="false" />
             <!-- Requires PHP 8.0 -->
@@ -154,9 +152,6 @@
     <!-- *********************************************************** -->
     <!-- Require native type hints for all code without a BC promise -->
     <!-- *********************************************************** -->
-    <rule ref="SlevomatCodingStandard.TypeHints.PropertyTypeHint.MissingNativeTypeHint">
-        <exclude-pattern>src</exclude-pattern>
-    </rule>
     <rule ref="SlevomatCodingStandard.TypeHints.ReturnTypeHint.MissingNativeTypeHint">
         <exclude-pattern>src</exclude-pattern>
     </rule>

rector.php

@@ -4,7 +4,9 @@
 use Rector\DeadCode\Rector\ClassLike\RemoveAnnotationRector;
 use Rector\Php56\Rector\FunctionLike\AddDefaultValueForUndefinedVariableRector;
 use Rector\Php71\Rector\FuncCall\RemoveExtraParametersRector;
+use Rector\Php73\Rector\FuncCall\JsonThrowOnErrorRector;
 use Rector\Set\ValueObject\LevelSetList;
+use Rector\TypeDeclaration\Rector\Property\TypedPropertyFromAssignsRector;
 
 return static function (RectorConfig $rectorConfig): void {
     $rectorConfig->paths([
@@ -15,7 +17,7 @@
     ]);
 
     // Modernize code
-    $rectorConfig->sets([LevelSetList::UP_TO_PHP_72]);
+    $rectorConfig->sets([LevelSetList::UP_TO_PHP_74]);
 
     $rectorConfig->skip([
         // Falsely detect unassigned variables in code paths stopped by PHPUnit\Framework\Assert::markTestSkipped()
@@ -26,6 +28,14 @@
         RemoveExtraParametersRector::class => [
             __DIR__ . '/src/Operation/',
         ],
+        // Assigns wrong type due to outdated PHPStan stubs
+        TypedPropertyFromAssignsRector::class => [
+            __DIR__ . '/src/Model/BSONIterator.php',
+        ],
+        // Not necessary in documentation examples
+        JsonThrowOnErrorRector::class => [
+            __DIR__ . '/tests/DocumentationExamplesTest.php',
+        ],
     ]);
 
     // All classes are public API by default, unless marked with @internal.

src/BulkWriteResult.php

@@ -25,14 +25,11 @@
  */
 class BulkWriteResult
 {
-    /** @var WriteResult */
-    private $writeResult;
+    private WriteResult $writeResult;
 
-    /** @var array */
-    private $insertedIds;
+    private array $insertedIds;
 
-    /** @var boolean */
-    private $isAcknowledged;
+    private bool $isAcknowledged;
 
     public function __construct(WriteResult $writeResult, array $insertedIds)
     {