NLB-6294 NewTransport clones the default http.DefaultTransport variable

Multiple parallel tests were all accessing the same pointer to a single variable for the DefaultTransport in the http package. This was leading to data races in unit tests.

Author: arussellf5

internal/communication/factory.go

@@ -63,7 +63,7 @@ func NewTLSConfig(settings configuration.Settings) *tls.Config {
 
 // NewTransport is a factory method to create a new basic Http Transport.
 func NewTransport(config *tls.Config) *netHttp.Transport {
-	transport := netHttp.DefaultTransport.(*netHttp.Transport)
+	transport := netHttp.DefaultTransport.(*netHttp.Transport).Clone()
 	transport.TLSClientConfig = config
 
 	return transport