fix(module): protect clearRequireCache against infinite recursion (#7966)

netkin-paris · web-flow · commit 7cecbccabdde · 2020-08-26T11:36:39.000+02:00
diff --git a/packages/utils/src/cjs.js b/packages/utils/src/cjs.js
@@ -20,11 +20,12 @@ export function clearRequireCache (id) {
     entry.parent.children = entry.parent.children.filter(e => e.id !== id)
   }
 
+  // Needs to be cleared before children, to protect against circular deps (#7966)
+  delete require.cache[id]
+
   for (const child of entry.children) {
     clearRequireCache(child.id)
   }
-
-  delete require.cache[id]
 }
 
 export function scanRequireTree (id, files = new Set()) {

Original file line number	Diff line number	Diff line change
`@@ -20,11 +20,12 @@ export function clearRequireCache (id) {`
`20`	`20`	`entry.parent.children = entry.parent.children.filter(e => e.id !== id)`
`21`	`21`	`}`
`22`	`22`
	`23`	`+ // Needs to be cleared before children, to protect against circular deps (#7966)`
	`24`	`+ delete require.cache[id]`
	`25`	`+`
`23`	`26`	`for (const child of entry.children) {`
`24`	`27`	`clearRequireCache(child.id)`
`25`	`28`	`}`
`26`		`-`
`27`		`- delete require.cache[id]`
`28`	`29`	`}`
`29`	`30`
`30`	`31`	`export function scanRequireTree (id, files = new Set()) {`