Skip to content

Commit 6400974

Browse files
authored
Rationalise Remote gestures (#17865)
Fixes #17803 Summary of the issue: The current gesture for switching control between the local and remote machines conflicts with the SysTrayList add-on, which is popular among those coming from JFW. Description of user facing changes Changed this gesture to be `NVDA+alt+tab`, which I feel is more intuitive. Also unbound the "Push clipboard" command, as no suitable, easily pressed combination was immediately obvious, and this command is available from the NVDA menu. Description of development approach Changed the script decorators. Testing strategy: Ran from source and checked that the new bindings work. Known issues with pull request: None.
1 parent 7d6b001 commit 6400974

File tree

2 files changed

+9
-6
lines changed

2 files changed

+9
-6
lines changed

source/globalCommands.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4886,7 +4886,6 @@ def script_toggleRemoteMute(self, gesture: "inputCore.InputGesture"):
48864886
remoteClient._remoteClient.toggleMute()
48874887

48884888
@script(
4889-
gesture="kb:control+shift+NVDA+c",
48904889
category=SCRCAT_REMOTE,
48914890
# Translators: Documentation string for the script that sends the contents of the clipboard to the remote machine.
48924891
description=_("Sends the contents of the clipboard to the remote machine"),
@@ -4956,7 +4955,7 @@ def script_toggleRemoteConnection(self, gesture: "inputCore.InputGesture") -> No
49564955
# Translators: Documentation string for the script that toggles the control between guest and host machine.
49574956
description=_("Toggles the control between guest and host machine"),
49584957
category=SCRCAT_REMOTE,
4959-
gesture="kb:NVDA+f11",
4958+
gesture="kb:NVDA+alt+tab",
49604959
)
49614960
@gui.blockAction.when(gui.blockAction.Context.REMOTE_ACCESS_DISABLED)
49624961
def script_sendKeys(self, gesture: "inputCore.InputGesture"):

user_docs/en/userGuide.md

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3662,11 +3662,15 @@ Once the session is active, you can switch between controlling the remote comput
36623662
### Remote Access Key Commands Summary {#RemoteAccessGestures}
36633663

36643664
<!-- KC:beginInclude -->
3665-
| Action | Key Command | Description |
3665+
| Name |Key |Description|
36663666
|---|---|---|
3667-
| Toggle control | `NVDA+f11` | Switch between controlling the local and remote computer. |
3668-
| Push clipboard | `NVDA+ctrl+shift+c` | Send clipboard text to the other computer. |
3669-
| Connect or disconnect | `NVDA+alt+r` | If a remote session is in progress, disconnect from it. Otherwise, start a new remote session. |
3667+
| Connect or disconnect | `NVDA+alt+r` | If a remote session is in progress, disconnects from it. Otherwise, starts a new Remote session. |
3668+
| Toggle Control | `NVDA+alt+tab` | Switches between controlling the remote and local computer. |
3669+
| Connect | None | Starts a new Remote Access session. |
3670+
| Copy link | None | Copies a link to the remote session to the clipboard. |
3671+
| Disconnect | None | Ends an existing Remote Access session. |
3672+
| Mute remote | None | Mutes or unmutes the speech coming from the remote computer. |
3673+
| Push clipboard | None | Sends the contents of the clipboard to the remote computer. |
36703674
<!-- KC:endInclude -->
36713675

36723676
You can assign further commands in the Remote section of the [Input Gestures dialog](#InputGestures).

0 commit comments

Comments
 (0)