Bugfix for Braille display detection (#18115)

closes #18114

Summary of the issue:
Braille display sometimes failing to be detected

Description of user facing changes
Description of development approach
I read the log file and found that the problem was an incorrect use of sets while populating the fallback drivers list

Author: christiancomaschi

source/bdDetect.py

@@ -1,7 +1,7 @@
 # A part of NonVisual Desktop Access (NVDA)
 # This file is covered by the GNU General Public License.
 # See the file COPYING for more details.
-# Copyright (C) 2013-2023 NV Access Limited, Babbage B.V., Leonard de Ruijter
+# Copyright (C) 2013-2025 NV Access Limited, Babbage B.V., Leonard de Ruijter, Christian Comaschi
 
 """Support for braille display detection.
 This allows devices to be automatically detected and used when they become available,
@@ -219,7 +219,7 @@ def getDriversForConnectedUsbDevices(
 		)
 	)
 
-	fallbackDriversAndMatches: list[set[str, DeviceMatch]] = []
+	fallbackDriversAndMatches: list[tuple[str, DeviceMatch]] = []
 	for match in itertools.chain(usbCustomDeviceMatches, usbHidDeviceMatchesForCustom, usbComDeviceMatches):
 		for driver, devs in _driverDevices.items():
 			if limitToDevices and driver not in limitToDevices:
@@ -228,7 +228,7 @@ def getDriversForConnectedUsbDevices(
 			for definition in usbDefinitions:
 				if definition.matches(match):
 					if definition.useAsFallback:
-						fallbackDriversAndMatches.append({driver, match})
+						fallbackDriversAndMatches.append((driver, match))
 					else:
 						yield (driver, match)
 

user_docs/en/changes.md

@@ -133,6 +133,7 @@ This option is enabled by default, but may result in increased battery depletion
   * When the Standard HID Braille Display driver is explicitly selected as the braille display driver, and the braille display list is opened, NVDA correctly identifies the HID driver as the selected driver instead of showing no driver selected. (#17537, @LeonarddeR)
   * The Humanware Brailliant driver is now more reliable in selecting the right connection endpoint, resulting in better connection stability and less errors. (#17537, @LeonarddeR)
   * Custom braille tables in the developer scratchpad are now properly ignored when running with add-ons disabled. (#17565, @LeonarddeR)
+  * Fixed an issue where some USB braille displays were not properly detected by NVDA. (#18114, @christiancomaschi)
 * Microsoft Office:
   * The command to "Report the destination URL of a link" now works as expected when using the legacy object model in Word, Outlook, Excel and PowerPoint. (#17292, #17362, #17435, @CyrilleB79)
   * In Excel, the element list dialog (`NVDA+f7`) no longer fails to list comment or formulas on some non-English systems. (#11366, @CyrilleB79)