change package name

Author: VihasMakwana

pkg/stanza/fileconsumer/internal/archive/archive_test.go

@@ -1,26 +1,28 @@
 // Copyright The OpenTelemetry Authors
 // SPDX-License-Identifier: Apache-2.0
 
-package archive // import "github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/fileconsumer/internal/archive"
+package archive_test // import "github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/fileconsumer/internal/archive_test"
 
 import (
 	"context"
 	"fmt"
 	"math/rand/v2"
 	"testing"
 
-	"github.com/google/uuid"
 	"github.com/stretchr/testify/require"
 	"go.uber.org/zap"
 
-	"github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/fileconsumer/internal/checkpoint"
+	"github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/fileconsumer/internal/archive"
 	"github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/fileconsumer/internal/fileset"
 	"github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/fileconsumer/internal/fingerprint"
 	"github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/fileconsumer/internal/reader"
-	"github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/operator"
 	"github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/testutil"
 )
 
+func archiveKey(i int) string {
+	return fmt.Sprintf("knownFiles%d", i)
+}
+
 func TestArchiveCRUD(t *testing.T) {
 	// pollsToArchiveMatrix contains different polls_to_archive settings to test
 	pollsToArchiveMatrix := []int{10, 20, 50, 100, 200}
@@ -36,10 +38,7 @@ func TestArchiveCRUD(t *testing.T) {
 
 func testArchive(t *testing.T, pollsToArchive int) {
 	persister := testutil.NewUnscopedMockPersister()
-	a := New(context.Background(), zap.L(), pollsToArchive, persister)
-	archive, isArchive := a.(*archive)
-	require.True(t, isArchive, "expected archive")
-	require.Equal(t, 0, archive.archiveIndex, "expected archiveIndex to be 0 at the beginning")
+	a := archive.New(context.Background(), zap.L(), pollsToArchive, persister)
 
 	m := make(map[int]*fingerprint.Fingerprint)
 
@@ -60,36 +59,31 @@ func testArchive(t *testing.T, pollsToArchive int) {
 		set := fileset.New[*reader.Metadata](0)
 		set.Add(&reader.Metadata{Fingerprint: fp})
 
-		archive.WriteFiles(context.Background(), set)
+		a.WriteFiles(context.Background(), set)
 	}
 
 	// sub-test 1: rolled over fingerprints should not be a part of archive
 	for _, fp := range rolledOverFps {
-		matchedData := archive.FindFiles(context.Background(), []*fingerprint.Fingerprint{fp})
+		matchedData := a.FindFiles(context.Background(), []*fingerprint.Fingerprint{fp})
 		require.Nil(t, matchedData[0])
 	}
 
 	// sub-test 2: newer fingerprints should be part of archive
-	for index, fp := range m {
-		oldMetadata, err := checkpoint.LoadKey(context.Background(), persister, archiveKey(index))
-		require.NoErrorf(t, err, "expected no error while loading metadata, got %v", err)
-		require.Lenf(t, oldMetadata, 1, "index %d should have exactly one item", index)
-
+	for _, fp := range m {
 		// FindFiles removes the data from persister.
-		matchedData := archive.FindFiles(context.Background(), []*fingerprint.Fingerprint{fp})
+		matchedData := a.FindFiles(context.Background(), []*fingerprint.Fingerprint{fp})
 		require.NotNil(t, matchedData[0])
 		require.True(t, fp.Equal(matchedData[0].GetFingerprint()), "expected fingerprints to match")
 
 		// archive should no longer contain data (as FindFiles removed the data)
-		newMetadata, err := checkpoint.LoadKey(context.Background(), persister, archiveKey(index))
-		require.NoErrorf(t, err, "expected no error while loading metadata, got %v", err)
-		require.Emptyf(t, newMetadata, "index %d should have no items, found %d items", index, len(newMetadata))
+		matchedData = a.FindFiles(context.Background(), []*fingerprint.Fingerprint{fp})
+		require.Nil(t, matchedData[0])
 	}
 }
 
 func testArchiveNop(t *testing.T) {
 	persister := testutil.NewUnscopedMockPersister()
-	a := New(context.Background(), zap.L(), -1, persister)
+	a := archive.New(context.Background(), zap.L(), -1, persister)
 
 	m := make(map[int]*fingerprint.Fingerprint)
 
@@ -105,89 +99,16 @@ func testArchiveNop(t *testing.T) {
 	}
 
 	// fingerprints should not be part of archive, as it's nop
-	for index, fp := range m {
-		oldMetadata, err := checkpoint.LoadKey(context.Background(), persister, archiveKey(index))
-		require.NoErrorf(t, err, "expected no error while loading metadata, got %v", err)
-		require.Emptyf(t, oldMetadata, "index %d should have no items, found %d items", index, len(oldMetadata))
+	for _, fp := range m {
+		matchedData := a.FindFiles(context.Background(), []*fingerprint.Fingerprint{fp})
+		require.Nil(t, matchedData[0])
 
 		// FindFiles removes the data from persister.
-		matchedData := a.FindFiles(context.Background(), []*fingerprint.Fingerprint{fp})
+		matchedData = a.FindFiles(context.Background(), []*fingerprint.Fingerprint{fp})
 		require.Nil(t, matchedData[0], "fingerprints shouldn't match for nopArchive")
 	}
 }
 
-func TestFindFilesOrder(t *testing.T) {
-	fps := make([]*fingerprint.Fingerprint, 0)
-	for i := 0; i < 100; i++ {
-		fps = append(fps, fingerprint.New([]byte(uuid.NewString())))
-	}
-	persister := testutil.NewUnscopedMockPersister()
-	fpInStorage := populatedPersisterData(persister, fps)
-
-	archive := New(context.Background(), zap.L(), 100, persister)
-	matchables := archive.FindFiles(context.Background(), fps)
-
-	require.Len(t, matchables, len(fps), "return slice should be of same length as input slice")
-
-	for i := 0; i < len(matchables); i++ {
-		if fpInStorage[i] {
-			// if current fingerprint is present in storage, the corresponding return type should not be nil
-			require.NotNilf(t, matchables[i], "resulting index %d should be not be nil type", i)
-			require.Truef(t, fps[i].Equal(matchables[i].GetFingerprint()), "fingerprint at index %d is not equal to corresponding return value", i)
-		} else {
-			// if current fingerprint is absent from storage, the corresponding index should be empty i.e. "nil"
-			require.Nil(t, matchables[i], "resulting index %d should be of nil type", i)
-		}
-	}
-}
-
-func TestIndexInBounds(t *testing.T) {
-	persister := testutil.NewUnscopedMockPersister()
-	pollsToArchive := 100
-	testArchive := New(context.Background(), zap.L(), 100, persister).(*archive)
-
-	// no index exists. archiveIndex should be 0
-	require.Equal(t, 0, testArchive.archiveIndex)
-
-	// run archiving. Each time, index should be in bound.
-	for i := 0; i < 1098; i++ {
-		require.Equalf(t, i%pollsToArchive, testArchive.archiveIndex, "Index should %d, but was %d", i%pollsToArchive, testArchive.archiveIndex)
-		testArchive.WriteFiles(context.Background(), &fileset.Fileset[*reader.Metadata]{})
-		require.Truef(t, testArchive.archiveIndex >= 0 && testArchive.archiveIndex < pollsToArchive, "Index should be between 0 and %d, but was %d", pollsToArchive, testArchive.archiveIndex)
-	}
-	oldIndex := testArchive.archiveIndex
-
-	// re-create archive
-	testArchive = New(context.Background(), zap.L(), 100, persister).(*archive)
-
-	// index should exist and new archiveIndex should be equal to oldIndex
-	require.Equalf(t, oldIndex, testArchive.archiveIndex, "New index should %d, but was %d", oldIndex, testArchive.archiveIndex)
-
-	// re-create archive, with reduced pollsToArchive
-	pollsToArchive = 70
-
-	testArchive = New(context.Background(), zap.L(), pollsToArchive, persister).(*archive)
-	// index should exist but it is out of bounds. So it should reset to 0
-	require.Equalf(t, 0, testArchive.archiveIndex, "Index should be reset to 0 but was %d", testArchive.archiveIndex)
-}
-
-func populatedPersisterData(persister operator.Persister, fps []*fingerprint.Fingerprint) []bool {
-	md := make([]*reader.Metadata, 0)
-
-	fpInStorage := make([]bool, len(fps))
-	for i, fp := range fps {
-		// 50-50 chance that a fingerprint exists in the storage
-		if rand.Float32() < 0.5 {
-			md = append(md, &reader.Metadata{Fingerprint: fp})
-			fpInStorage[i] = true // mark the fingerprint at index i in storage
-		}
-	}
-	// save half keys in knownFiles0 and other half in knownFiles1
-	_ = checkpoint.SaveKey(context.Background(), persister, md[:len(md)/2], "knownFiles0")
-	_ = checkpoint.SaveKey(context.Background(), persister, md[len(md)/2:], "knownFiles1")
-	return fpInStorage
-}
-
 func createRandomString(length int) string {
 	// some characters for the random generation
 	const letterBytes = " ,.;:*-+/[]{}<>abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ"