Skip to content

Commit ba17e78

Browse files
authored
Merge branch 'main' into main
2 parents e341bc2 + 7affb03 commit ba17e78

File tree

2 files changed

+14
-12
lines changed

2 files changed

+14
-12
lines changed

pkg/ottl/ottlfuncs/func_insert_xml_test.go

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -107,6 +107,13 @@ func Test_InsertXML(t *testing.T) {
107107
want: `<a>foo</a>`,
108108
expectErr: `InsertXML XPath selected non-element: "foo"`,
109109
},
110+
{
111+
name: "insert missing elements",
112+
document: `<a><b>has b</b></a><a></a><a><b>also has b</b></a>`,
113+
xPath: "//a[not(b)]", // elements of a which do not have a b
114+
subdoc: `<b></b>`,
115+
want: `<a><b>has b</b></a><a><b></b></a><a><b>also has b</b></a>`,
116+
},
110117
}
111118
for _, tt := range tests {
112119
t.Run(tt.name, func(t *testing.T) {

testbed/tests/log_test.go

Lines changed: 7 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -372,24 +372,19 @@ func TestLargeFileOnce(t *testing.T) {
372372

373373
func TestMemoryLimiterHit(t *testing.T) {
374374
tests := []struct {
375-
name string
376-
sender func() testbed.DataSender
377-
receiver func() testbed.DataReceiver
375+
name string
376+
sender testbed.DataSender
378377
}{
379378
{
380-
name: "otlp",
381-
sender: func() testbed.DataSender {
382-
return testbed.NewOTLPLogsDataSender(testbed.DefaultHost, testutil.GetAvailablePort(t))
383-
},
379+
name: "otlp",
380+
sender: testbed.NewOTLPLogsDataSender(testbed.DefaultHost, testutil.GetAvailablePort(t)),
384381
},
385382
{
386383
name: "filelog",
387-
sender: func() testbed.DataSender {
388-
return datasenders.NewFileLogWriter(t).WithRetry(`
384+
sender: datasenders.NewFileLogWriter(t).WithRetry(`
389385
retry_on_failure:
390386
enabled: true
391-
`)
392-
},
387+
`),
393388
},
394389
}
395390
for _, test := range tests {
@@ -422,7 +417,7 @@ func TestMemoryLimiterHit(t *testing.T) {
422417
}
423418
ScenarioMemoryLimiterHit(
424419
t,
425-
test.sender(),
420+
test.sender,
426421
otlpreceiver,
427422
testbed.LoadOptions{
428423
DataItemsPerSecond: 100000,

0 commit comments

Comments
 (0)