[receiver/hostmetrics] should report scraper that failed in case of error

[pjanotti]

Component(s)

receiver/hostmetrics

Is your feature request related to a problem? Please describe.

In case of error the receiver/hostmetrics doesn't report which scraper failed, e.g.:

1729010081650,"2024-10-15T16:34:41.650Z	error	scraperhelper/scrapercontroller.go:205	Error scraping metrics	{""kind"": ""receiver"", ""name"": ""hostmetrics"", ""data_type"": ""metrics"", ""error"": ""failed to read usage at /boot/efi: no such file or directory"", ""scraper"": ""hostmetrics""}"
1729010081650,go.opentelemetry.io/collector/receiver/scraperhelper.(*controller).scrapeMetricsAndReport
1729010081650,	go.opentelemetry.io/collector/receiver@v0.111.0/scraperhelper/scrapercontroller.go:205
1729010081650,go.opentelemetry.io/collector/receiver/scraperhelper.(*controller).startScraping.func1
1729010081650,	go.opentelemetry.io/collector/receiver@v0.111.0/scraperhelper/scrapercontroller.go:181

Describe the solution you'd like

The error message should include the scraper name so the user can consider disabling it or changing some config setting.

Describe alternatives you've considered

No response

Additional context

No response

[github-actions]

Pinging code owners:

• receiver/hostmetrics: @dmitryax @braydonk

See Adding Labels via Comments if you do not have permissions to add labels yourself.

[braydonk]

I'm not sure why, but all the scraper creation code uses hostmetrics (the type from the hostmetricsreceiver metadata package) rather than its own name. I'm not sure why it's done that way as it's before my time. @dmitryax any reason we shouldn't just adjust that code to use the respective scraper names instead of hostmetrics?

[dmitryax]

I agree. We should mention the scraper that failed

[braydonk]

This appears to have regressed with the move to this being reported by scraperhelper/obs_metrics.go:

2025-02-22T17:09:11.270Z        error   scraperhelper@v0.120.1-0.20250221111745-6de29ce16921/obs_metrics.go:61  Error scraping metrics  {"otelcol.component.id":
"hostmetrics", "otelcol.component.kind": "Receiver", "otelcol.signal": "metrics", "error": "error reading process executable for pid 0: The parameter is incorrec
t.; error reading process name for pid 0: executable path is empty; error reading process executable for pid 4: A device attached to the system is not functionin
g.; error reading process name for pid 4: executable path is empty; error reading process executable for pid 264: A device attached to the system is not function
ing.; error reading process name for pid 264: executable path is empty"}

[github-actions]

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

• receiver/hostmetricsreceiver: @dmitryax @braydonk

See Adding Labels via Comments if you do not have permissions to add labels yourself.