Add Interface Names in IP and MAC Attributes

[naman-jain-15]

Component(s)

processor/resourcedetection

Is your feature request related to a problem? Please describe.

In the current implementation of resource detection and metadata providers, host.ip and host.mac do not include interface name details. However, including this information could be beneficial in certain scenarios.

Describe the solution you'd like

// HostIPs returns the host's IP interfaces
HostIPs() ([]InterfaceIP, error)

// HostMACs returns the host's MAC addresses
HostMACs() ([]InterfaceMAC, error)

type InterfaceIP struct {
	IP            net.IP
	InterfaceName string
}

// Define a new struct for interface MACs
type InterfaceMAC struct {
	MAC           net.HardwareAddr
	InterfaceName string
}

Describe alternatives you've considered

No response

Additional context

No response

[github-actions]

Pinging code owners:

• processor/resourcedetection: @Aneurysm9 @dashpole

See Adding Labels via Comments if you do not have permissions to add labels yourself.

[odubajDT]

Hi, thanks for creating the issue. I agree with the addition of the interface name, but not into the IP or MAC attributes, as I would rather put it in a separate attribute.

Any objections about this?

Thanks

[naman-jain-15]

Hi there! I don't have any objections to your approach of putting the interface name in a separate attribute rather than combining it with the IP or MAC attributes
I can make the changes if this approach works fine
We can add this attributes
host.ip.interfaces
host.mac.interfaces

[odubajDT]

I would rather keep the current strategy that is already in place and suggest host.interface

[naman-jain-15]

But how would be able to distinguish interface if it is of MAC or is of IP

[odubajDT]

I am not a networking expert, but interfaces (and MAC adresses) are present on L2 layer of TPC/IP model, therefore there is a 1on1 binding between those two. Not sure what do you mean under interface is of. Can you please explain this more?

There is no persistent binding of interface and IP, since considering for example dynamic assignment of IP adresses via DHCP protocol (for example connecting to wifi), this can change.

What actual use case are you trying to solve with this?

Thanks

[naman-jain-15]

Yeah Makes sense . we can use host.interface as you suggested earlier . Thanks !