[cmd/mdatagen] Remove level field from metrics

Author: mx-psi

cmd/mdatagen/internal/metric.go

@@ -12,7 +12,6 @@ import (
 	"golang.org/x/text/language"
 
 	"go.opentelemetry.io/collector/component"
-	"go.opentelemetry.io/collector/config/configtelemetry"
 	"go.opentelemetry.io/collector/confmap"
 	"go.opentelemetry.io/collector/pdata/pmetric"
 )
@@ -60,11 +59,6 @@ type Metric struct {
 
 	// Attributes is the list of attributes that the metric emits.
 	Attributes []AttributeName `mapstructure:"attributes"`
-
-	// Level specifies the minimum `configtelemetry.Level` for which
-	// the metric will be emitted. This only applies to internal telemetry
-	// configuration.
-	Level configtelemetry.Level `mapstructure:"level"`
 }
 
 type Stability struct {

cmd/mdatagen/internal/samplereceiver/internal/metadata/generated_telemetry.go

@@ -11,11 +11,3 @@ type Telemetry struct {
 	Level   configtelemetry.Level `mapstructure:"level"`
 	Metrics map[MetricName]Metric `mapstructure:"metrics"`
 }
-
-func (t Telemetry) Levels() map[string]any {
-	levels := map[string]any{}
-	for _, m := range t.Metrics {
-		levels[m.Level.String()] = nil
-	}
-	return levels
-}

cmd/mdatagen/internal/telemetry.go

@@ -109,7 +109,7 @@ func NewTelemetryBuilder(settings component.TelemetrySettings, options ...Teleme
 
     {{- range $name, $metric := .Telemetry.Metrics }}
     {{- if not $metric.Optional }}
-    builder.{{ $name.Render }}, err = getLeveledMeter(builder.meter, configtelemetry.Level{{ $metric.Level }}, settings.MetricsLevel).{{ $metric.Data.Instrument }}(
+    builder.{{ $name.Render }}, err = builder.meter.{{ $metric.Data.Instrument }}(
         "otelcol_{{ $name }}",
         metric.WithDescription("{{ $metric.Description }}{{ $metric.Stability }}"),
         metric.WithUnit("{{ $metric.Unit }}"),
@@ -119,19 +119,12 @@ func NewTelemetryBuilder(settings component.TelemetrySettings, options ...Teleme
     )
     errs = errors.Join(errs, err)
     {{- if $metric.Data.Async }}
-    _, err = getLeveledMeter(builder.meter, configtelemetry.Level{{ $metric.Level }}, settings.MetricsLevel).RegisterCallback(builder.observe{{ $name.Render }}, builder.{{ $name.Render }})
+    _, err = builder.meter.RegisterCallback(builder.observe{{ $name.Render }}, builder.{{ $name.Render }})
     errs = errors.Join(errs, err)
     {{- end }}
     {{- end }}
     {{- end }}
     return &builder, errs
 }
 
-func getLeveledMeter(meter metric.Meter, cfgLevel, srvLevel configtelemetry.Level) metric.Meter {
-	if cfgLevel <= srvLevel {
-		return meter
-	}
-	return noopmetric.Meter{}
-}
-
 {{- end }}

cmd/mdatagen/internal/templates/telemetry.go.tmpl

@@ -16,7 +16,7 @@ Number of units in the batch
 
 ### otelcol_processor_batch_batch_send_size_bytes
 
-Number of bytes in batch that was sent
+Number of bytes in batch that was sent. Only available on detailed level.
 
 | Unit | Metric Type | Value Type |
 | ---- | ----------- | ---------- |

exporter/exporterhelper/internal/metadata/generated_telemetry.go

@@ -34,9 +34,8 @@ telemetry:
         value_type: int
         bucket_boundaries: [ 10, 25, 50, 75, 100, 250, 500, 750, 1000, 2000, 3000, 4000, 5000, 6000, 7000, 8000, 9000, 10000, 20000, 30000, 50000, 100000 ]
     processor_batch_batch_send_size_bytes:
-      level: detailed
       enabled: true
-      description: Number of bytes in batch that was sent
+      description: Number of bytes in batch that was sent. Only available on detailed level.
       unit: By
       histogram:
         value_type: int