Skip to content

Pull batcher does not correctly count the done/index to signal on terminate #12247

Closed
@bogdandrutu

Description

@bogdandrutu

The bug was before the conversion to done callback, but here I will show the links after done callback change.

  • If an existing batch is current with data, and a new request comes that makes the batch to exceed the minimum limit or getting split the previous done callback is not called.

See

qb.flush(ctx, reqList[i], []exporterqueue.DoneCallback{done})
even if the reqList is created
reqList, mergeSplitErr = qb.currentBatch.req.MergeSplit(ctx, qb.batchCfg.MaxSizeConfig, req)
we don't signal existing "dones".

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions