-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Closed
Labels
good first issueGood for newcomersGood for newcomersrelease:required-for-gaMust be resolved before GA releaseMust be resolved before GA release
Milestone
Description
Currently, we use the Config
term for collector configuration as a whole and parts of it defined for receivers/processors/exporters/extensions. Examples:
otelcol.Config
component.Config
otlpexporter.Config
But for unmarshalling some deeper parts of the user config, we use Settings
structs, for example:
-
exporterhelper.QueueSettings
-
configgrpc.GRPCClientSettings
-
configtls.TLSSetting
At the same time service/telemetry
package still uses Config
, e.g. MetricsConfig
, LogsSamplingConfig
, and TracesConfig
.
The suggestion is to use Config
term for all the structs used to unmarshal any parts of the YAML config provided by users. We will keep Settings
only for structs that are populated programmatically, like:
component.TelemetrySettings
component.ReceiverSettings
bogdandrutu, jpkrohling, mx-psi and andrzej-stencel
Metadata
Metadata
Assignees
Labels
good first issueGood for newcomersGood for newcomersrelease:required-for-gaMust be resolved before GA releaseMust be resolved before GA release
Type
Projects
Status
Done