Skip to content

Commit 284a750

Browse files
Revert change to if statement in endpoint_macros
1 parent 8b27773 commit 284a750

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

end_to_end_tests/golden-record-custom/custom_e2e/api/tests/defaults_tests_defaults_post.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ def httpx_request(
110110
"union_prop_with_ref": json_union_prop_with_ref,
111111
"enum_prop": json_enum_prop,
112112
}
113-
if not isinstance(json_model_prop, Unset) and json_model_prop is not None:
113+
if not isinstance(json_model_prop, Unset):
114114
params.update(json_model_prop)
115115
params.update(json_required_model_prop)
116116
params = {k: v for k, v in params.items() if v is not UNSET and v is not None}

end_to_end_tests/golden-record/my_test_api_client/api/tests/defaults_tests_defaults_post.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ def _get_kwargs(
8686
"union_prop_with_ref": json_union_prop_with_ref,
8787
"enum_prop": json_enum_prop,
8888
}
89-
if not isinstance(json_model_prop, Unset) and json_model_prop is not None:
89+
if not isinstance(json_model_prop, Unset):
9090
params.update(json_model_prop)
9191
params.update(json_required_model_prop)
9292
params = {k: v for k, v in params.items() if v is not UNSET and v is not None}

openapi_python_client/templates/endpoint_macros.py.jinja

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ params: Dict[str, Any] = {
3737
{% if property.required and not property.nullable %}
3838
params.update({{ property_name }})
3939
{% else %}
40-
if not isinstance({{ property_name }}, Unset) and {{ property_name }} is not None:
40+
if {% if not property.required %}not isinstance({{ property_name }}, Unset){% endif %}{% if not property.required and property.nullable %} and {% endif %}{% if property.nullable %}{{ property_name }} is not None{% endif %}:
4141
params.update({{ "json_" + property.python_name }})
4242
{% endif %}
4343
{% endif %}

0 commit comments

Comments
 (0)