Skip to content

Commit d173a6b

Browse files
committed
Don't double specify name in list props
1 parent c080d4c commit d173a6b

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

openapi_python_client/parser/properties/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -373,7 +373,7 @@ def build_list_property(
373373
if data.items is None:
374374
return PropertyError(data=data, detail="type array must have items defined"), schemas
375375
inner_prop, schemas = property_from_data(
376-
name=f"{name}_item", required=True, data=data.items, schemas=schemas, parent_name=f"{parent_name}_{name}"
376+
name=f"{name}_item", required=True, data=data.items, schemas=schemas, parent_name=parent_name
377377
)
378378
if isinstance(inner_prop, PropertyError):
379379
return PropertyError(data=inner_prop.data, detail=f"invalid data in items of array {name}"), schemas

tests/test_parser/test_properties/test_init.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -820,7 +820,7 @@ def test_build_list_property_invalid_items(self, mocker):
820820
assert new_schemas == second_schemas
821821
assert schemas != new_schemas, "Schema was mutated"
822822
property_from_data.assert_called_once_with(
823-
name=f"{name}_item", required=True, data=data.items, schemas=schemas, parent_name="parent_name"
823+
name=f"{name}_item", required=True, data=data.items, schemas=schemas, parent_name="parent"
824824
)
825825

826826
def test_build_list_property(self, mocker):
@@ -849,7 +849,7 @@ def test_build_list_property(self, mocker):
849849
assert new_schemas == second_schemas
850850
assert schemas != new_schemas, "Schema was mutated"
851851
property_from_data.assert_called_once_with(
852-
name=f"{name}_item", required=True, data=data.items, schemas=schemas, parent_name="parent_prop"
852+
name=f"{name}_item", required=True, data=data.items, schemas=schemas, parent_name="parent"
853853
)
854854

855855

0 commit comments

Comments
 (0)