Improved pull request "Files Changed" experience feedback #163932
Replies: 152 comments 75 replies
-
I would like to be able to scroll through the Pull Request while the comment modal is open. Reason: When a comment is outdated, we need to look at the current version to check if it actually addresses the comment. I really love this feature! THANK YOU!!! |
Beta Was this translation helpful? Give feedback.
-
Update: I just found out that it appears when there's enough space (1280px width). Here's the updated feedback. I'd like to see the branch name in the sticky header at all times so that I can easily copy it when I'm reviewing a PR. I wrote the following before thoroughly experimenting. I'd like to see the branch name when the sticky header is shown (i.e., when you've scrolled to the bottom). The reason is that when I'm reviewing a long PR and want to checkout the branch to continue reviewing it locally, I have to go back all the way up to see or copy the branch name and then go back to where I left off. |
Beta Was this translation helpful? Give feedback.
-
I find the comment indicators in the sidebar really useful. It might also be useful to have them in the "diff file header." It's very useful when you've marked a file as "viewed" because you can see how many comments it has as you're scrolling without having to expand it. |
Beta Was this translation helpful? Give feedback.
-
This is really cool. Is it also possible to seamlessly toggle hiding white spaces? If that's achievable without doing a refresh would be amazing. |
Beta Was this translation helpful? Give feedback.
-
Clicking a line number always assumes you want to add a comment. In the previous experience it only changes the URL to have deep linking. |
Beta Was this translation helpful? Give feedback.
-
This is so much better, I might go back from reviewing with the VSCode extension now 🚀 I love the new alerts panel, unfortunately it looks like pressing Maybe we could have some grouping or clustering in the alerts panel in the future. |
Beta Was this translation helpful? Give feedback.
-
I would love to see the file tree sorted alphabetically with folders on top, then files. It is quite jarring to have changed files in the middle of folders when viewing the file tree currently. Example of current state
Example of desired state
This would mirror how the majority of developers view the code in their IDE |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
Hi, I would like to play around with this, but I'm not seeing the opt-in mentioned in
Am I missing something? |
Beta Was this translation helpful? Give feedback.
-
The tab for |
Beta Was this translation helpful? Give feedback.
-
Not sure if this is the sort of feedback you're after, but the |
Beta Was this translation helpful? Give feedback.
-
|
Beta Was this translation helpful? Give feedback.
-
On the Files changed tab I can only see 19 files out of 66. Why? |
Beta Was this translation helpful? Give feedback.
-
I used to be able to click on a useful link to see the submodule diff in PRs but now its just plain text. Could we have that back pls? |
Beta Was this translation helpful? Give feedback.
-
It doesn't always seem to remember if hide whitespace was turned on. |
Beta Was this translation helpful? Give feedback.
-
Miss the colors in file tree. Worse information density in the new version is a downgrade- some unnecessary padding. |
Beta Was this translation helpful? Give feedback.
-
The comments button at the top right shows zero comments if all comments are resolved, but when I click it, it shows the resolved comments in the sidebar. It would be better if the button either:
|
Beta Was this translation helpful? Give feedback.
-
idk why, but sometimes it only shows the changes from last commit, although it says "all changes" ... this seems pretty dangerous |
Beta Was this translation helpful? Give feedback.
-
Word wrapping is missing inside suggestion blocks. The old experience works great: The new experience makes it hard to quickly read the suggestion: |
Beta Was this translation helpful? Give feedback.
-
In the old UI, I'm able to submit a review (with line comments) and don't need to fill out the review level comment field. However, in the new UI, review level comments are required, as the submit button is disabled until the text box has some data in it. I also noticed that |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
Looks really good - excited to play with it. Couple of pieces of feedback: I've noticed that the "a" option to show/hide annotations isn't working for me on the new preview. It doesn't change anything. I've also noticed that hiding comments via the UI (the "Minimize comments" option) also hides annotations which I didn't expect - I want to be able to hide one or other, not both. |
Beta Was this translation helpful? Give feedback.
-
In the new UI, the image diff are not shown. Apologies if this is a known regression. |
Beta Was this translation helpful? Give feedback.
-
2 usability issues (one is new, the other is existing):
|
Beta Was this translation helpful? Give feedback.
-
Today I had two instances where I navigated to the "Files changed" tab and saw an outdated diff. A reload fixed it. I did not have that experience on the old version yet. |
Beta Was this translation helpful? Give feedback.
-
I often review PRs after they've been merged from the In the new experience, seems like I'm unable to do so? |
Beta Was this translation helpful? Give feedback.
-
Would be great to be able to review more than the first 300 files |
Beta Was this translation helpful? Give feedback.
-
Copy/paste on Firefox desktop 140.0.2 stopped working in a line range comment, both keyboard shortcut and right click context menu. It started working again when I tried to run a screen recording for this comment, so it's not consistently reproducible |
Beta Was this translation helpful? Give feedback.
-
How it was (kind of okay but radio buttons slow things down)How it should be (buttons instead of radio buttons)(Thanks to https://github.com/refined-github/refined-github) New experience (radio buttons are still there but "submit" button is now far away from everything else) |
Beta Was this translation helpful? Give feedback.
-
Sooo good. very impressive! The new UI looks much better! |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
About the new experience
This refresh focuses on performance, accessibility, and clarity so reviews stay responsive—even on the largest pull requests.
What’s new ?
Performance 🚀
UX ✨
Accessibility ♿️
🔴 Current Issues 🔴
As of the initial public preview release, there are some limitations that will be addressed over time:
While our previous experience had hard limits on large PRs, this new experience is being built to scale. That said, we’re increasing our limits incrementally. To start with, our additional current limitations are:
How you can help
Thanks for helping us build a better review experience—we read every comment!
Beta Was this translation helpful? Give feedback.
All reactions