fix(comment): #1282 (comment)

Author: cmp0xff

pandas-stubs/core/indexes/base.pyi

@@ -15,7 +15,6 @@ from typing import (
     ClassVar,
     Literal,
     TypeAlias,
-    TypeVar,
     final,
     overload,
 )
@@ -66,8 +65,6 @@ from pandas._typing import (
     type_t,
 )
 
-_T_INDEX = TypeVar("_T_INDEX", bound=Index)  # ty: ignore[unresolved-reference]
-
 class InvalidIndexError(Exception): ...
 
 class Index(IndexOpsMixin[S1]):
@@ -408,11 +405,9 @@ class Index(IndexOpsMixin[S1]):
     @overload
     def append(self, other: Index[S1] | Sequence[Index[S1]]) -> Self: ...
     @overload
-    def append(self, other: Index[S2] | Sequence[Index[S2]]) -> Index[S1 | S2]: ...
-    @overload
-    def append(self, other: Sequence[_T_INDEX]) -> Self | _T_INDEX: ...
+    def append(self, other: Index[S2]) -> Index[S1 | S2]: ...
     @overload
-    def append(self, other: Index | Sequence) -> Index: ...
+    def append(self, other: Sequence) -> Index: ...
     def putmask(self, mask, value): ...
     def equals(self, other) -> bool: ...
     @final

tests/test_indexes.py

@@ -1036,31 +1036,31 @@ def test_append_mix() -> None:
     second = pd.Index(["a"])
     third = pd.Index([1, "a"])
     check(assert_type(first.append(second), "pd.Index[int | str]"), pd.Index)
-    check(assert_type(first.append([second]), "pd.Index[int | str]"), pd.Index)
+    check(assert_type(first.append([second]), pd.Index), pd.Index)
 
-    check(assert_type(first.append(third), "pd.Index[int | str]"), pd.Index)  # type: ignore[assert-type]
-    check(assert_type(first.append([third]), "pd.Index[int | str]"), pd.Index)  # type: ignore[assert-type]
     check(
         assert_type(  # type: ignore[assert-type]
-            first.append([second, third]),  # pyright: ignore[reportAssertTypeFailure]
-            "pd.Index[int | str]",
+            first.append(third), "pd.Index[int | str]"
         ),
         pd.Index,
     )
+    check(assert_type(first.append([third]), pd.Index), pd.Index)
+    check(assert_type(first.append([second, third]), pd.Index), pd.Index)
 
-    check(assert_type(third.append([]), "pd.Index[int | str]"), pd.Index)  # type: ignore[assert-type]
     check(
-        assert_type(third.append(cast("list[Index[Any]]", [])), "pd.Index[int | str]"),  # type: ignore[assert-type]
+        assert_type(  # type: ignore[assert-type]
+            third.append([]), "pd.Index[int | str]"
+        ),
         pd.Index,
     )
-    check(assert_type(third.append([first]), "pd.Index[int | str]"), pd.Index)  # type: ignore[assert-type]
     check(
         assert_type(  # type: ignore[assert-type]
-            third.append([first, second]),  # pyright: ignore[reportAssertTypeFailure]
-            "pd.Index[int | str]",
+            third.append(cast("list[Index[Any]]", [])), "pd.Index[int | str]"
         ),
         pd.Index,
     )
+    check(assert_type(third.append([first]), pd.Index), pd.Index)
+    check(assert_type(third.append([first, second]), pd.Index), pd.Index)
 
 
 def test_append_int() -> None: