-
-
Notifications
You must be signed in to change notification settings - Fork 18.7k
Open
Labels
CleanInternalsRelated to non-user accessible pandas implementationRelated to non-user accessible pandas implementationNumeric OperationsArithmetic, Comparison, and Logical operationsArithmetic, Comparison, and Logical operationsRefactorInternal refactoring of codeInternal refactoring of code
Description
A ton of comparison and arithmetic operations do something combination of:
-
other = lib.item_from_zerodim(other)
- listlike but not arraylike --> wrap in ndarray
- return
NotImplemented
if operating against a senior class - raise
ValueError
if there is a length mismatch
But we don't always do all of these, and we definitely don't use+test error messages as consistent as @gfyoung would like.
This behavior could all be collected+standardized in a decorator
Metadata
Metadata
Assignees
Labels
CleanInternalsRelated to non-user accessible pandas implementationRelated to non-user accessible pandas implementationNumeric OperationsArithmetic, Comparison, and Logical operationsArithmetic, Comparison, and Logical operationsRefactorInternal refactoring of codeInternal refactoring of code