refactor: don't do log out right before closing a browser in the integration tests.

php-coder · php-coder · commit 49ba80f0429e · 2019-05-27T20:17:51.000+01:00
Giving that a browser will be closed, logging out is a superfluous
action. I hope it also speed up the tests a little bit.

No functional changes.
diff --git a/src/test/robotframework/account/activation/misc-user.robot b/src/test/robotframework/account/activation/misc-user.robot
@@ -22,5 +22,4 @@ Before Test
 	Go To  ${SITE_URL}/account/activate
 
 After Test Suite
-	Log Out
 	Close Browser
diff --git a/src/test/robotframework/account/authentication/misc-user.robot b/src/test/robotframework/account/authentication/misc-user.robot
@@ -22,5 +22,4 @@ Before Test
 	Go To  ${SITE_URL}/account/auth
 
 After Test Suite
-	Log Out
 	Close Browser
diff --git a/src/test/robotframework/account/registration/misc-user.robot b/src/test/robotframework/account/registration/misc-user.robot
@@ -22,5 +22,4 @@ Before Test
 	Go To  ${SITE_URL}/account/register
 
 After Test Suite
-	Log Out
 	Close Browser
diff --git a/src/test/robotframework/auth.steps.robot b/src/test/robotframework/auth.steps.robot
@@ -1,5 +1,5 @@
 *** Settings ***
-Documentation  Common steps for login/logout of a user
+Documentation  Common steps for users authentication
 
 *** Keywords ***
 Log In As
@@ -9,7 +9,3 @@ Log In As
 	Input Text       id=login     ${login}
 	Input Password   id=password  ${password}
 	Submit Form      id=auth-account-form
-
-Log Out
-	[Documentation]  Logout the current user
-	Submit Form      id=logout-form
diff --git a/src/test/robotframework/category/creation/logic.robot b/src/test/robotframework/category/creation/logic.robot
@@ -40,5 +40,4 @@ Before Test
 	Go To  ${SITE_URL}/category/add
 
 After Test Suite
-	Log Out
 	Close Browser
diff --git a/src/test/robotframework/category/creation/misc.robot b/src/test/robotframework/category/creation/misc.robot
@@ -43,5 +43,4 @@ Before Test Suite
 	Go To                               ${SITE_URL}/category/add
 
 After Test Suite
-	Log Out
 	Close Browser
diff --git a/src/test/robotframework/category/creation/validation.robot b/src/test/robotframework/category/creation/validation.robot
@@ -92,5 +92,4 @@ Before Test Suite
 	Go To                               ${SITE_URL}/category/add
 
 After Test Suite
-	Log Out
 	Close Browser
diff --git a/src/test/robotframework/collection/add-series/validation.robot b/src/test/robotframework/collection/add-series/validation.robot
@@ -33,5 +33,4 @@ Before Test Suite
 	Go To                               ${SITE_URL}/series/2
 
 After Test Suite
-	Log Out
 	Close Browser
diff --git a/src/test/robotframework/country/creation/logic.robot b/src/test/robotframework/country/creation/logic.robot
@@ -38,7 +38,6 @@ Before Test
 	Go To  ${SITE_URL}/country/add
 
 After Test Suite
-	Log Out
 	Close Browser
 
 Country Field Should Have Option
diff --git a/src/test/robotframework/country/creation/misc.robot b/src/test/robotframework/country/creation/misc.robot
@@ -43,5 +43,4 @@ Before Test Suite
 	Go To                               ${SITE_URL}/country/add
 
 After Test Suite
-	Log Out
 	Close Browser
diff --git a/src/test/robotframework/country/creation/validation.robot b/src/test/robotframework/country/creation/validation.robot
@@ -92,5 +92,4 @@ Before Test Suite
 	Go To                               ${SITE_URL}/country/add
 
 After Test Suite
-	Log Out
 	Close Browser
diff --git a/src/test/robotframework/participant/creation/logic.robot b/src/test/robotframework/participant/creation/logic.robot
@@ -45,5 +45,4 @@ Before Test
 	Go To  ${SITE_URL}/participant/add
 
 After Test Suite
-	Log Out
 	Close Browser
diff --git a/src/test/robotframework/participant/creation/misc.robot b/src/test/robotframework/participant/creation/misc.robot
@@ -23,5 +23,4 @@ Before Test Suite
 	Go To                               ${SITE_URL}/participant/add
 
 After Test Suite
-	Log Out
 	Close Browser
diff --git a/src/test/robotframework/participant/creation/validation.robot b/src/test/robotframework/participant/creation/validation.robot
@@ -37,5 +37,4 @@ Before Test Suite
 	Go To                               ${SITE_URL}/participant/add
 
 After Test Suite
-	Log Out
 	Close Browser
diff --git a/src/test/robotframework/series/add-image/logic.robot b/src/test/robotframework/series/add-image/logic.robot
@@ -30,5 +30,4 @@ Before Test
 	Go To  ${SITE_URL}/series/1
 
 After Test Suite
-	Log Out
 	Close Browser
diff --git a/src/test/robotframework/series/add-image/validation.robot b/src/test/robotframework/series/add-image/validation.robot
@@ -62,5 +62,4 @@ Before Test Suite
 	Go To                               ${SITE_URL}/series/1
 
 After Test Suite
-	Log Out
 	Close Browser
diff --git a/src/test/robotframework/series/creation/logic-admin.robot b/src/test/robotframework/series/creation/logic-admin.robot
@@ -81,5 +81,4 @@ Before Test
 	Go To  ${SITE_URL}/series/add
 
 After Test Suite
-	Log Out
 	Close Browser
diff --git a/src/test/robotframework/series/creation/logic-user.robot b/src/test/robotframework/series/creation/logic-user.robot
@@ -67,5 +67,4 @@ Before Test
 	Go To  ${SITE_URL}/series/add
 
 After Test Suite
-	Log Out
 	Close Browser
diff --git a/src/test/robotframework/series/creation/misc-admin.robot b/src/test/robotframework/series/creation/misc-admin.robot
@@ -21,5 +21,4 @@ Before Test Suite
 	Go To                               ${SITE_URL}/series/add
 
 After Test Suite
-	Log Out
 	Close Browser
diff --git a/src/test/robotframework/series/creation/misc-user.robot b/src/test/robotframework/series/creation/misc-user.robot
@@ -92,7 +92,6 @@ Before Test Suite
 	Go To                               ${SITE_URL}/series/add
 
 After Test Suite
-	Log Out
 	Close Browser
 
 Valid Catalog Numbers Should Be Accepted
diff --git a/src/test/robotframework/series/creation/validation-admin.robot b/src/test/robotframework/series/creation/validation-admin.robot
@@ -67,5 +67,4 @@ Before Test Suite
 	Go To                               ${SITE_URL}/series/add
 
 After Test Suite
-	Log Out
 	Close Browser
diff --git a/src/test/robotframework/series/creation/validation-user.robot b/src/test/robotframework/series/creation/validation-user.robot
@@ -62,7 +62,6 @@ Before Test Suite
 	Go To                               ${SITE_URL}/series/add
 
 After Test Suite
-	Log Out
 	Close Browser
 
 Invalid Catalog Numbers Should Be Rejected
diff --git a/src/test/robotframework/series/import/request-logic.robot b/src/test/robotframework/series/import/request-logic.robot
@@ -141,7 +141,6 @@ Before Test
 	Go To  ${SITE_URL}/series/import/request
 
 After Test Suite
-	Log Out
 	Close Browser
 
 Link Should Point To
diff --git a/src/test/robotframework/series/import/validation.robot b/src/test/robotframework/series/import/validation.robot
@@ -30,5 +30,4 @@ Before Test Suite
 	Go To                               ${SITE_URL}/series/import/request
 
 After Test Suite
-	Log Out
 	Close Browser
diff --git a/src/test/robotframework/series/sales/misc.robot b/src/test/robotframework/series/sales/misc.robot
@@ -21,5 +21,4 @@ Before Test Suite
 	Go To                               ${SITE_URL}/series/1
 
 After Test Suite
-	Log Out
 	Close Browser
diff --git a/src/test/robotframework/series/sales/validation.robot b/src/test/robotframework/series/sales/validation.robot
@@ -40,5 +40,4 @@ Before Test Suite
 	Go To                               ${SITE_URL}/series/1
 
 After Test Suite
-	Log Out
 	Close Browser
diff --git a/src/test/robotframework/site/misc-admin.robot b/src/test/robotframework/site/misc-admin.robot
@@ -43,5 +43,4 @@ Before Test Suite
 	Go To                               ${SITE_URL}/
 
 After Test Suite
-	Log Out
 	Close Browser
diff --git a/src/test/robotframework/site/misc-user.robot b/src/test/robotframework/site/misc-user.robot
@@ -43,5 +43,4 @@ Before Test Suite
 	Go To                               ${SITE_URL}/
 
 After Test Suite
-	Log Out
 	Close Browser
diff --git a/src/test/robotframework/togglz/access-user.robot b/src/test/robotframework/togglz/access-user.robot
@@ -19,5 +19,4 @@ Before Test Suite
 	Log In As                           login=coder  password=test
 
 After Test Suite
-	Log Out
 	Close Browser
