From ec2a12a888f23629cacf9cd4bda68690fb5a7fa0 Mon Sep 17 00:00:00 2001
From: Niels Dossche <7771979+nielsdos@users.noreply.github.com>
Date: Thu, 21 Nov 2024 22:14:50 +0100
Subject: [PATCH] PHP 8.4: Document new errors in XML{Reader,Writer}
---
reference/xmlreader/xmlreader/open.xml | 25 ++++++++++++++++---
reference/xmlreader/xmlreader/xml.xml | 25 ++++++++++++++++---
.../xmlwriter/xmlwriter/startdocument.xml | 15 +++++++++++
3 files changed, 57 insertions(+), 8 deletions(-)
diff --git a/reference/xmlreader/xmlreader/open.xml b/reference/xmlreader/xmlreader/open.xml
index acf3a080eff4..0557b242d336 100644
--- a/reference/xmlreader/xmlreader/open.xml
+++ b/reference/xmlreader/xmlreader/open.xml
@@ -68,10 +68,20 @@
&reftitle.errors;
-
- This method may be called statically, but prior to PHP 8.0.0, will issue an
- E_DEPRECATED error in this case.
-
+
+
+
+ Passing an invalid encoding will throw a
+ ValueError.
+
+
+
+
+ This method may be called statically, but prior to PHP 8.0.0, will issue an
+ E_DEPRECATED error in this case.
+
+
+
@@ -85,6 +95,13 @@
+
+ 8.4.0
+
+ Passing an invalid encoding will now throw a
+ ValueError.
+
+
8.0.0
diff --git a/reference/xmlreader/xmlreader/xml.xml b/reference/xmlreader/xmlreader/xml.xml
index 95317a92cd5d..cb636dafcc7d 100644
--- a/reference/xmlreader/xmlreader/xml.xml
+++ b/reference/xmlreader/xmlreader/xml.xml
@@ -68,10 +68,20 @@
&reftitle.errors;
-
- This method may be called statically, but prior to PHP 8.0.0, will issue an
- E_DEPRECATED error in this case.
-
+
+
+
+ Passing an invalid encoding will throw a
+ ValueError.
+
+
+
+
+ This method may be called statically, but prior to PHP 8.0.0, will issue an
+ E_DEPRECATED error in this case.
+
+
+
@@ -85,6 +95,13 @@
+
+ 8.4.0
+
+ Passing an invalid encoding will now throw a
+ ValueError.
+
+
8.0.0
diff --git a/reference/xmlwriter/xmlwriter/startdocument.xml b/reference/xmlwriter/xmlwriter/startdocument.xml
index a8a349fe0a9b..c65ec8d1ba6d 100644
--- a/reference/xmlwriter/xmlwriter/startdocument.xml
+++ b/reference/xmlwriter/xmlwriter/startdocument.xml
@@ -68,6 +68,14 @@
+
+ &reftitle.errors;
+
+ Passing an encoding containing null bytes will
+ throw a ValueError.
+
+
+
&reftitle.changelog;
@@ -79,6 +87,13 @@
+
+ 8.4.0
+
+ Passing an encoding containing null bytes will
+ now throw a ValueError.
+
+
&xmlwriter.changelog.writer-param;