Fix SplHeap::compare arginfo and tests

Author: morrisonlevi

UPGRADING

@@ -104,6 +104,9 @@ PHP 8.0 UPGRADE NOTES
 
 - SPL:
   . SplFileObject::fgetss() has been removed.
+  . SplHeap::compare($a, $b) now specifies a method signature. Inheriting
+    classes implementing this method will now have to use a compatible
+    method signature.
 
 - Standard:
   . assert() will no longer evaluate string arguments, instead they will be

ext/spl/spl_heap.c

@@ -1188,7 +1188,7 @@ static const zend_function_entry spl_funcs_SplHeap[] = {
 	SPL_ME(SplHeap, valid,                 arginfo_splheap_void, ZEND_ACC_PUBLIC)
 	SPL_ME(SplHeap, recoverFromCorruption, arginfo_splheap_void, ZEND_ACC_PUBLIC)
 	SPL_ME(SplHeap, isCorrupted,           arginfo_splheap_void, ZEND_ACC_PUBLIC)
-	ZEND_FENTRY(compare, NULL, NULL, ZEND_ACC_PROTECTED|ZEND_ACC_ABSTRACT)
+	ZEND_FENTRY(compare, NULL, arginfo_heap_compare, ZEND_ACC_PROTECTED|ZEND_ACC_ABSTRACT)
 	PHP_FE_END
 };
 /* }}} */

ext/spl/tests/heap_isempty_variation_001.phpt

@@ -2,14 +2,14 @@
 SPL: SplHeap: isEmpty argument variation.
 --FILE--
 <?php
-class SplHeap2 extends SplHeap{
 
-  public function compare() {
-           return -parent::compare();
-       }
+class SplHeap2 extends SplHeap {
+  public function compare($a, $b) {
+    return -parent::compare($a, $b);
+  }
 }
 
-$h = new SplHeap2;
+$h = new SplHeap2();
 $h->isEmpty(1);
 ?>
 --EXPECTF--

ext/spl/tests/spl_heap_extract_parameter_error.phpt

@@ -8,7 +8,7 @@ TestFest London May 2009
 
 class TestHeap extends SplHeap {
 
-  function compare() {
+  function compare($a, $b) {
     print "This shouldn't be printed";
   }
 }