Skip to content

Commit a22dc67

Browse files
authored
hash: Use zend_string_efree() where possible (#19137)
Mainly motivated to reduce machine code bloat.
1 parent 478a520 commit a22dc67

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

ext/hash/hash.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -411,7 +411,7 @@ static void php_hash_do_hash(
411411

412412
php_hash_bin2hex(ZSTR_VAL(hex_digest), (unsigned char *) ZSTR_VAL(digest), ops->digest_size);
413413
ZSTR_VAL(hex_digest)[2 * ops->digest_size] = 0;
414-
zend_string_release_ex(digest, 0);
414+
zend_string_efree(digest);
415415
RETURN_NEW_STR(hex_digest);
416416
}
417417
}
@@ -542,7 +542,7 @@ static void php_hash_do_hash_hmac(
542542
if (n < 0) {
543543
efree(context);
544544
efree(K);
545-
zend_string_release(digest);
545+
zend_string_efree(digest);
546546
RETURN_FALSE;
547547
}
548548

@@ -568,7 +568,7 @@ static void php_hash_do_hash_hmac(
568568

569569
php_hash_bin2hex(ZSTR_VAL(hex_digest), (unsigned char *) ZSTR_VAL(digest), ops->digest_size);
570570
ZSTR_VAL(hex_digest)[2 * ops->digest_size] = 0;
571-
zend_string_release_ex(digest, 0);
571+
zend_string_efree(digest);
572572
RETURN_NEW_STR(hex_digest);
573573
}
574574
}
@@ -829,7 +829,7 @@ PHP_FUNCTION(hash_final)
829829

830830
php_hash_bin2hex(ZSTR_VAL(hex_digest), (unsigned char *) ZSTR_VAL(digest), digest_len);
831831
ZSTR_VAL(hex_digest)[2 * digest_len] = 0;
832-
zend_string_release_ex(digest, 0);
832+
zend_string_efree(digest);
833833
RETURN_NEW_STR(hex_digest);
834834
}
835835
}

0 commit comments

Comments
 (0)