From fa67161788e706b43bbcb379a71cff907a209443 Mon Sep 17 00:00:00 2001 From: "Christoph M. Becker" Date: Wed, 14 Aug 2024 21:36:26 +0200 Subject: [PATCH 1/2] Explicitly drop support for old clang versions on Windows This ensures compatibility with the typedef redefinitions we use, and makes it clear during the `configure` stage that old compiler versions are not supported. See regarding the release history of clang. --- win32/build/confutils.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/win32/build/confutils.js b/win32/build/confutils.js index b72950954c0f7..4143f2ea61cb9 100644 --- a/win32/build/confutils.js +++ b/win32/build/confutils.js @@ -3074,7 +3074,9 @@ function toolset_get_compiler_version() version = RegExp.$1; version = version.replace(/\./g, ''); version = version/100 < 1 ? version*10 : version; - + if (version < 400) { + ERROR("Building with clang " + version + " is no longer supported"); + } return version; } } else if (ICC_TOOLSET) { From ebd092ff230ba6d479303b9c47e6f4f855d189c0 Mon Sep 17 00:00:00 2001 From: "Christoph M. Becker" Date: Wed, 14 Aug 2024 21:50:08 +0200 Subject: [PATCH 2/2] Remove no longer required catering about two number versions Up to clang 3.4, the versions had no revision number; only as of clang 3.4.1 they have, and since we're going to drop support for such old versions anyway, we don't need to cater to two number versions any longer. --- win32/build/confutils.js | 1 - 1 file changed, 1 deletion(-) diff --git a/win32/build/confutils.js b/win32/build/confutils.js index 4143f2ea61cb9..78d4291f2feed 100644 --- a/win32/build/confutils.js +++ b/win32/build/confutils.js @@ -3073,7 +3073,6 @@ function toolset_get_compiler_version() if (full.match(/clang version ([\d\.]+)/)) { version = RegExp.$1; version = version.replace(/\./g, ''); - version = version/100 < 1 ? version*10 : version; if (version < 400) { ERROR("Building with clang " + version + " is no longer supported"); }