From 2e7332b4404c5271670c1781dbb18539d30dd796 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tim=20D=C3=BCsterhus?= Date: Wed, 16 Jul 2025 09:12:41 +0200 Subject: [PATCH] zend_objects: Remove unnecessary refcounting when calling `__clone()` Found as part of the clone-with review in php/php-src#18747. --- Zend/zend_objects.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/Zend/zend_objects.c b/Zend/zend_objects.c index 45bbc60cdb33f..933c1161fe960 100644 --- a/Zend/zend_objects.c +++ b/Zend/zend_objects.c @@ -264,7 +264,6 @@ ZEND_API void ZEND_FASTCALL zend_objects_clone_members(zend_object *new_object, } if (has_clone_method) { - GC_ADDREF(new_object); zend_call_known_instance_method_with_0_params(new_object->ce->clone, new_object, NULL); if (ZEND_CLASS_HAS_READONLY_PROPS(new_object->ce)) { @@ -274,8 +273,6 @@ ZEND_API void ZEND_FASTCALL zend_objects_clone_members(zend_object *new_object, Z_PROP_FLAG_P(prop) &= ~IS_PROP_REINITABLE; } } - - OBJ_RELEASE(new_object); } }