From e510c6d0bf09a6664088130148449d8bb798d3d4 Mon Sep 17 00:00:00 2001 From: Hayden Flinner Date: Tue, 13 Sep 2022 10:12:03 -0400 Subject: [PATCH] Prevent swallowing of ValueError in core.py Traceback that this leads to: ``` File .../python3.9/site-packages/plotly/express/_core.py:2226, in make_figure(args, constructor, trace_patch, layout_patch) 2223 if args.get("marginal_y") is not None: 2224 ncols += 1 -> 2226 fig = init_figure( 2227 args, subplot_type, frame_list, nrows, ncols, col_labels, row_labels 2228 ) 2230 # Position traces in subplots 2231 for frame in frame_list: File .../python3.9/site-packages/plotly/express/_core.py:2373, in init_figure(args, subplot_type, frame_list, nrows, ncols, col_labels, row_labels) 2370 _spacing_error_translator(e, "Vertical", "facet_row_spacing") 2372 # Remove explicit font size of row/col titles so template can take over -> 2373 for annot in fig.layout.annotations: 2374 annot.update(font=None) 2376 return fig UnboundLocalError: local variable 'fig' referenced before assignment ``` --- packages/python/plotly/plotly/express/_core.py | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/python/plotly/plotly/express/_core.py b/packages/python/plotly/plotly/express/_core.py index dd2d53be1ed..5e00a06bff2 100644 --- a/packages/python/plotly/plotly/express/_core.py +++ b/packages/python/plotly/plotly/express/_core.py @@ -2368,6 +2368,7 @@ def _spacing_error_translator(e, direction, facet_arg): except ValueError as e: _spacing_error_translator(e, "Horizontal", "facet_col_spacing") _spacing_error_translator(e, "Vertical", "facet_row_spacing") + raise # Remove explicit font size of row/col titles so template can take over for annot in fig.layout.annotations: