Skip to content

Commit 613a362

Browse files
authored
fix Banner spacing (#6190)
1 parent 2317ca8 commit 613a362

File tree

87 files changed

+17
-2
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

87 files changed

+17
-2
lines changed

.changeset/big-hairs-agree.md

Lines changed: 5 additions & 0 deletions

packages/react/src/Banner/Banner.module.css

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -121,6 +121,10 @@
121121
margin-inline-start: var(--base-size-4);
122122
}
123123

124+
:where(.Banner):has(.BannerActions) .BannerDismiss {
125+
margin-block: var(--base-size-2);
126+
}
127+
124128
.BannerDismiss svg {
125129
/* stylelint-disable-next-line primer/colors */
126130
color: var(--banner-icon-fgColor);
@@ -132,6 +136,7 @@
132136
display: flex;
133137
column-gap: var(--base-size-12);
134138
align-items: center;
139+
margin-block: var(--base-size-2);
135140
}
136141

137142
.BannerActions :where([data-primary-action='trailing']) {
@@ -189,6 +194,12 @@
189194
grid-template-columns: auto auto;
190195
}
191196

197+
:where(.Banner):not([data-dismissible])
198+
:where(.BannerActionsContainer[data-primary-action='trailing'])
199+
:where([data-variant='link']:only-child) {
200+
padding-inline: 0 var(--base-size-12);
201+
}
202+
192203
.BannerActions [data-primary-action='trailing'] {
193204
display: flex;
194205
min-height: var(--base-size-32, 2rem);

packages/react/src/Banner/Banner.stories.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,8 +63,7 @@ export const Playground: StoryObj<typeof Banner> = {
6363
},
6464
args: {
6565
title: 'Banner title',
66-
description:
67-
'GitHub users are now required to en able two-factor authentication as an additional security measure.',
66+
description: 'GitHub users are now required to enable two-factor authentication as an additional security measure.',
6867
variant: 'info',
6968
},
7069
argTypes: {

0 commit comments

Comments
 (0)