merge in master

Author: catarak

client/components/Nav.jsx

@@ -485,7 +485,7 @@ class Nav extends React.PureComponent {
               }
             }}
           >
-            <span className="nav__item-header">Help & Feedback</span>
+            <span className="nav__item-header">Help</span>
             <InlineSVG className="nav__item-header-triangle" src={triangleUrl} />
           </button>
           <ul className="nav__dropdown">
@@ -519,16 +519,6 @@ class Nav extends React.PureComponent {
                 About
               </Link>
             </li>
-            <li className="nav__dropdown-item">
-              <Link
-                to="/feedback"
-                onFocus={this.handleFocusForHelp}
-                onBlur={this.handleBlur}
-                onClick={this.setDropdownForNone}
-              >
-                Feedback
-              </Link>
-            </li>
           </ul>
         </li>
       </ul>

client/components/__test__/__snapshots__/Nav.test.jsx.snap

@@ -281,7 +281,7 @@ exports[`Nav renders correctly 1`] = `
         <span
           className="nav__item-header"
         >
-          Help & Feedback
+          Help
         </span>
         <span
           className="isvg loading nav__item-header-triangle"
@@ -327,18 +327,6 @@ exports[`Nav renders correctly 1`] = `
             About
           </a>
         </li>
-        <li
-          className="nav__dropdown-item"
-        >
-          <a
-            onBlur={[Function]}
-            onClick={[Function]}
-            onFocus={[Function]}
-            style={Object {}}
-          >
-            Feedback
-          </a>
-        </li>
       </ul>
     </li>
   </ul>

client/constants.js

@@ -116,9 +116,6 @@ export const HIDE_ERROR_MODAL = 'HIDE_ERROR_MODAL';
 export const PERSIST_STATE = 'PERSIST_STATE';
 export const CLEAR_PERSISTED_STATE = 'CLEAR_PERSISTED_STATE';
 
-export const SHOW_HELP_MODAL = 'SHOW_HELP_MODAL';
-export const HIDE_HELP_MODAL = 'HIDE_HELP_MODAL';
-
 export const HIDE_RUNTIME_ERROR_WARNING = 'HIDE_RUNTIME_ERROR_WARNING';
 export const SHOW_RUNTIME_ERROR_WARNING = 'SHOW_RUNTIME_ERROR_WARNING';
 export const SET_ASSETS = 'SET_ASSETS';

client/modules/IDE/actions/ide.js

@@ -232,19 +232,6 @@ export function hideErrorModal() {
   };
 }
 
-export function showHelpModal(helpType) {
-  return {
-    type: ActionTypes.SHOW_HELP_MODAL,
-    helpType
-  };
-}
-
-export function hideHelpModal() {
-  return {
-    type: ActionTypes.HIDE_HELP_MODAL
-  };
-}
-
 export function hideRuntimeErrorWarning() {
   return {
     type: ActionTypes.HIDE_RUNTIME_ERROR_WARNING

client/modules/IDE/components/Console.jsx

@@ -77,7 +77,7 @@ class Console extends React.Component {
     });
 
     return (
-      <div className={consoleClass} role="main" title="console">
+      <div className={consoleClass} role="main">
         <div className="preview-console__header">
           <h2 className="preview-console__header-title">Console</h2>
           <div className="preview-console__header-buttons">

client/modules/IDE/components/CopyableInput.jsx

@@ -70,7 +70,6 @@ class CopyableInput extends React.Component {
             rel="noopener noreferrer"
             href={value}
             className="copyable-input__preview"
-            title={`open ${label.toLowerCase()} view in new tab`}
           >
             <InlineSVG src={shareUrl} alt={`open ${label} view in new tab`} />
           </a>

client/modules/IDE/components/Editor.jsx

@@ -312,7 +312,6 @@ class Editor extends React.Component {
 
     return (
       <section
-        title="code editor"
         role="main"
         className={editorSectionClass}
       >

client/modules/IDE/components/HTTPSModal.jsx

@@ -92,7 +92,7 @@ class Preferences extends React.Component {
     const beep = new Audio(beepUrl);
 
     return (
-      <section className="preferences" title="preference-menu">
+      <section className="preferences">
         <Helmet>
           <title>p5.js Web Editor | Preferences</title>
         </Helmet>

client/modules/IDE/components/Preferences.jsx

@@ -360,7 +360,7 @@ class PreviewFrame extends React.Component {
         aria-label="sketch output"
         role="main"
         frameBorder="0"
-        title="sketch output"
+        title="sketch preview"
         ref={(element) => { this.iframeElement = element; }}
         sandbox="allow-scripts allow-pointer-lock allow-same-origin allow-popups allow-forms allow-modals"
       />