Merge pull request #8763 from gimmyxd/PUP-11217

(PUP-11217) do not eager load Puppet's HttpClient

Author: ciprianbadescu

lib/puppet/test/test_helper.rb

@@ -142,7 +142,8 @@ def self.before_each_test()
         },
         "Context for specs")
 
-      Puppet.runtime.load_services
+      # trigger `require 'facter'`
+      Puppet.runtime[:facter]
 
       Puppet::Parser::Functions.reset
       Puppet::Application.clear!

spec/unit/network/http/connection_spec.rb

@@ -561,7 +561,6 @@ def retry_after(datetime)
       end
 
       it "should sleep for no more than the Puppet runinterval" do
-        Puppet.runtime.clear
         retry_after('60')
 
         Puppet[:runinterval] = 30

spec/unit/network/http_pool_spec.rb

@@ -37,7 +37,6 @@ def initialize(host, port, options = {})
     end
 
     it "switches to the external client implementation" do
-      Puppet.runtime.clear
       Puppet::Network::HttpPool.http_client_class = http_impl
 
       expect(Puppet.runtime[:http]).to be_an_instance_of(Puppet::HTTP::ExternalClient)