(PUP-10853) Remove usage of legacy facts #8492
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins please test this |
1 similar comment
|
jenkins please test this |
GabrielNagy
force-pushed
the
PUP-10853/remove-legacy-facts
branch
from
b2cc959 to
1deec79
Compare
|
jenkins please test this on all |
GabrielNagy
force-pushed
the
PUP-10853/remove-legacy-facts
branch
from
1deec79 to
bc6af4a
Compare
|
jenkins please test this on all |
GabrielNagy
force-pushed
the
PUP-10853/remove-legacy-facts
branch
from
bc6af4a to
4328a2f
Compare
As we're moving away from legacy facts we also need to bump the minimum Facter version, since Facter 2 does not have structured facts, and Facter 3 provides no API for accessing them in a dot-notation format.
Use structured facts instead of legacy OS facts. The following mapping applies: operatingsystem => os.name osfamily => os.family operatingsystemrelease => os.release.full operatingsystemmajrelease => os.release.major lsbdistrelease => os.distro.release.full macosx_productversion_major => os.macosx.version.major
Use structured facts instead of legacy networking facts. The following mapping applies: fqdn => networking.fqdn domain => networking.domain hostname => networking.hostname ipaddress => networking.ip ipaddress6 => networking.ip6 Change `processorcount` to `processors.count`.
GabrielNagy
force-pushed
the
PUP-10853/remove-legacy-facts
branch
from
f280c44 to
b992851
Compare
|
jenkins please test this on all |
gimmyxd
approved these changes
Feb 25, 2021
This was referenced Mar 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to replace all usage of legacy facts with structured facts. The minimum Facter dependency also has to be bumped since Facter 2 does not have structured facts.