(PUP-10951) Allow splat operator inside overridden resource collectors #8535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 8bdaaec removed the `when CapabilityMapping` statement, but didn't remove the corresponding issue. I was thinking of Java switch/case, where multiple cases fall through. This makes it possible to use the splat operator to override attributes for collected resources.
justinstoller
approved these changes
Mar 9, 2021
|
Seems pretty straight forward with the context given in the commit message |
This was referenced Mar 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 8bdaaec removed the
when CapabilityMappingstatement, but didn'tremove the corresponding issue. I was thinking of Java switch/case, where
multiple cases fall through. This makes it possible to use the splat operator to
override attributes for collected resources.