Django 2.2 for python3 setup

Author: p1c2u

README.rst

@@ -134,7 +134,7 @@ Integrations
 Django
 ******
 
-You can use DjangoOpenAPIRequest a Django request factory:
+For Django 2.2 you can use DjangoOpenAPIRequest a Django request factory:
 
 .. code-block:: python
 

setup.cfg

@@ -43,7 +43,7 @@ exclude =
     tests
 
 [options.extras_require]
-django = django
+django = django>=2.2; python_version>="3.0"
 flask = werkzeug
 
 [tool:pytest]

tests/integration/contrib/test_django.py

@@ -1,6 +1,5 @@
-from django.http import HttpResponse, HttpResponseRedirect
-from django.test.client import RequestFactory
-from django.urls import resolve
+import sys
+
 import pytest
 from six import b
 
@@ -13,41 +12,58 @@
 from openapi_core.validation.response.validators import ResponseValidator
 
 
-@pytest.fixture(autouse=True, scope='module')
-def django_settings():
-    import django
-    from django.conf import settings
-    from django.contrib import admin
-    from django.urls import path
-    settings.configure(
-        ALLOWED_HOSTS=[
-            'testserver',
-        ],
-        INSTALLED_APPS=[
-            'django.contrib.admin',
-            'django.contrib.auth',
-            'django.contrib.contenttypes',
-            'django.contrib.messages',
-            'django.contrib.sessions',
-        ],
-        MIDDLEWARE=[
-            'django.contrib.sessions.middleware.SessionMiddleware',
-            'django.contrib.auth.middleware.AuthenticationMiddleware',
-            'django.contrib.messages.middleware.MessageMiddleware',
-        ]
-    )
-    django.setup()
-    settings.ROOT_URLCONF = (
-        path('admin/', admin.site.urls),
-    )
-
-
-class TestDjangoOpenAPIRequest(object):
+@pytest.mark.skipif(sys.version_info < (3, 0), reason="requires python3")
+class BaseTestDjango(object):
+
+    @pytest.fixture(autouse=True, scope='module')
+    def django_settings(self):
+        import django
+        from django.conf import settings
+        from django.contrib import admin
+        from django.urls import path
+
+        if settings.configured:
+            return
+
+        settings.configure(
+            ALLOWED_HOSTS=[
+                'testserver',
+            ],
+            INSTALLED_APPS=[
+                'django.contrib.admin',
+                'django.contrib.auth',
+                'django.contrib.contenttypes',
+                'django.contrib.messages',
+                'django.contrib.sessions',
+            ],
+            MIDDLEWARE=[
+                'django.contrib.sessions.middleware.SessionMiddleware',
+                'django.contrib.auth.middleware.AuthenticationMiddleware',
+                'django.contrib.messages.middleware.MessageMiddleware',
+            ]
+        )
+        django.setup()
+        settings.ROOT_URLCONF = (
+            path('admin/', admin.site.urls),
+        )
 
     @pytest.fixture
     def request_factory(self):
+        from django.test.client import RequestFactory
         return RequestFactory()
 
+    @pytest.fixture
+    def response_factory(self):
+        from django.http import HttpResponse
+
+        def create(content=b(''), status_code=None):
+            return HttpResponse(content, status=status_code)
+
+        return create
+
+
+class TestDjangoOpenAPIRequest(BaseTestDjango):
+
     def test_no_resolver(self, request_factory):
         request = request_factory.get('/admin/')
 
@@ -73,6 +89,7 @@ def test_no_resolver(self, request_factory):
         assert openapi_request.mimetype == request.content_type
 
     def test_simple(self, request_factory):
+        from django.urls import resolve
         request = request_factory.get('/admin/')
         request.resolver_match = resolve('/admin/')
 
@@ -98,6 +115,7 @@ def test_simple(self, request_factory):
         assert openapi_request.mimetype == request.content_type
 
     def test_url_rule(self, request_factory):
+        from django.urls import resolve
         request = request_factory.get('/admin/auth/group/1/')
         request.resolver_match = resolve('/admin/auth/group/1/')
 
@@ -126,10 +144,10 @@ def test_url_rule(self, request_factory):
         assert openapi_request.mimetype == request.content_type
 
 
-class TestDjangoOpenAPIResponse:
+class TestDjangoOpenAPIResponse(BaseTestDjango):
 
-    def test_stream_response(self):
-        response = HttpResponse()
+    def test_stream_response(self, response_factory):
+        response = response_factory()
         response.writelines(['foo\n', 'bar\n', 'baz\n'])
 
         openapi_response = DjangoOpenAPIResponse(response)
@@ -138,8 +156,8 @@ def test_stream_response(self):
         assert openapi_response.status_code == response.status_code
         assert openapi_response.mimetype == response["Content-Type"]
 
-    def test_redirect_response(self):
-        response = HttpResponseRedirect('/redirected/')
+    def test_redirect_response(self, response_factory):
+        response = response_factory('/redirected/', status_code=302)
 
         openapi_response = DjangoOpenAPIResponse(response)
 
@@ -148,30 +166,28 @@ def test_redirect_response(self):
         assert openapi_response.mimetype == response["Content-Type"]
 
 
-class TestDjangoOpenAPIValidation(object):
-
-    @pytest.fixture
-    def request_factory(self):
-        return RequestFactory()
+class TestDjangoOpenAPIValidation(BaseTestDjango):
 
     @pytest.fixture
     def django_spec(self, factory):
         specfile = 'data/v3.0/django_factory.yaml'
         return create_spec(factory.spec_from_file(specfile))
 
     def test_response_validator_path_pattern(
-            self, django_spec, request_factory):
+            self, django_spec, request_factory, response_factory):
+        from django.urls import resolve
         validator = ResponseValidator(django_spec)
         request = request_factory.get('/admin/auth/group/1/')
         request.resolver_match = resolve('/admin/auth/group/1/')
         openapi_request = DjangoOpenAPIRequest(request)
-        response = HttpResponse(b('Some item'))
+        response = response_factory(b('Some item'))
         openapi_response = DjangoOpenAPIResponse(response)
         result = validator.validate(openapi_request, openapi_response)
         assert not result.errors
 
     def test_request_validator_path_pattern(
             self, django_spec, request_factory):
+        from django.urls import resolve
         validator = RequestValidator(django_spec)
         request = request_factory.get('/admin/auth/group/1/')
         request.resolver_match = resolve('/admin/auth/group/1/')