code review updates

Author: TMisiukiewicz

docs/projects.md

@@ -103,7 +103,7 @@ The list should contain the name of the components, as they're registered in the
 
 #### project.ios.automaticPodsInstallation
 
-A boolean value to determine if you want to automatically install CocoaPods when running `run-ios` or `build-ios` command and:
+A boolean value to determine if you want to automatically install CocoaPods when running `run-ios` or `build-ios` command when:
 - they are not yet installed
 - a new dependency visible for autolinking is installed
 - a version of existing native dependency has changed

packages/cli-platform-ios/src/commands/buildIOS/index.ts

@@ -13,12 +13,11 @@ import {getConfiguration} from './getConfiguration';
 import {getXcodeProjectAndDir} from './getXcodeProjectAndDir';
 import resolvePods from '../../tools/pods';
 import getArchitecture from '../../tools/getArchitecture';
-import forcePodsNoEffectLogger from '../../tools/forcePodsNoEffectLogger';
 
 async function buildIOS(_: Array<string>, ctx: Config, args: BuildFlags) {
   const {xcodeProject, sourceDir} = getXcodeProjectAndDir(ctx.project.ios);
 
-  if (ctx.project.ios?.automaticPodsInstallation) {
+  if (ctx.project.ios?.automaticPodsInstallation || args.forcePods) {
     const isAppRunningNewArchitecture = ctx.project.ios?.sourceDir
       ? await getArchitecture(ctx.project.ios?.sourceDir)
       : undefined;
@@ -27,8 +26,6 @@ async function buildIOS(_: Array<string>, ctx: Config, args: BuildFlags) {
       forceInstall: args.forcePods,
       newArchEnabled: isAppRunningNewArchitecture,
     });
-  } else if (args.forcePods) {
-    forcePodsNoEffectLogger();
   }
 
   process.chdir(sourceDir);

packages/cli-platform-ios/src/commands/runIOS/index.ts

@@ -30,7 +30,6 @@ import getSimulators from '../../tools/getSimulators';
 import {getXcodeProjectAndDir} from '../buildIOS/getXcodeProjectAndDir';
 import resolvePods from '../../tools/pods';
 import getArchitecture from '../../tools/getArchitecture';
-import forcePodsNoEffectLogger from '../../tools/forcePodsNoEffectLogger';
 
 export interface FlagsT extends BuildFlags {
   simulator?: string;
@@ -49,7 +48,7 @@ async function runIOS(_: Array<string>, ctx: Config, args: FlagsT) {
   let {packager, port} = args;
 
   // check if pods need to be installed
-  if (ctx.project.ios?.automaticPodsInstallation) {
+  if (ctx.project.ios?.automaticPodsInstallation || args.forcePods) {
     const isAppRunningNewArchitecture = ctx.project.ios?.sourceDir
       ? await getArchitecture(ctx.project.ios?.sourceDir)
       : undefined;
@@ -58,8 +57,6 @@ async function runIOS(_: Array<string>, ctx: Config, args: FlagsT) {
       forceInstall: args.forcePods,
       newArchEnabled: isAppRunningNewArchitecture,
     });
-  } else if (args.forcePods) {
-    forcePodsNoEffectLogger();
   }
 
   if (packager) {

packages/cli-platform-ios/src/tools/forcePodsNoEffectLogger.ts

@@ -170,9 +170,8 @@ async function createFromTemplate({
       packageName,
     });
 
-    createDefaultConfigFile(projectDirectory);
+    createDefaultConfigFile(projectDirectory, loader);
 
-    loader.succeed();
     const {postInitScript} = templateConfig;
     if (postInitScript) {
       loader.info('Executing post init script ');
@@ -285,27 +284,25 @@ It's created by CLI rather than being a part of a template to avoid displaying t
 as it might bring confusion for existing projects where this change might not be applicable.
 For more details, see https://github.com/react-native-community/cli/blob/main/docs/projects.md#projectiosautomaticpodsinstallation
 */
-function createDefaultConfigFile(directory: string) {
+function createDefaultConfigFile(directory: string, loader: Loader) {
   const cliConfigContent = {
     project: {
       ios: {
         automaticPodsInstallation: true,
       },
     },
   };
-
+  const configFileContent = `module.exports = ${JSON.stringify(
+    cliConfigContent,
+    null,
+    2,
+  )}`;
   const filepath = 'react-native.config.js';
   try {
     if (!doesDirectoryExist(path.join(directory, filepath))) {
-      fs.writeFileSync(
-        filepath,
-        sanitizeConfigFile(
-          `module.exports = ${JSON.stringify(cliConfigContent, null, 2)}`,
-        ),
-        {
-          encoding: 'utf-8',
-        },
-      );
+      fs.writeFileSync(filepath, sanitizeConfigFile(configFileContent), {
+        encoding: 'utf-8',
+      });
     } else {
       const existingConfigFile = require(path.join(directory, filepath));
 
@@ -320,11 +317,12 @@ function createDefaultConfigFile(directory: string) {
         encoding: 'utf-8',
       });
     }
+    loader.succeed();
   } catch {
-    logger.warn(
+    loader.warn(
       `Could not create custom ${chalk.bold(
         'react-native.config.js',
-      )} file. You can create it manually in your project's root folder.`,
+      )} file. You can create it manually in your project's root folder with the following content: \n\n${configFileContent}`,
     );
   }
 }