Skip to content

Commit 4e2ce88

Browse files
committed
Improve PHP 8.4+ support by avoiding implicitly nullable types
1 parent 16d653f commit 4e2ce88

File tree

3 files changed

+4
-2
lines changed

3 files changed

+4
-2
lines changed

.github/workflows/ci.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ jobs:
1111
strategy:
1212
matrix:
1313
php:
14+
- 8.4
1415
- 8.3
1516
- 8.2
1617
- 8.1
@@ -30,6 +31,7 @@ jobs:
3031
strategy:
3132
matrix:
3233
php:
34+
- 8.4
3335
- 8.3
3436
- 8.2
3537
- 8.1

composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
"require": {
2929
"php": ">=8.1",
3030
"react/event-loop": "^1.2",
31-
"react/promise": "^3.0 || ^2.8 || ^1.2.1"
31+
"react/promise": "^3.2@dev || ^2.8 || ^1.2.1"
3232
},
3333
"require-dev": {
3434
"phpstan/phpstan": "1.10.39",

src/FiberFactory.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ public static function create(): FiberInterface
2222
return (self::factory())();
2323
}
2424

25-
public static function factory(\Closure $factory = null): \Closure
25+
public static function factory(?\Closure $factory = null): \Closure
2626
{
2727
if ($factory !== null) {
2828
self::$factory = $factory;

0 commit comments

Comments
 (0)