Fixes for latest rust #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| let value = Dropper(counter_clone); | ||
| let t = Thunk::<()>::new(move || { | ||
| // Get a reference so value is captured. | ||
| let _x = &value; | ||
|
|
||
| panic!("Muahahahah") |
There was a problem hiding this comment.
It's no longer possible to handle panics from scoped threads (PR #22435). I'm not entirely sure if the panic was relevant to the test logic.
There was a problem hiding this comment.
Yes, the panic is actually quite important, since this is testing the behavior of a thunk under a panic.
There was a problem hiding this comment.
Makes sense, although I don't know how to fix it.
andresilva
force-pushed
the
fix-latest-rust
branch
3 times, most recently
from
9cefc36 to
e8fd0d9
Compare
andresilva
force-pushed
the
fix-latest-rust
branch
from
e8fd0d9 to
b7f87a5
Compare
|
I've updated to rust 1.0.0-nightly (12b846ab8 2015-03-09) (built 2015-03-09). It is now possible to join spawned threads and handle panics, so the original unit test behavior is restored. |
|
Excellent! Thank you very much. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for rustc 1.0.0-nightly (b47aebe3f 2015-02-26) (built 2015-02-26).